Skip to content

Initial secret information added#562

Merged
adellape merged 2 commits intoopenshift:masterfrom
bfallonf:secrets
Jun 19, 2015
Merged

Initial secret information added#562
adellape merged 2 commits intoopenshift:masterfrom
bfallonf:secrets

Conversation

@bfallonf
Copy link

@pmorie As discussed. This is info grabbed from the upstream docs and other PRs. A few things:

  1. I put in an example json. It can always be taken out if a yaml is better in your opinion.
  2. Is the "Creating Secrets" part correct? Did I see somewhere there are actualt oc secret command? Can't re-find.
  3. A lot of the information you defined in your skeleton is missing. Is there anything you can help fill in? Or maybe other places I get that info from?
  4. The examples you listed here don't match the examples in the upstream doc. Is that on purpose? Wondering if the upstream examples are not viable use cases, and your suggestions are.

Thanks.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is actually an exception to this -- since secret data does not come to rest on the node, if the node is rebooted, the secret data must be re-read from the API server.

@pmorie
Copy link

pmorie commented Jun 19, 2015

@bfallonf @adellape IMO this is a great start. @adellape feel good about merging?

@adellape
Copy link
Contributor

@pmorie It brings me great pleasure to merge. I'll do a quick follow-up PR to actually get it into the buildcfg, and to fix a broken link.

@adellape adellape changed the title [do not merge] Initial secret information added Initial secret information added Jun 19, 2015
adellape added a commit that referenced this pull request Jun 19, 2015
Initial secret information added
@adellape adellape merged commit 2f4ba94 into openshift:master Jun 19, 2015
@adellape
Copy link
Contributor

@bfallonf BTW per your question in the PR's initial comment, use YAML instead of JSON when you can.

@pmorie
Copy link

pmorie commented Jun 19, 2015

@adellape i knew i had missed something re: buildconfig

@adellape
Copy link
Contributor

@pmorie Putting it together atm, no worries.

@adellape
Copy link
Contributor

Followed up in #576.

@bfallonf bfallonf deleted the secrets branch June 21, 2015 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants