Skip to content

IDMS and ITMS are supported since 4.13, not 4.8#60405

Merged
mburke5678 merged 1 commit intoopenshift:enterprise-4.12from
mburke5678:mco-remove-idms-itms
May 23, 2023
Merged

IDMS and ITMS are supported since 4.13, not 4.8#60405
mburke5678 merged 1 commit intoopenshift:enterprise-4.12from
mburke5678:mco-remove-idms-itms

Conversation

@mburke5678
Copy link
Copy Markdown
Contributor

@mburke5678 mburke5678 commented May 22, 2023 •
edited
Loading

https://issues.redhat.com/browse/OCPBUGS-11634

ImageDigestMirrorSet and ImageTagMirrorSet are supported since OCP 4.13, we should remove the related description and add ICSP since OCP 4.8. I backported #57440 in error.

Previews:
About the Machine Config Operator IMPORTANT admonition
Disabling the Machine Config Operator from automatically rebooting NOTE admonition

QE review:

  • QE has approved this change.

@mburke5678 mburke5678 added this to the Continuous Release milestone May 22, 2023
@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2023
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented May 22, 2023

@sergiordlr @rioliu-rh You reviewed my PR that I erroneously backported. Can you confirm that IDMS and ITMS should not be in 4.10-4.12 and that ICSP should appear in this file? Thank you very much in advance.

@jianzhangbjz
Copy link
Copy Markdown

jianzhangbjz commented May 23, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
@rioliu-rh
Copy link
Copy Markdown

rioliu-rh commented May 23, 2023

LGTM

@mburke5678 mburke5678 force-pushed the mco-remove-idms-itms branch from 09cd72b to 3260535 Compare May 23, 2023 12:40
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 23, 2023

New changes are detected. LGTM label has been removed.

@mburke5678 mburke5678 added the peer-review-needed Signifies that the peer review team needs to review this PR label May 23, 2023
@sjhala-ccs sjhala-ccs added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 23, 2023
sjhala-ccs
sjhala-ccs reviewed May 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@sjhala-ccs sjhala-ccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjhala-ccs sjhala-ccs added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 23, 2023
@mburke5678 mburke5678 merged commit 9779965 into openshift:enterprise-4.12 May 23, 2023
@mburke5678 mburke5678 deleted the mco-remove-idms-itms branch May 23, 2023 18:58
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented May 23, 2023

/cherrypick enterprise-4.10

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented May 23, 2023

@mburke5678: new pull request created: #60467

Details

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 23, 2023
Merged
@mburke5678
Copy link
Copy Markdown
Contributor Author

mburke5678 commented May 23, 2023

/cherrypick enterprise-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 23, 2023
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented May 23, 2023

@mburke5678: new pull request created: #60469

Details

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjhala-ccs sjhala-ccs sjhala-ccs left review comments

Assignees

@jianzhangbjz jianzhangbjz

Labels

branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

5 participants

@mburke5678 @jianzhangbjz @rioliu-rh @openshift-cherrypick-robot @sjhala-ccs