Skip to content

OSDOCS-5751: Configuring machine pool disk volume.#62116

Merged
EricPonvelle merged 1 commit intoopenshift:mainfrom
eohartman:osdocs-5751
Aug 31, 2023
Merged

OSDOCS-5751: Configuring machine pool disk volume.#62116
EricPonvelle merged 1 commit intoopenshift:mainfrom
eohartman:osdocs-5751

Conversation

@eohartman
Copy link
Copy Markdown
Contributor

@eohartman eohartman commented Jul 6, 2023 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 6, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 6, 2023 •
edited by openshift-ci Bot
Loading

@eohartman: This pull request references OSDOCS-5751 which is a valid jira issue.

Details

In response to this:

Version(s):
4.13+

Issue:
OSDOCS-5751

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 6, 2023
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Jul 6, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://62116--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/23304

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 7, 2023 •
edited by openshift-ci Bot
Loading

@eohartman: This pull request references OSDOCS-5751 which is a valid jira issue.

Details

In response to this:

Version(s):
4.13+

Issue:
OSDOCS-5751

Link to docs preview:
Configuring machine pool disk volume

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eohartman eohartman force-pushed the osdocs-5751 branch 3 times, most recently from 0aa3399 to a1cd809 Compare July 17, 2023 18:05
@eohartman eohartman force-pushed the osdocs-5751 branch 2 times, most recently from 4c14313 to 7951519 Compare July 18, 2023 19:57
@openshift-ci openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 18, 2023
@eohartman eohartman force-pushed the osdocs-5751 branch 2 times, most recently from 94d5561 to 484fcd7 Compare July 19, 2023 16:08
@eohartman eohartman force-pushed the osdocs-5751 branch 3 times, most recently from 607e735 to 8387249 Compare August 11, 2023 00:25
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 11, 2023 •
edited by openshift-ci Bot
Loading

@eohartman: This pull request references OSDOCS-5751 which is a valid jira issue.

Details

In response to this:

Version(s):
4.13+

Issue:
OSDOCS-5751

Link to docs preview:
Configuring machine pool disk volume
[Creating a machine pool using the ROSA CLI] (https://62116--docspreview.netlify.app/openshift-rosa/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes#creating_machine_pools_cli_rosa-managing-worker-nodes) <-- See Procedure, #8

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 11, 2023 •
edited by openshift-ci Bot
Loading

@eohartman: This pull request references OSDOCS-5751 which is a valid jira issue.

Details

In response to this:

Version(s):
4.13+

Issue:
OSDOCS-5751

Link to docs preview:
Configuring machine pool disk volume
Creating a machine pool using the ROSA CLI <-- See Procedure, number 8

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 11, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 11, 2023 •
edited by openshift-ci Bot
Loading

@eohartman: This pull request references OSDOCS-5751 which is a valid jira issue.

Details

In response to this:

Version(s):
4.13+

Issue:
OSDOCS-5751

Link to docs preview:
Creating a machine pool using the Openshift Cluster Manager <-- See Procedure, number 9

Creating a machine pool using the ROSA CLI <-- See Procedure, number 8

Configuring machine pool disk volume

[Configuring machine pool disk volume using OpenShift Cluster Manager]
https://62116--docspreview.netlify.app/openshift-rosa/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes#configuring_machine_pool_disk_volume_ocmrosa-managing-worker-nodes)

Configuring machine pool disk volume using the ROSA CLI

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 11, 2023 •
edited by openshift-ci Bot
Loading

@eohartman: This pull request references OSDOCS-5751 which is a valid jira issue.

Details

In response to this:

Version(s):
4.13+

Issue:
OSDOCS-5751

Link to docs preview:
Creating a machine pool using the Openshift Cluster Manager <-- See Procedure, number 9

Creating a machine pool using the ROSA CLI <-- See Procedure, number 8

Configuring machine pool disk volume

Configuring machine pool disk volume using OpenShift Cluster Manager

Configuring machine pool disk volume using the ROSA CLI

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eohartman
Copy link
Copy Markdown
Contributor Author

eohartman commented Aug 11, 2023

@arendej @bchandra-ocp Can y'all please take a look at the documentation? Thank you!

@eohartman eohartman force-pushed the osdocs-5751 branch 4 times, most recently from 09ed317 to 6ca6d28 Compare August 11, 2023 20:31
@nalhadef
Copy link
Copy Markdown
Contributor

nalhadef commented Aug 30, 2023

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci Bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 30, 2023
@eohartman eohartman force-pushed the osdocs-5751 branch 2 times, most recently from 4442689 to 4734ef4 Compare August 31, 2023 03:18
@eohartman
Copy link
Copy Markdown
Contributor Author

eohartman commented Aug 31, 2023

@nalhadef Can you please peer review this the morning of 8/31? Hopefully Travis will be done building by then, and the netlify previews will be updated. Thank you!

xueli181114
xueli181114 reviewed Aug 31, 2023
View reviewed changes
Comment thread modules/rosa-nodes-machine-pools-local-zones.adoc Outdated
xueli181114
xueli181114 reviewed Aug 31, 2023
View reviewed changes
Comment thread modules/configuring-machine-pool-disk-volume-cli.adoc Outdated
xueli181114
xueli181114 reviewed Aug 31, 2023
View reviewed changes
Comment thread modules/configuring-machine-pool-disk-volume-cli.adoc Outdated
jmekkatt
jmekkatt reviewed Aug 31, 2023
View reviewed changes
Comment thread modules/configuring-machine-pool-disk-volume-ocm.adoc Outdated
xueli181114
xueli181114 reviewed Aug 31, 2023
View reviewed changes
Comment thread modules/rosa-nodes-machine-pools-local-zones.adoc Outdated
@eohartman eohartman force-pushed the osdocs-5751 branch 2 times, most recently from 0d4a4ff to 023825f Compare August 31, 2023 13:55
@eohartman
Copy link
Copy Markdown
Contributor Author

eohartman commented Aug 31, 2023

@xueli181114 Please take a final look at this PR. Thank you!

leseb
leseb reviewed Aug 31, 2023
View reviewed changes
Comment thread modules/configuring-machine-pool-disk-volume-cli.adoc Outdated
Comment thread modules/configuring-machine-pool-disk-volume-cli.adoc
@nalhadef
Copy link
Copy Markdown
Contributor

nalhadef commented Aug 31, 2023

/lgtm, @eohartman. Ignore the two comments I added last time but are now obsolete.

@EricPonvelle EricPonvelle merged commit c8e76b1 into openshift:main Aug 31, 2023
@EricPonvelle
Copy link
Copy Markdown
Contributor

EricPonvelle commented Aug 31, 2023

/cherrypick enterprise-4.13

@EricPonvelle
Copy link
Copy Markdown
Contributor

EricPonvelle commented Aug 31, 2023

/cherrypick enterprise-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 31, 2023
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Aug 31, 2023

@EricPonvelle: new pull request created: #64181

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Aug 31, 2023

@EricPonvelle: new pull request created: #64182

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 31, 2023
Merged
@eohartman eohartman deleted the osdocs-5751 branch November 1, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers

@leseb leseb leseb left review comments

@arendej arendej arendej left review comments

@xueli181114 xueli181114 xueli181114 left review comments

@nalhadef nalhadef nalhadef left review comments

@jmekkatt jmekkatt jmekkatt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.13 branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-in-progress Signifies that the peer review team is reviewing this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@eohartman @openshift-ci-robot @ocpdocs-previewbot @arendej @nalhadef @EricPonvelle @openshift-cherrypick-robot @leseb @xueli181114 @jmekkatt