Skip to content

Additional information on how to configure automatic image signature import #6381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mburke5678 merged 1 commit into from
Dec 20, 2017
Merged

Additional information on how to configure automatic image signature import #6381

mburke5678 merged 1 commit into from
Dec 20, 2017

Conversation

@mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Nov 15, 2017

@mburke5678
Copy link
Contributor Author

mburke5678 commented Nov 15, 2017

@mfojtik @zhouying7780 @thomasmckay
How does this look?
I brought down some information from the github file and moved the link to the end to de-emphasize it.
@mburke5678

@mburke5678 mburke5678 added this to the Future Release milestone Nov 15, 2017
@mburke5678
Copy link
Contributor Author

mburke5678 commented Nov 15, 2017

[rev_history]
|xref:../admin_guide/image_signatures.adoc#admin-guide-image-signatures[Image Signatures]
|Added new section on xref:../admin_guide/image_signatures.adoc#importing-signatures-from-sigstore[Importing Image Signatures Automatically].
%

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 17, 2017
@wanghaoran1988
Copy link
Member

wanghaoran1988 commented Nov 22, 2017

LGFM

@mburke5678
Copy link
Contributor Author

mburke5678 commented Nov 22, 2017

@mfojtik @thomasmckay PTAL

@mburke5678 mburke5678 force-pushed the followup-signature-auto-import branch from 883b08f to b37e658 Compare December 6, 2017 17:41
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2017
@mburke5678 mburke5678 changed the title Follow-up edit to Describe how to configure automatic image signature import Additional information on how to configure automatic image signature import Dec 6, 2017
@mburke5678
Copy link
Contributor Author

mburke5678 commented Dec 6, 2017

@mfojtik @thomasmckay PTAL

@thomasmckay
Copy link

thomasmckay commented Dec 6, 2017

ack, thanks!

@mburke5678 mburke5678 added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 6, 2017
@mburke5678
Copy link
Contributor Author

mburke5678 commented Dec 6, 2017

@openshift/team-documentation PTAL
This is a follow-up to #5485

The original PR was written by Michal Fojtik and linked to a GitHub page[1]. I re-org'ed the original, added info from the GitHub page.

[1] https://github.com/containers/image/blob/master/docs/registries.d.md

@mburke5678 mburke5678 force-pushed the followup-signature-auto-import branch from b37e658 to 1e906bb Compare December 6, 2017 21:34
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2017
@mburke5678 mburke5678 force-pushed the followup-signature-auto-import branch from 1e906bb to f4c4615 Compare December 6, 2017 21:35
@mburke5678
Copy link
Contributor Author

mburke5678 commented Dec 6, 2017

No rev history needed

ncbaratta
ncbaratta suggested changes Dec 18, 2017
View reviewed changes
Copy link

@ncbaratta ncbaratta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few fixes needed

admin_guide/image_signatures.adoc Outdated
Copy link

@ncbaratta ncbaratta Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contains the configuration

admin_guide/image_signatures.adoc Outdated
Copy link

@ncbaratta ncbaratta Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no comma

admin_guide/image_signatures.adoc Outdated
Copy link

@ncbaratta ncbaratta Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the content

admin_guide/image_signatures.adoc Outdated
Copy link

@ncbaratta ncbaratta Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no comma needed

admin_guide/image_signatures.adoc Outdated
Copy link

@ncbaratta ncbaratta Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the users of the containers

admin_guide/image_signatures.adoc Outdated
Copy link

@ncbaratta ncbaratta Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of a (not an) signature store

admin_guide/image_signatures.adoc Outdated
Copy link

@ncbaratta ncbaratta Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be

"see the containers/image library"

Copy link
Contributor Author

@mburke5678 mburke5678 Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I should remove the whole phrase and go with see
link:https://github.com/containers/image/blob/master/docs/registries.d.md[Registries Configuration Directory]. ??

@ncbaratta ncbaratta added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 18, 2017
@mburke5678
Copy link
Contributor Author

mburke5678 commented Dec 20, 2017

[rev_history]
|xref:../admin_guide/image_signatures.adoc#admin-guide-image-signatures[Image Signatures]
|Added information on xref:../install_config/build_defaults_overrides.adoc#importing-signatures-from-sigstore[configuring automatic image signature import].
%

@mburke5678 mburke5678 force-pushed the followup-signature-auto-import branch from 8ec85c4 to f32085c Compare December 20, 2017 20:09
@mburke5678 mburke5678 merged commit 34741cd into openshift:master Dec 20, 2017
mburke5678 added a commit to mburke5678/openshift-docs that referenced this pull request Dec 20, 2017
@mburke5678
[enterprise-3.9] follow-up edit
c2c7308 
(cherry picked from commit f32085c) xref:openshift#6381
@mburke5678 mburke5678 mentioned this pull request Dec 20, 2017
Merged
mburke5678 added a commit to mburke5678/openshift-docs that referenced this pull request Dec 20, 2017
@mburke5678
[enterprise-3.7] follow-up edit
59320d7 
(cherry picked from commit f32085c) xref:openshift#6381
@mburke5678 mburke5678 deleted the followup-signature-auto-import branch August 2, 2018 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ncbaratta ncbaratta ncbaratta requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-3.7 branch/enterprise-3.9 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 3.9 GA

Development

Successfully merging this pull request may close these issues.

6 participants

@mburke5678 @wanghaoran1988 @thomasmckay @ncbaratta @vikram-redhat @openshift-ci-robot