Skip to content

[OSDOCS-6086]: OLM-managed Operators can use AWS STS (CCO docs)#63954

Merged
jeana-redhat merged 1 commit intoopenshift:mainfrom
jeana-redhat:OSDOCS-6086-CCO-AWS-STS-OLM-support
Sep 26, 2023
Merged

[OSDOCS-6086]: OLM-managed Operators can use AWS STS (CCO docs)#63954
jeana-redhat merged 1 commit intoopenshift:mainfrom
jeana-redhat:OSDOCS-6086-CCO-AWS-STS-OLM-support

Conversation

@jeana-redhat
Copy link
Copy Markdown
Contributor

@jeana-redhat jeana-redhat commented Aug 25, 2023 •
edited
Loading

Version(s):
4.14+

Issue:
OSDOCS-6086

Link to docs preview:
OLM-managed Operator support for authentication with AWS STS

QE review:

  • QE has approved this change.

Additional information:

@jeana-redhat jeana-redhat added this to the Planned for 4.14 GA milestone Aug 25, 2023
@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 25, 2023
@jeana-redhat jeana-redhat force-pushed the OSDOCS-6086-CCO-AWS-STS-OLM-support branch 2 times, most recently from b4c9852 to 86f2b2d Compare August 31, 2023 13:00
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Aug 31, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://63954--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/25971

@jeana-redhat jeana-redhat force-pushed the OSDOCS-6086-CCO-AWS-STS-OLM-support branch from 86f2b2d to d942ee1 Compare September 11, 2023 19:57
@adellape adellape mentioned this pull request Sep 18, 2023
Merged
1 task
@jeana-redhat jeana-redhat force-pushed the OSDOCS-6086-CCO-AWS-STS-OLM-support branch from d942ee1 to 8061153 Compare September 20, 2023 17:00
@openshift-ci openshift-ci Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2023
@dlom
Copy link
Copy Markdown

dlom commented Sep 21, 2023

lgtm :shipit:

@jeana-redhat
Copy link
Copy Markdown
Contributor Author

jeana-redhat commented Sep 21, 2023

@jianping-shu PTAL 🙇

@jstuever
Copy link
Copy Markdown

jstuever commented Sep 21, 2023

/cc

@openshift-ci openshift-ci Bot requested a review from jstuever September 21, 2023 21:06
@jstuever
Copy link
Copy Markdown

jstuever commented Sep 22, 2023

lgtm

@jianping-shu
Copy link
Copy Markdown

jianping-shu commented Sep 26, 2023

LGTM

@fxierh
Copy link
Copy Markdown

fxierh commented Sep 26, 2023

LGTM.

@jeana-redhat
Copy link
Copy Markdown
Contributor Author

jeana-redhat commented Sep 26, 2023

Thanks everybody for the reviews! 🙇

@jeana-redhat jeana-redhat added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 26, 2023
@sabrinajess
Copy link
Copy Markdown
Contributor

sabrinajess commented Sep 26, 2023

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci Bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 26, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 26, 2023

@kowen-rh: Those labels are not set on the issue: peer-review-needed

Details

In response to this:

/remove-label peer-review-needed
/label peer-review-in-progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sabrinajess
sabrinajess reviewed Sep 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@sabrinajess sabrinajess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small note you can take or leave, otherwise LGTM! Tagging @ousleyp to confirm review.

Comment thread modules/cco-short-term-creds-aws-olm.adoc
@ousleyp ousleyp added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Sep 26, 2023
@jeana-redhat jeana-redhat force-pushed the OSDOCS-6086-CCO-AWS-STS-OLM-support branch from 8061153 to aa57697 Compare September 26, 2023 18:21
@jeana-redhat jeana-redhat merged commit 848b96b into openshift:main Sep 26, 2023
@jeana-redhat
Copy link
Copy Markdown
Contributor Author

jeana-redhat commented Sep 26, 2023

/cherrypick enterprise-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 26, 2023
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Sep 26, 2023

@jeana-redhat: new pull request created: #65262

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jstuever jstuever Awaiting requested review from jstuever

1 more reviewer

@sabrinajess sabrinajess sabrinajess left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.14 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.14 GA

Development

Successfully merging this pull request may close these issues.

9 participants

@jeana-redhat @ocpdocs-previewbot @dlom @jstuever @jianping-shu @fxierh @sabrinajess @openshift-cherrypick-robot @ousleyp