Updated CLI content with some restructuring [tech_review]#65
Merged
nhr merged 1 commit intoopenshift:masterfrom Jan 14, 2015
Bilhar-rh:os_cli
Merged
Updated CLI content with some restructuring [tech_review]#65nhr merged 1 commit intoopenshift:masterfrom Bilhar-rh:os_cli
nhr merged 1 commit intoopenshift:masterfrom
Bilhar-rh:os_cli
Conversation
Member
|
Member
|
@CowboysFan let me know if you want to update your PR based on that feedback or merge it as-is. |
Author
|
@nhr Thanks for the explanation. If no. 1 is temporary then I think we'll leave that as-is. As for no. 2 it sounds like I have it covered. If you can ack the tech_review, then please merge, or I'll be happy to merge after ack. |
nhr
added a commit
that referenced
this pull request
Jan 14, 2015
Updated CLI content with some restructuring [tech_review]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nhr @danmcp My first take on some rework of the CLI content that was migrated. A couple of questions though: