Skip to content

OSDOCS:8142: Removed platform.gcp.licenses parameter#66113

Merged
mjpytlak merged 1 commit intoopenshift:mainfrom
mjpytlak:osdocs-8142
Oct 12, 2023
Merged

OSDOCS:8142: Removed platform.gcp.licenses parameter#66113
mjpytlak merged 1 commit intoopenshift:mainfrom
mjpytlak:osdocs-8142

Conversation

@mjpytlak
Copy link
Copy Markdown
Contributor

@mjpytlak mjpytlak commented Oct 11, 2023

Version(s):
4.14+

Issue:
This issue addresses osdocs-8142.

Link to docs preview:

Additional Google Cloud Platform (GCP) configuration parameters (note the absence of platform.gcp.licenses from the table.)

QE review:

  • QE has approved this change.

Additional information:
This GCP parameter was deprecated in 4.10. Docs stated deprecation in #37422. Engineering has removed this parameter in 4.14.

The corresponding release note PR that indicates that the parameter is removed is #66116

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 11, 2023
@mjpytlak mjpytlak added branch/enterprise-4.14 and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 11, 2023
@mjpytlak mjpytlak added this to the Planned for 4.14 GA milestone Oct 11, 2023
@ocpdocs-previewbot
Copy link
Copy Markdown

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 11, 2023
@jianli-wei
Copy link
Copy Markdown

/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Oct 12, 2023
@mjpytlak mjpytlak added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 12, 2023
@kalexand-rh kalexand-rh added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 12, 2023
Copy link
Copy Markdown
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 12, 2023
@mjpytlak mjpytlak merged commit 3c0c934 into openshift:main Oct 12, 2023
@mjpytlak
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.14

@openshift-cherrypick-robot
Copy link
Copy Markdown

@mjpytlak: new pull request created: #66177

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.14 peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants