Skip to content

Add 4.14 relnotes for token auth via CCO / AWS STS#66133

Merged
adellape merged 1 commit intoopenshift:enterprise-4.14from
adellape:414_rn_sts
Oct 16, 2023
Merged

Add 4.14 relnotes for token auth via CCO / AWS STS#66133
adellape merged 1 commit intoopenshift:enterprise-4.14from
adellape:414_rn_sts

Conversation

@adellape
Copy link
Copy Markdown
Contributor

@adellape adellape commented Oct 11, 2023 •
edited
Loading

Release notes for #64808

OCP 4.14

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2023
@adellape adellape added branch/enterprise-4.14 and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 11, 2023
@adellape adellape added this to the Planned for 4.14 GA milestone Oct 11, 2023
@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 11, 2023
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Oct 11, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://66133--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/27856

@adellape adellape changed the title [WIP] Add 4.14 relnotes for token auth via CCO / AWS STS Add 4.14 relnotes for token auth via CCO / AWS STS Oct 11, 2023
@adellape
Copy link
Copy Markdown
Contributor Author

adellape commented Oct 11, 2023

cc @jeana-redhat for Auth section and @opayne1 for Console section.

opayne1
opayne1 reviewed Oct 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple suggestions on my end. Thank you for this and thank you for the extra minor tweaks! 😄

Comment thread release_notes/ocp-4-14-release-notes.adoc Outdated
Comment thread release_notes/ocp-4-14-release-notes.adoc Outdated
jeana-redhat
jeana-redhat reviewed Oct 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedantic suggestions about avoiding "mode" mostly 🤓 Also will lyk what I find out from my dev question about STS detection

Comment thread release_notes/ocp-4-14-release-notes.adoc Outdated
Comment thread release_notes/ocp-4-14-release-notes.adoc Outdated
Comment thread release_notes/ocp-4-14-release-notes.adoc Outdated
@adellape adellape force-pushed the 414_rn_sts branch 2 times, most recently from 6e90d8f to fbab5a7 Compare October 12, 2023 17:03
jeana-redhat
jeana-redhat reviewed Oct 12, 2023
View reviewed changes
Comment thread release_notes/ocp-4-14-release-notes.adoc Outdated
@adellape adellape force-pushed the 414_rn_sts branch 2 times, most recently from a56e50a to 628de07 Compare October 13, 2023 14:53
jeana-redhat
jeana-redhat reviewed Oct 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo, otherwise LGTM

/label peer-review-done

Comment thread release_notes/ocp-4-14-release-notes.adoc Outdated
@openshift-ci openshift-ci Bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Oct 13, 2023
@adellape
Copy link
Copy Markdown
Contributor Author

adellape commented Oct 13, 2023

@fxierh Looking for QE review on these release notes. Thank you!

fxierh
fxierh reviewed Oct 16, 2023
View reviewed changes
Copy link
Copy Markdown

@fxierh fxierh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you need me to provide any specific label ?

@adellape
Copy link
Copy Markdown
Contributor Author

adellape commented Oct 16, 2023

@fxierh No, a comment in GH or Jira is good enough. Thank you!

@adellape adellape merged commit 2d86788 into openshift:enterprise-4.14 Oct 16, 2023
@adellape adellape deleted the 414_rn_sts branch October 16, 2023 14:35
This was referenced Oct 24, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeana-redhat jeana-redhat jeana-redhat left review comments

@opayne1 opayne1 opayne1 left review comments

+1 more reviewer

@fxierh fxierh fxierh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.14 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.14 GA

Development

Successfully merging this pull request may close these issues.

5 participants

@adellape @ocpdocs-previewbot @jeana-redhat @opayne1 @fxierh