Skip to content

OSDOCS#8989: Installing OLM on MicroShift#70359

Merged
kelbrown20 merged 1 commit intoopenshift:mainfrom
kelbrown20:OSDOCS-8989
Feb 2, 2024
Merged

OSDOCS#8989: Installing OLM on MicroShift#70359
kelbrown20 merged 1 commit intoopenshift:mainfrom
kelbrown20:OSDOCS-8989

Conversation

@kelbrown20
Copy link
Copy Markdown
Contributor

@kelbrown20 kelbrown20 commented Jan 16, 2024 •
edited
Loading

@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 16, 2024
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Jan 16, 2024 •
edited
Loading

🤖 Thu Feb 01 20:12:43 - Prow CI generated the docs preview: https://70359--ocpdocs-pr.netlify.app

@kelbrown20 kelbrown20 force-pushed the OSDOCS-8989 branch 5 times, most recently from 7b54b85 to f1916ff Compare January 16, 2024 19:54
ShaunaDiaz
ShaunaDiaz reviewed Jan 17, 2024
View reviewed changes
Comment thread modules/microshift-adding-olm-to-blueprint.adoc Outdated
ShaunaDiaz
ShaunaDiaz reviewed Jan 17, 2024
View reviewed changes
Comment thread modules/microshift-adding-olm-to-blueprint.adoc Outdated
ShaunaDiaz
ShaunaDiaz reviewed Jan 17, 2024
View reviewed changes
Comment thread modules/microshift-install-rpms-olm.adoc Outdated
ShaunaDiaz
ShaunaDiaz reviewed Jan 17, 2024
View reviewed changes
Comment thread modules/microshift-install-rpms-olm.adoc Outdated
ShaunaDiaz
ShaunaDiaz reviewed Jan 17, 2024
View reviewed changes
Comment thread modules/microshift-install-rpms-olm.adoc Outdated
ShaunaDiaz
ShaunaDiaz reviewed Jan 17, 2024
View reviewed changes
Comment thread modules/microshift-adding-olm-to-blueprint.adoc Outdated
@kelbrown20
Copy link
Copy Markdown
Contributor Author

kelbrown20 commented Jan 18, 2024

@pmtk Hey Patryk! Was wondering if you could take a look at this PR when you get the chance? Thank you!

pmtk
pmtk reviewed Jan 18, 2024
View reviewed changes
Comment thread modules/microshift-adding-olm-to-blueprint.adoc Outdated
Comment thread modules/microshift-install-rpms-olm.adoc Outdated
@kelbrown20 kelbrown20 force-pushed the OSDOCS-8989 branch 2 times, most recently from 06df843 to c5b92d9 Compare January 23, 2024 15:45
@kelbrown20
Copy link
Copy Markdown
Contributor Author

kelbrown20 commented Jan 23, 2024

@pmtk I believe I updated everything properly, can you take a look when you get the chance? Thank you!

@kelbrown20 kelbrown20 changed the title [WIP]OSDOCS#8989: Installing OLM on MicroShift OSDOCS#8989: Installing OLM on MicroShift Jan 23, 2024
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2024
pmtk
pmtk reviewed Jan 23, 2024
View reviewed changes
Comment thread modules/microshift-install-rpms-olm.adoc Outdated
@pmtk
Copy link
Copy Markdown
Member

pmtk commented Jan 24, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2024
@nalhadef
Copy link
Copy Markdown
Contributor

nalhadef commented Jan 29, 2024

/label peer-review-in-progress
/remove-label peer-review-needed

@nalhadef
Copy link
Copy Markdown
Contributor

nalhadef commented Jan 29, 2024

/label peer-review-done

@openshift-ci openshift-ci Bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Jan 29, 2024
@nalhadef
Copy link
Copy Markdown
Contributor

nalhadef commented Jan 29, 2024

/remove-label peer-review-needed

@openshift-ci openshift-ci Bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 29, 2024
dhensel-rh
dhensel-rh reviewed Jan 30, 2024
View reviewed changes
Comment thread modules/microshift-install-rpms-olm.adoc
dhensel-rh
dhensel-rh reviewed Jan 30, 2024
View reviewed changes
Comment thread modules/microshift-install-rpms-olm.adoc
DanielFroehlich
DanielFroehlich reviewed Feb 1, 2024
View reviewed changes
Copy link
Copy Markdown

@DanielFroehlich DanielFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are missing a section in "Embedding in a RHEL for Edge image for offline use" on how to add the olm container image to the blueprint, to get it from the release_version file. @pmtk , where is this currently? in the olm rpm, or in the new olm-release-info? Or did we decide to defer this until we have the new rpm package?

Comment thread modules/microshift-install-rpms-olm.adoc Outdated
Comment thread microshift_install/microshift-install-rpm.adoc
@dhensel-rh
Copy link
Copy Markdown

dhensel-rh commented Feb 1, 2024

/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Feb 1, 2024
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2024
@kelbrown20
Copy link
Copy Markdown
Contributor Author

kelbrown20 commented Feb 1, 2024

I think we are missing a section in "Embedding in a RHEL for Edge image for offline use" on how to add the olm container image to the blueprint, to get it from the release_version file. @pmtk , where is this currently? in the olm rpm, or in the new olm-release-info? Or did we decide to defer this until we have the new rpm package?

@DanielFroehlich Thank you for the review Daniel! Regarding the section "Embedding in a RHEL for Edge image for offline use", that section is being added by Shauna in this story OSDOCS-8990, so it won't be updated in this PR.

@kelbrown20
Copy link
Copy Markdown
Contributor Author

kelbrown20 commented Feb 1, 2024

/retest

@kelbrown20 kelbrown20 force-pushed the OSDOCS-8989 branch 5 times, most recently from c268c17 to c41e730 Compare February 1, 2024 19:55
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 1, 2024

@kelbrown20: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

DanielFroehlich
DanielFroehlich approved these changes Feb 2, 2024
View reviewed changes
Copy link
Copy Markdown

@DanielFroehlich DanielFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2024
@kelbrown20 kelbrown20 merged commit d480691 into openshift:main Feb 2, 2024
@kelbrown20
Copy link
Copy Markdown
Contributor Author

kelbrown20 commented Feb 2, 2024

/cherrypick enterprise-4.15

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 2, 2024

@kelbrown20: new pull request created: #71140

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaunaDiaz ShaunaDiaz ShaunaDiaz left review comments

+3 more reviewers

@pmtk pmtk pmtk left review comments

@dhensel-rh dhensel-rh dhensel-rh left review comments

@DanielFroehlich DanielFroehlich DanielFroehlich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pmtk pmtk

@DanielFroehlich DanielFroehlich

@kuiwang02 kuiwang02

Labels

branch/enterprise-4.15 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@kelbrown20 @ocpdocs-previewbot @pmtk @kevinrizza @kuiwang02 @nalhadef @dhensel-rh @openshift-cherrypick-robot @DanielFroehlich @ShaunaDiaz