Skip to content

Updated OpenShift Ansible Broker documents#7057

Merged
adellape merged 2 commits intoopenshift:masterfrom
adellape:dymurray-doc
Jan 18, 2018
Merged

Updated OpenShift Ansible Broker documents#7057
adellape merged 2 commits intoopenshift:masterfrom
adellape:dymurray-doc

Conversation

@adellape adellape added branch/enterprise-3.7 peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 9, 2018
@adellape adellape added this to the Next Release milestone Jan 9, 2018
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 9, 2018
Copy link
Copy Markdown
Member

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex!

Comment thread apb_devel/writing/getting_started.adoc Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the The first and Next here? These are numbered steps.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this task required to use OAB? If not, should we mention this?
You can use OAB with any registry, as configured in....

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes a whitelist must be defined or the Broker will completely ignore APBs. End-users will simply not see any APBs and it is not apparent what is going wrong.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to say here a whitelist of images that OAB can access... (or similar)?

@mburke5678
Copy link
Copy Markdown
Contributor

@adellape Few questions.

@adellape
Copy link
Copy Markdown
Contributor Author

@mburke5678 Thank you, edits made.

@dymurray I've given the PV-related steps their own subheading so that it's more obvious what each procedure is for (as well as tweaked the "Configuring the OpenShift Ansible Broker" intro. WDYT?

http://file.rdu.redhat.com/~adellape/010918/dymurray-doc/install_config/install/advanced_install.html#configuring-openshift-ansible-broker

@adellape adellape merged commit add1fe8 into openshift:master Jan 18, 2018
@adellape
Copy link
Copy Markdown
Contributor Author

[rev_history]
|xref:../install_config/install/advanced_install.adoc#install-config-install-advanced-install[Installing a Cluster -> Advanced Installation]
|Added the xref:../install_config/install/advanced_install.adoc#configuring-oab-local-apb-devel[Configuring the OpenShift Ansible Broker for Local APB Development] section.
%
|xref:../apb_devel/writing/getting_started.adoc#apb-devel-writing-getting-started[Writing APBs -> Getting Started]
|Added a step to use openshift3/apb-base in the FROM directive.
%

@vikram-redhat vikram-redhat modified the milestones: Next Release, Staging Jan 25, 2018
@adellape
Copy link
Copy Markdown
Contributor Author

@vikram-redhat I noticed this was still in Staging but then I also noticed A) I forgot to squash this down to 1 commit (oops) and also B) I think I forgot to cherry-pick this to the stage branch. Is the latter what's holding it up? I'll do the needful once you confirm.

@vikram-redhat
Copy link
Copy Markdown
Contributor

@adellape - this shouldn't be in staging. I forgot to create a separate milestone last week to move staging PRs to the published milestones. Sorry! But yeah, if it didn't get cherry picked then it wouldn't have got published. So go ahead and CP to the right branches and it can get published next time. And change the milestone to next release. I will move the rest to the Published milestone today.

@adellape adellape modified the milestones: Staging, Next Release Jan 29, 2018
@adellape adellape removed the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 29, 2018
adellape pushed a commit to adellape/openshift-docs that referenced this pull request Jan 29, 2018
adellape pushed a commit to adellape/openshift-docs that referenced this pull request Jan 29, 2018
adellape added a commit to adellape/openshift-docs that referenced this pull request Jan 29, 2018
adellape added a commit to adellape/openshift-docs that referenced this pull request Jan 29, 2018
@adellape
Copy link
Copy Markdown
Contributor Author

@vikram-redhat Thanks! Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-3.7 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants