RHDEVDOCS-5562: Creating content for Using Argo Rollouts to route traffic by OpenShift Routes by Dhruv-Soni11 · Pull Request #72104 · openshift/openshift-docs

Dhruv-Soni11 · 2024-02-26T09:05:16Z

Version(s):

1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562

Link to docs preview:

https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @jgwest
QE review: @varshab1210
Internal peer review: @eromanova97 , @Srivaralakshmi
Peer review: @skopacz1

QE has approved this change.

Additional information:

openshift-ci-robot · 2024-02-26T09:05:21Z

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

Details

In response to this:

…ffic manager for Argo Rollouts

Version(s):

Issue:

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-02-26T09:05:57Z

Hi @Dhruv-Soni11. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ocpdocs-previewbot · 2024-02-26T09:12:53Z

🤖 Thu Jun 20 06:17:00 - Prow CI generated the docs preview:

https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery.html

openshift-ci-robot · 2024-02-26T11:03:31Z

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

Details

In response to this:

Version(s):

1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-26T11:28:36Z

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

Details

In response to this:

Version(s):

1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @ishitasequeira
QE review: @varshab1210
Peer review: @Srivaralakshmi

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Srivaralakshmi

@Dhruv-Soni11 Just skimmed through the PR and gave a few suggestions for you to consider. The PR needs a thorough self-review and good scrub.

After it is ready, please send it to @eromanova97 for internal peer review. @eromanova97, please assist Dhruv with a thorough internal peer review. Thanks!

openshift-ci-robot · 2024-02-26T13:15:34Z

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

Details

In response to this:

Version(s):

1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @ishitasequeira
QE review: @varshab1210
Internal peer review: @eromanova97 , @Srivaralakshmi

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-26T13:15:48Z

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

Details

In response to this:

Version(s):

1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @ishitasequeira
QE review: @varshab1210
Internal peer review: @eromanova97 , @Srivaralakshmi
Peer review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-26T13:16:01Z

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

Details

In response to this:

Version(s):

1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @ishitasequeira
QE review: @varshab1210
Internal peer review: @eromanova97 , @Srivaralakshmi
Peer review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

varshab1210 · 2024-06-18T12:47:01Z

Required changes:

#72104 (comment)
#72104 (comment)

LGTM otherwise!

Dhruv-Soni11 · 2024-06-18T13:54:28Z

Required changes:

#72104 (comment) #72104 (comment)

LGTM otherwise!

Hi @varshab1210, for the first comment I will add the link once the content in the other PR is merged. Also, I have added the feedback for the second comment.

Dhruv-Soni11 · 2024-06-18T13:54:45Z

/label peer-review-needed

skopacz1 · 2024-06-18T17:43:28Z

/ok-to-test

skopacz1

Left a few comments but otherwise looks good to me, nicely done!

openshift-ci-robot · 2024-06-19T06:30:54Z

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

Details

In response to this:

Version(s):

1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562

Link to docs preview:

https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @jgwest
QE review: @varshab1210
Internal peer review: @eromanova97 , @Srivaralakshmi
Peer review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Dhruv-Soni11 · 2024-06-19T07:24:11Z

/retest

Dhruv-Soni11 · 2024-06-19T07:40:32Z

/retest

Dhruv-Soni11 · 2024-06-19T07:50:57Z

/retest

Dhruv-Soni11 · 2024-06-19T09:01:13Z

/retest

Dhruv-Soni11 · 2024-06-19T10:37:32Z

Left a few comments but otherwise looks good to me, nicely done!

Hey @skopacz1 - Thanks for providing the comments. I have fixed all of them. PTAL.

…ffic manager for Argo Rollouts

openshift-ci · 2024-06-20T06:17:32Z

@Dhruv-Soni11: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Dhruv-Soni11 · 2024-06-20T13:20:56Z

/label merge-review-needed

bscott-rh · 2024-06-20T15:24:23Z

Merge review LGTM.

bscott-rh · 2024-06-20T15:25:03Z

/cherrypick gitops-docs-1.13

openshift-cherrypick-robot · 2024-06-20T15:27:33Z

@bscott-rh: new pull request created: #77761

Details

In response to this:

/cherrypick gitops-docs-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 26, 2024

openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2024

Dhruv-Soni11 force-pushed the RHDEVDOCS-5562 branch 3 times, most recently from 87ab53a to 23c7306 Compare February 26, 2024 10:49

Dhruv-Soni11 changed the title ~~RHDEVDOCS-5562: Creating content for Adding OpenShift Routes as a tra…~~ RHDEVDOCS-5562: Creating content for Adding OpenShift Routes as a traffic manager for Argo Rollouts Feb 26, 2024

Dhruv-Soni11 changed the title ~~RHDEVDOCS-5562: Creating content for Adding OpenShift Routes as a traffic manager for Argo Rollouts~~ WIP: RHDEVDOCS-5562: Creating content for Adding OpenShift Routes as a traffic manager for Argo Rollouts Feb 26, 2024

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2024

Srivaralakshmi reviewed Feb 26, 2024

View reviewed changes

Dhruv-Soni11 force-pushed the RHDEVDOCS-5562 branch 2 times, most recently from a8e2f2b to b76700b Compare February 27, 2024 08:34

Dhruv-Soni11 commented Feb 27, 2024

View reviewed changes

Comment thread modules/con_adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts.adoc Outdated

Dhruv-Soni11 force-pushed the RHDEVDOCS-5562 branch 2 times, most recently from 0657255 to a064a35 Compare February 27, 2024 11:53

Dhruv-Soni11 commented Mar 1, 2024

View reviewed changes

Comment thread modules/proc_installing-the-rollout-manager-plugin.adoc Outdated

Dhruv-Soni11 commented Mar 1, 2024

View reviewed changes

Comment thread modules/proc_installing-the-rollout-manager-plugin.adoc Outdated

Dhruv-Soni11 commented Mar 1, 2024

View reviewed changes

Comment thread modules/proc_installing-the-rollout-manager-plugin.adoc Outdated

Dhruv-Soni11 commented Mar 1, 2024

View reviewed changes

Comment thread modules/proc_installing-the-rollout-manager-operator.adoc Outdated

Dhruv-Soni11 force-pushed the RHDEVDOCS-5562 branch 3 times, most recently from 9d91b96 to ebade7a Compare March 1, 2024 15:41

Dhruv-Soni11 force-pushed the RHDEVDOCS-5562 branch 4 times, most recently from 50c7fb7 to eba0487 Compare June 18, 2024 12:24

Dhruv-Soni11 force-pushed the RHDEVDOCS-5562 branch from eba0487 to d121331 Compare June 18, 2024 13:01

openshift-ci Bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 18, 2024

skopacz1 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 18, 2024

openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 18, 2024

skopacz1 reviewed Jun 18, 2024

View reviewed changes

skopacz1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 18, 2024

RHDEVDOCS-5562: Creating content for Adding OpenShift Routes as a tra…

d0a05e6

…ffic manager for Argo Rollouts

openshift-cherrypick-robot mentioned this pull request Jun 20, 2024

[gitops-docs-1.13] RHDEVDOCS-5562: Creating content for Using Argo Rollouts to route traffic by OpenShift Routes #77761

Merged

Conversation

Dhruv-Soni11 commented Feb 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 26, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Feb 26, 2024

Uh oh!

ocpdocs-previewbot commented Feb 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 26, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 26, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Srivaralakshmi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 26, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 26, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 26, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

varshab1210 commented Jun 18, 2024

Uh oh!

Dhruv-Soni11 commented Jun 18, 2024

Uh oh!

Dhruv-Soni11 commented Jun 18, 2024

Uh oh!

skopacz1 commented Jun 18, 2024

Uh oh!

skopacz1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 19, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dhruv-Soni11 commented Jun 19, 2024

Uh oh!

Dhruv-Soni11 commented Jun 19, 2024

Uh oh!

Dhruv-Soni11 commented Jun 19, 2024

Uh oh!

Dhruv-Soni11 commented Jun 19, 2024

Uh oh!

Dhruv-Soni11 commented Jun 19, 2024

Uh oh!

openshift-ci Bot commented Jun 20, 2024

Uh oh!

Dhruv-Soni11 commented Feb 26, 2024 •

edited

Loading

openshift-ci-robot commented Feb 26, 2024 •

edited by openshift-ci Bot

Loading

ocpdocs-previewbot commented Feb 26, 2024 •

edited

Loading

openshift-ci-robot commented Feb 26, 2024 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Feb 26, 2024 •

edited by openshift-ci Bot

Loading

Srivaralakshmi left a comment •

edited

Loading

openshift-ci-robot commented Feb 26, 2024 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Feb 26, 2024 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Feb 26, 2024 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Jun 19, 2024 •

edited by openshift-ci Bot

Loading