Skip to content

osdocs9673: creating sigstore modules #76613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skopacz1 merged 1 commit into from
Jun 3, 2024
Merged

osdocs9673: creating sigstore modules #76613

skopacz1 merged 1 commit into from
Jun 3, 2024

Conversation

@DCChadwick
Copy link

@DCChadwick DCChadwick commented May 28, 2024 •
edited
Loading

Version(s): 4.16+

Issue: OSDOCS-9673

Link to docs preview: https://76613--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/nodes-sigstore-using.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 28, 2024
@DCChadwick DCChadwick force-pushed the ocdocs9673b branch 2 times, most recently from 250fa86 to bf34a80 Compare May 28, 2024 22:03
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 28, 2024 •
edited
Loading

🤖 Mon Jun 03 15:20:02 - Prow CI generated the docs preview:

https://76613--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/nodes-sigstore-using.html

@sunilcio
Copy link

sunilcio commented May 29, 2024

@lyman9966 could you help review? thanks

@lyman9966
Copy link

lyman9966 commented May 29, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024
@DCChadwick
Copy link
Author

DCChadwick commented May 29, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 29, 2024
@DCChadwick
Copy link
Author

DCChadwick commented May 29, 2024

/remove peer-review-needed

@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 29, 2024
@DCChadwick DCChadwick mentioned this pull request May 29, 2024
Merged
@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR labels May 29, 2024
saschagrunert
saschagrunert reviewed May 30, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 30, 2024
@DCChadwick
Copy link
Author

DCChadwick commented May 30, 2024

/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label May 30, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
saschagrunert
saschagrunert approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
@DCChadwick
Copy link
Author

DCChadwick commented May 31, 2024

/remove-label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 31, 2024
@opayne1 opayne1 added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.16 labels May 31, 2024
@opayne1 opayne1 added this to the Planned for 4.16 GA milestone May 31, 2024
@DCChadwick
Copy link
Author

DCChadwick commented May 31, 2024

@opayne1 - Sorry about that! Sascha Grunert reviewed the docs and I thought he was the peer reviewer. (I didn't realize he isn't an OCP writer.) My mistake. Thank you for catching that.

@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 31, 2024
mburke5678
mburke5678 reviewed May 31, 2024
View reviewed changes
mburke5678
mburke5678 reviewed May 31, 2024
View reviewed changes
mburke5678
mburke5678 reviewed May 31, 2024
View reviewed changes
@mburke5678
Copy link
Contributor

mburke5678 commented May 31, 2024

@DCChadwick A few comments. Otherwise LGTM

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 31, 2024
@saschagrunert
Copy link
Member

saschagrunert commented Jun 3, 2024

cc @QiWang19

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2024

@DCChadwick: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@DCChadwick
Copy link
Author

DCChadwick commented Jun 3, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 3, 2024
@skopacz1 skopacz1 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jun 3, 2024
skopacz1
skopacz1 reviewed Jun 3, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment to keep in mind for a potential future PR, but it's nothing pressing imo. Proceeding to merge

nodes/nodes-sigstore-using.adoc
Comment on lines +11 to +14
// The following include statements pull in the module files that comprise
// the assembly. Include any combination of concept, procedure, or reference
// modules required to cover the user story. You can also include other
// assemblies.
Copy link
Contributor

@skopacz1 skopacz1 Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to hold up merge review for this but just a heads up that I think you left some template content in this assembly

@skopacz1 skopacz1 merged commit de3c770 into openshift:main Jun 3, 2024
@skopacz1
Copy link
Contributor

skopacz1 commented Jun 3, 2024

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 3, 2024

@skopacz1: new pull request created: #76836

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 3, 2024
Merged
@skopacz1 skopacz1 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 3, 2024
@wking wking mentioned this pull request Sep 23, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mburke5678 mburke5678 mburke5678 left review comments

@skopacz1 skopacz1 skopacz1 left review comments

+1 more reviewer

@saschagrunert saschagrunert saschagrunert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@saschagrunert saschagrunert

@lyman9966 lyman9966

Labels

branch/enterprise-4.16 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.16 GA

Development

Successfully merging this pull request may close these issues.

9 participants

@DCChadwick @ocpdocs-previewbot @sunilcio @lyman9966 @opayne1 @mburke5678 @saschagrunert @skopacz1 @openshift-cherrypick-robot