Skip to content

OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates#80110

Merged
dfitzmau merged 1 commit intoopenshift:mainfrom
dfitzmau:OSDOCS-9350-deepdive-3
Sep 13, 2024
Merged

OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates#80110
dfitzmau merged 1 commit intoopenshift:mainfrom
dfitzmau:OSDOCS-9350-deepdive-3

Conversation

@dfitzmau
Copy link
Copy Markdown
Contributor

@dfitzmau dfitzmau commented Aug 7, 2024

@openshift-ci-robot
Copy link
Copy Markdown

@dfitzmau: No Jira issue with key deepdive-3 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 7, 2024
@dfitzmau dfitzmau force-pushed the OSDOCS-9350-deepdive-3 branch from ed158ab to 9e48fc9 Compare August 7, 2024 10:48
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Aug 7, 2024

@dfitzmau dfitzmau force-pushed the OSDOCS-9350-deepdive-3 branch 5 times, most recently from a78482b to 9ef6c2b Compare August 7, 2024 12:00
@openshift-ci openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2024
@dfitzmau dfitzmau force-pushed the OSDOCS-9350-deepdive-3 branch 4 times, most recently from a47e37a to cded28f Compare August 7, 2024 14:34
@openshift-ci-robot
Copy link
Copy Markdown

@dfitzmau: No Jira issue with key deepdive-3 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

Version(s):
4.12+

Issue:
(https://issues.redhat.com/browse/OSDOCS-9350)

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau force-pushed the OSDOCS-9350-deepdive-3 branch 14 times, most recently from 9915cc5 to 5de0305 Compare August 8, 2024 14:34
+
[source,terminal]
----
$ oc curl hello-openshift.nodeportsvc.ipi-cluster.example.com:<port>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. It is curl http://hello-openshift.nodeportsvc.ipi-cluster.example.com:<port> not oc curl ...
  2. should provide description of <port>
Port is the nodeport we get from the nodeport service, `80:32432/TCP` means we should use `32432` here.

See Line 83 and 88, 80:32432/TCP,443:31366/TCP means for http route we should use nodeport 32432, for https should use nodeport 31366

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@dfitzmau dfitzmau force-pushed the OSDOCS-9350-deepdive-3 branch 3 times, most recently from 3c92c84 to e789087 Compare September 5, 2024 10:50
@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 5, 2024
Copy link
Copy Markdown
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM!

Comment thread modules/nw-exposing-service.adoc Outdated
Comment thread modules/nw-exposing-service.adoc Outdated
Comment thread modules/nw-ingress-controller-nodeportservice-projects.adoc Outdated
Comment thread modules/nw-ingress-controller-nodeportservice-projects.adoc Outdated
Comment thread modules/nw-ingress-controller-nodeportservice-projects.adoc Outdated
Comment thread modules/nw-ingress-controller-nodeportservice-projects.adoc Outdated
Comment thread modules/nw-ingress-controller-nodeportservice-projects.adoc Outdated
Comment thread modules/nw-ingress-controller-nodeportservice-projects.adoc Outdated
Comment thread modules/nw-ingress-controller-nodeportservice-projects.adoc Outdated
Comment thread modules/nw-ingress-controller-nodeportservice-projects.adoc Outdated
Comment thread modules/nw-ingress-controller-nodeportservice-projects.adoc Outdated
@lihongan
Copy link
Copy Markdown

LGTM. thank you @dfitzmau

@openshift-ci-robot
Copy link
Copy Markdown

@dfitzmau: No Jira issue with key deepdive-3 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

Updates the doc to include Adding a NodePortService ingresscontroller from this SME document.

Version(s):
4.12+

Issue:
(https://issues.redhat.com/browse/OSDOCS-8653)

Link to docs preview:

Preview for link updates:

  • SME has approved this change.
  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 13, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.17

@dfitzmau
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.16

@dfitzmau
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.15

@dfitzmau
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.14

@dfitzmau
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.13

@dfitzmau
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.12

@openshift-cherrypick-robot
Copy link
Copy Markdown

@dfitzmau: new pull request created: #81802

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@dfitzmau: #80110 failed to apply on top of branch "enterprise-4.16":

Applying: OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
.git/rebase-apply/patch:206: trailing whitespace.
Instead of creating a `NodePort`-type `Service` for each project, you can create a custom Ingress Controller to use the `NodePortService` endpoint publishing strategy. To prevent port conflicts, consider this configuration for your Ingress Controller when you want to apply a set of routes, through Ingress sharding, to nodes that might already have a `HostNetwork` Ingress Controller.  
.git/rebase-apply/patch:212: trailing whitespace.
* You must append the port that is assigned to the `NodePort`-type `Service` in the route so that you can access application pods. 
.git/rebase-apply/patch:246: trailing whitespace.
      type: NodePortService 
.git/rebase-apply/patch:316: trailing whitespace.
You must specify the domain name of your custom Ingress Controller in the `--hostname` argument. If you do not do this, the Ingress Operator uses the default Ingress Controller to serve all the routes for your cluster. 
.git/rebase-apply/patch:436: trailing whitespace.
// Creating a project and service  
warning: 5 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
M	machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc
A	modules/hcp-virt-wildcard-dns.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): modules/hcp-virt-wildcard-dns.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of modules/hcp-virt-wildcard-dns.adoc left in tree.
Auto-merging machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc
Auto-merging _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@dfitzmau: #80110 failed to apply on top of branch "enterprise-4.15":

Applying: OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
.git/rebase-apply/patch:206: trailing whitespace.
Instead of creating a `NodePort`-type `Service` for each project, you can create a custom Ingress Controller to use the `NodePortService` endpoint publishing strategy. To prevent port conflicts, consider this configuration for your Ingress Controller when you want to apply a set of routes, through Ingress sharding, to nodes that might already have a `HostNetwork` Ingress Controller.  
.git/rebase-apply/patch:212: trailing whitespace.
* You must append the port that is assigned to the `NodePort`-type `Service` in the route so that you can access application pods. 
.git/rebase-apply/patch:246: trailing whitespace.
      type: NodePortService 
.git/rebase-apply/patch:316: trailing whitespace.
You must specify the domain name of your custom Ingress Controller in the `--hostname` argument. If you do not do this, the Ingress Operator uses the default Ingress Controller to serve all the routes for your cluster. 
.git/rebase-apply/patch:436: trailing whitespace.
// Creating a project and service  
warning: 5 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
M	machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc
A	modules/hcp-virt-wildcard-dns.adoc
M	networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.adoc
Falling back to patching base and 3-way merge...
Auto-merging networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.adoc
CONFLICT (modify/delete): modules/hcp-virt-wildcard-dns.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of modules/hcp-virt-wildcard-dns.adoc left in tree.
Auto-merging machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc
Auto-merging _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@dfitzmau: #80110 failed to apply on top of branch "enterprise-4.14":

Applying: OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
.git/rebase-apply/patch:206: trailing whitespace.
Instead of creating a `NodePort`-type `Service` for each project, you can create a custom Ingress Controller to use the `NodePortService` endpoint publishing strategy. To prevent port conflicts, consider this configuration for your Ingress Controller when you want to apply a set of routes, through Ingress sharding, to nodes that might already have a `HostNetwork` Ingress Controller.  
.git/rebase-apply/patch:212: trailing whitespace.
* You must append the port that is assigned to the `NodePort`-type `Service` in the route so that you can access application pods. 
.git/rebase-apply/patch:246: trailing whitespace.
      type: NodePortService 
.git/rebase-apply/patch:316: trailing whitespace.
You must specify the domain name of your custom Ingress Controller in the `--hostname` argument. If you do not do this, the Ingress Operator uses the default Ingress Controller to serve all the routes for your cluster. 
.git/rebase-apply/patch:436: trailing whitespace.
// Creating a project and service  
warning: 5 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
A	machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.adoc
A	machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc
A	modules/hcp-virt-wildcard-dns.adoc
M	networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.adoc
M	post_installation_configuration/configuring-private-cluster.adoc
Falling back to patching base and 3-way merge...
Auto-merging post_installation_configuration/configuring-private-cluster.adoc
Auto-merging networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.adoc
CONFLICT (modify/delete): modules/hcp-virt-wildcard-dns.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of modules/hcp-virt-wildcard-dns.adoc left in tree.
CONFLICT (modify/delete): machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc left in tree.
CONFLICT (modify/delete): machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.adoc left in tree.
Auto-merging _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@dfitzmau: #80110 failed to apply on top of branch "enterprise-4.13":

Applying: OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
.git/rebase-apply/patch:206: trailing whitespace.
Instead of creating a `NodePort`-type `Service` for each project, you can create a custom Ingress Controller to use the `NodePortService` endpoint publishing strategy. To prevent port conflicts, consider this configuration for your Ingress Controller when you want to apply a set of routes, through Ingress sharding, to nodes that might already have a `HostNetwork` Ingress Controller.  
.git/rebase-apply/patch:212: trailing whitespace.
* You must append the port that is assigned to the `NodePort`-type `Service` in the route so that you can access application pods. 
.git/rebase-apply/patch:246: trailing whitespace.
      type: NodePortService 
.git/rebase-apply/patch:316: trailing whitespace.
You must specify the domain name of your custom Ingress Controller in the `--hostname` argument. If you do not do this, the Ingress Operator uses the default Ingress Controller to serve all the routes for your cluster. 
.git/rebase-apply/patch:436: trailing whitespace.
// Creating a project and service  
warning: 5 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
A	machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.adoc
A	machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc
A	modules/hcp-virt-wildcard-dns.adoc
M	networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.adoc
M	post_installation_configuration/configuring-private-cluster.adoc
Falling back to patching base and 3-way merge...
Auto-merging post_installation_configuration/configuring-private-cluster.adoc
CONFLICT (content): Merge conflict in post_installation_configuration/configuring-private-cluster.adoc
Auto-merging networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.adoc
CONFLICT (modify/delete): modules/hcp-virt-wildcard-dns.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of modules/hcp-virt-wildcard-dns.adoc left in tree.
CONFLICT (modify/delete): machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc left in tree.
CONFLICT (modify/delete): machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.adoc left in tree.
Auto-merging _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@dfitzmau: #80110 failed to apply on top of branch "enterprise-4.12":

Applying: OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
.git/rebase-apply/patch:206: trailing whitespace.
Instead of creating a `NodePort`-type `Service` for each project, you can create a custom Ingress Controller to use the `NodePortService` endpoint publishing strategy. To prevent port conflicts, consider this configuration for your Ingress Controller when you want to apply a set of routes, through Ingress sharding, to nodes that might already have a `HostNetwork` Ingress Controller.  
.git/rebase-apply/patch:212: trailing whitespace.
* You must append the port that is assigned to the `NodePort`-type `Service` in the route so that you can access application pods. 
.git/rebase-apply/patch:246: trailing whitespace.
      type: NodePortService 
.git/rebase-apply/patch:316: trailing whitespace.
You must specify the domain name of your custom Ingress Controller in the `--hostname` argument. If you do not do this, the Ingress Operator uses the default Ingress Controller to serve all the routes for your cluster. 
.git/rebase-apply/patch:436: trailing whitespace.
// Creating a project and service  
warning: 5 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
A	machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.adoc
A	machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc
A	modules/hcp-virt-wildcard-dns.adoc
M	networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.adoc
M	post_installation_configuration/configuring-private-cluster.adoc
Falling back to patching base and 3-way merge...
Auto-merging post_installation_configuration/configuring-private-cluster.adoc
CONFLICT (content): Merge conflict in post_installation_configuration/configuring-private-cluster.adoc
Auto-merging networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-ingress-controller.adoc
CONFLICT (modify/delete): modules/hcp-virt-wildcard-dns.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of modules/hcp-virt-wildcard-dns.adoc left in tree.
CONFLICT (modify/delete): machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-azure.adoc left in tree.
CONFLICT (modify/delete): machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.adoc deleted in HEAD and modified in OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates. Version OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates of machine_management/control_plane_machine_management/cpmso_provider_configurations/cpmso-config-options-aws.adoc left in tree.
Auto-merging _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-9350-deepdive-3: endpointPublishingStrategy updates
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants