Skip to content

OSDOCS-5243 Adding CLI Manager docs #81448

Merged
stevsmit merged 1 commit intoopenshift:mainfrom
cbippley:OSDOCS-5243
Nov 19, 2024
Merged

OSDOCS-5243 Adding CLI Manager docs #81448
stevsmit merged 1 commit intoopenshift:mainfrom
cbippley:OSDOCS-5243

Conversation

@cbippley
Copy link
Copy Markdown
Contributor

@cbippley cbippley commented Sep 6, 2024

Version(s): 4.17+

Issue: OSDOCS-5243

Link to docs preview: https://81448--ocpdocs-pr.netlify.app/openshift-enterprise/latest/cli_reference/cli_manager/

QE review:

  • QE has approved this change.

Additional information: TP debut on November 19th.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 6, 2024
@cbippley
Copy link
Copy Markdown
Contributor Author

cbippley commented Sep 6, 2024

/retest

@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Sep 6, 2024

🤖 Tue Nov 19 20:14:57 - Prow CI generated the docs preview:
https://81448--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

Comment thread getting_started/cli_manager/cli-manager-install.adoc Outdated
Comment thread getting_started/cli_manager/cli-manager-release-notes.adoc Outdated
Comment thread getting_started/cli_manager/cli-manager-uninstall.adoc Outdated
Comment thread getting_started/cli_manager/cli-manager-using.adoc Outdated
@cbippley cbippley force-pushed the OSDOCS-5243 branch 2 times, most recently from 79b89f6 to a539b7f Compare September 6, 2024 18:52
@cbippley cbippley force-pushed the OSDOCS-5243 branch 2 times, most recently from 65207e8 to b371519 Compare September 20, 2024 18:50
Comment thread cli_reference/cli_manager/cli-manager-install.adoc Outdated
Comment thread cli_reference/cli_manager/cli-manager-release-notes.adoc Outdated
Comment thread cli_reference/cli_manager/cli-manager-uninstall.adoc
Comment thread cli_reference/cli_manager/cli-manager-using.adoc Outdated
@openshift-ci openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2024
Comment thread modules/cli-manager-installing.adoc Outdated
Comment thread modules/cli-manager-uninstalling.adoc Outdated
@cbippley cbippley force-pushed the OSDOCS-5243 branch 2 times, most recently from 5dd410c to 1f3b7f6 Compare October 7, 2024 18:35
Comment thread modules/cli-manager-plugin-list.adoc Outdated
@cbippley cbippley force-pushed the OSDOCS-5243 branch 4 times, most recently from 30aa131 to 4fee63d Compare October 15, 2024 13:53
@kasturinarra
Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024
@cbippley
Copy link
Copy Markdown
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci Bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 15, 2024
Comment thread modules/cli-manager-adding-plugin-yaml.adoc
@lahinson lahinson added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 15, 2024
Copy link
Copy Markdown
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! I had just a few comments for your consideration.

Comment thread cli_reference/cli_manager/index.adoc
Comment thread modules/cli-manager-about.adoc Outdated
Comment thread cli_reference/cli_manager/cli-manager-release-notes.adoc Outdated
Comment thread cli_reference/cli_manager/cli-manager-release-notes.adoc Outdated
Comment thread cli_reference/cli_manager/cli-manager-install.adoc Outdated
Comment thread modules/cli-manager-adding-plugin-yaml.adoc Outdated
Comment thread cli_reference/cli_manager/cli-manager-uninstall.adoc Outdated
Comment thread cli_reference/cli_manager/cli-manager-using.adoc Outdated
Comment thread modules/cli-manager-remove-resources.adoc Outdated
Comment thread modules/cli-manager-uninstalling.adoc Outdated
@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 15, 2024
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Nov 18, 2024

New changes are detected. LGTM label has been removed.

@cbippley
Copy link
Copy Markdown
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci Bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 19, 2024
@cbippley cbippley changed the title OSDOCS-5243 Adding CLI Manager docs OSDOCS-5243 Adding CLI Manager docs (release today) Nov 19, 2024
@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 19, 2024
Comment thread modules/cli-manager-custom-index-krew.adoc
Comment thread modules/cli-manager-installing.adoc Outdated
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Nov 19, 2024

@cbippley: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stevsmit
Copy link
Copy Markdown
Member

/cherry-pick enterprise-4.17

@stevsmit
Copy link
Copy Markdown
Member

/cherry-pick enterprise-4.18

@openshift-cherrypick-robot
Copy link
Copy Markdown

@stevsmit: new pull request created: #85170

Details

In response to this:

/cherry-pick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@stevsmit: new pull request created: #85171

Details

In response to this:

/cherry-pick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.17 branch/enterprise-4.18 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.