OSDOCS13124 Add version information to the output oc get machineconfignodes/Add MCP column to MCN output#86943
Conversation
openshift-ci
Bot
added
the
size/M
|
🤖 Tue Jan 28 18:30:57 - Prow CI generated the docs preview: https://86943--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_configuration/index.html |
openshift-ci
Bot
added
size/L
mburke5678
changed the title
mburke5678
changed the title
|
@isabella-janssen @djoshy Can you PTAL? |
|
|
||
| [source,terminal] | ||
| ---- | ||
| $ oc get machineconfignodes |
There was a problem hiding this comment.
I believe this should be oc get machineconfig
| spec: | ||
| featureSet: TechPreviewNoUpgrade <1> | ||
| ---- | ||
| <1> Enables the required `SigstoreImageVerification` feature. |
There was a problem hiding this comment.
Question: Should this reference the MachineConfigNodes feature?
There was a problem hiding this comment.
@isabella-janssen That is the name of the feature gate that is enabled in order to enable the MachineConfigNodes feature. I can change it. Or, better, remove the whole line.
There was a problem hiding this comment.
I don't think that's accurate, this feature should be tied to the MachineConfigNodes feature gate.
Stepping back a bit, a feature set selects a group of feature gates. So when you enable TechPreviewNoUpgrade, all the feature gates defined under it get enabled. At the time of writing, the tech preview featureset includes both SigStoreImageVerification and MachineConfigNodes features, among other tech preview features.
Could you point to where you found this link b/w SigStore and MCN? Might be something we need to fix if it is incorrectly listed somewhere.
There was a problem hiding this comment.
Sorry. I think this was a bad copy-and-paste. I am working on a TP feature related to sigstore. I removed the reference, as we don't use it often in the docs.
| * *Update Executed*. The MCO cordons and drains the node, and applies the new machine config to the node files and operating system, as needed. It contains the following sub-phases: | ||
| ** *Cordoned* | ||
| ** *Drained* | ||
| ** *UpdateExecutedAppliedFilesAndOS* |
There was a problem hiding this comment.
For consistency with the rest of the list, should this be AppliedFilesAndOS?
There was a problem hiding this comment.
err, this might be my lack of understanding - but where is the mapping for phases/subphases from? I'm having a hard time following 😓
There was a problem hiding this comment.
@djoshy Most of it came from MCO-821: Introduce MachineConfigNode types. I'm not sure the subphases are really needed.
|
Just a few questions/suggestions but otherwise looks good to me. Thanks 🙂 |
|
@sergiordlr PTAL |
| The node update process consists of the following phases and subphases that are tracked by the machine config node custom resource: | ||
|
|
||
| * *Update Prepared*. The MCO stops the configuration drift monitoring and verifies that the newly-created machine config can be applied to a node. | ||
| ** *UpdateCompatible* |
There was a problem hiding this comment.
Can we get a description about "UpdateCompatible" field? I'm not sure about its meaning.
There was a problem hiding this comment.
Explained later in the section. I added text to the introductory sentence stating this.
|
|
||
| As the update moves through these phases, you can query the `MachineConfigNode` custom resource, which reports one of the following conditions for each phase: | ||
|
|
||
| * `True`. The phase is complete on that node or the MCO has started that phase on that node. |
There was a problem hiding this comment.
We could include a note explaining that once the nodes is fully updated all values are reset.
mburke5678
added
the
peer-review-needed
mburke5678
force-pushed
the
mco-machineconfignode-output
branch
from
e453ba5 to
dc1cbbe
Compare
|
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label peer-review-in-progress |
openshift-ci
Bot
added
peer-review-in-progress
|
/label peer-review-done |
openshift-ci
Bot
added
peer-review-done
|
/cherrypick enterprise-4.18 |
|
@mburke5678: new pull request created: #87757 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8 participants
https://issues.redhat.com/browse/OSDOCS-13124
Previews:
Machine configuration -> Machine configuration overview -> About checking machine config node status -- Updated module.
Machine configuration -> Machine configuration overview -> Checking machine config node status -- New module
QE review: