Skip to content

OSDOCS-11795: Shared VPC doc updates.#87731

Merged
bmcelvee merged 1 commit intoopenshift:mainfrom
eohartman:osdocs-11795
Feb 6, 2025
Merged

OSDOCS-11795: Shared VPC doc updates.#87731
bmcelvee merged 1 commit intoopenshift:mainfrom
eohartman:osdocs-11795

Conversation

@eohartman
Copy link
Copy Markdown
Contributor

@eohartman eohartman commented Jan 28, 2025

Version(s):
enterprise-4.17+

Issue:
OSDOCS-11795

Link to docs preview:
Step Two - Cluster Creator: Reserving your DNS and creating cluster operator roles - See Step 4

Step Three - VPC Owner: Updating the shared VPC role and creating hosted zones - See Step 3

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 28, 2025

@eohartman: This pull request references OSDOCS-11795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):

Issue:
OSDOCS-11795

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2025
@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 28, 2025

@eohartman: This pull request references OSDOCS-11795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
enterprise-4.17+

Issue:
OSDOCS-11795

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 28, 2025

@eohartman: This pull request references OSDOCS-11795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
enterprise-4.19+

Issue:
OSDOCS-11795

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link
Copy Markdown

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 28, 2025

@eohartman: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 28, 2025

@eohartman: This pull request references OSDOCS-11795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
enterprise-4.19+

Issue:
OSDOCS-11795

Link to docs preview:
Step Two - Cluster Creator: Reserving your DNS and creating cluster operator roles - See Step #4

Step Three - VPC Owner: Updating the shared VPC role and creating hosted zones - See Step #3

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eohartman
Copy link
Copy Markdown
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci Bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 28, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 28, 2025

@eohartman: This pull request references OSDOCS-11795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
enterprise-4.18+

Issue:
OSDOCS-11795

Link to docs preview:
Step Two - Cluster Creator: Reserving your DNS and creating cluster operator roles - See Step #4

Step Three - VPC Owner: Updating the shared VPC role and creating hosted zones - See Step #3

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 28, 2025

@eohartman: This pull request references OSDOCS-11795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
enterprise-4.18+

Issue:
OSDOCS-11795

Link to docs preview:
Step Two - Cluster Creator: Reserving your DNS and creating cluster operator roles - See Step 4

Step Three - VPC Owner: Updating the shared VPC role and creating hosted zones - See Step 3

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stevsmit stevsmit added branch/enterprise-4.18 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 28, 2025
@stevsmit stevsmit added this to the Continuous Release milestone Jan 28, 2025
@stevsmit stevsmit added the peer-review-done Signifies that the peer review team has reviewed this PR label Jan 28, 2025
@stevsmit
Copy link
Copy Markdown
Member

LGTM

@eohartman
Copy link
Copy Markdown
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci Bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 30, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 30, 2025

@eohartman: This pull request references OSDOCS-11795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
enterprise-4.18+

Issue:
OSDOCS-11795

Link to docs preview:
Step Two - Cluster Creator: Reserving your DNS and creating cluster operator roles - See Step 4

Step Three - VPC Owner: Updating the shared VPC role and creating hosted zones - See Step 3

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony agantony removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 30, 2025
@agantony
Copy link
Copy Markdown
Contributor

Merge review in progress

@agantony
Copy link
Copy Markdown
Contributor

@eohartman I do not see a QE approval?

@agantony agantony added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jan 30, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 30, 2025

@eohartman: This pull request references OSDOCS-11795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
enterprise-4.18+

Issue:
OSDOCS-11795

Link to docs preview:
Step Two - Cluster Creator: Reserving your DNS and creating cluster operator roles - See Step 4

Step Three - VPC Owner: Updating the shared VPC role and creating hosted zones - See Step 3

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eohartman
Copy link
Copy Markdown
Contributor Author

I will double-check with QE to see if this needs an approval. Thank you!

Copy link
Copy Markdown
Contributor

@agantony agantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments to improve sentence structure; overall lgtm!

Comment thread modules/rosa-sharing-vpc-dns-and-roles.adoc
Comment thread modules/rosa-sharing-vpc-hosted-zones.adoc
@eohartman
Copy link
Copy Markdown
Contributor Author

@xueli181114 Can you please assign it to someone if a QE review is needed?

Copy link
Copy Markdown
Contributor Author

@eohartman eohartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These suggestions are outside of the scope of the Jira ticket, though I will make a new ticket to revise the formatting.

Comment thread modules/rosa-sharing-vpc-dns-and-roles.adoc
Comment thread modules/rosa-sharing-vpc-hosted-zones.adoc
@eohartman
Copy link
Copy Markdown
Contributor Author

@pvasant

@OAharoni-RedHat
Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2025
@eohartman
Copy link
Copy Markdown
Contributor Author

Thank you!

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 6, 2025

@eohartman: The label(s) /remove-label do-not-merge cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/remove-label do-not-merge
/label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 6, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 6, 2025

@eohartman: This pull request references OSDOCS-11795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Version(s):
enterprise-4.18+

Issue:
OSDOCS-11795

Link to docs preview:
Step Two - Cluster Creator: Reserving your DNS and creating cluster operator roles - See Step 4

Step Three - VPC Owner: Updating the shared VPC role and creating hosted zones - See Step 3

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bmcelvee bmcelvee added merge-review-in-progress Signifies that the merge review team is reviewing this PR SD-docs Label for all Service Delivery PRs branch/enterprise-4.17 and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. merge-review-needed Signifies that the merge review team needs to review this PR merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Feb 6, 2025
@bmcelvee bmcelvee merged commit 330a51f into openshift:main Feb 6, 2025
@bmcelvee
Copy link
Copy Markdown
Contributor

bmcelvee commented Feb 6, 2025

/cherrypick enterprise-4.17

@bmcelvee
Copy link
Copy Markdown
Contributor

bmcelvee commented Feb 6, 2025

/cherrypick enterprise-4.18

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bmcelvee: new pull request created: #88195

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bmcelvee: new pull request created: #88196

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.17 branch/enterprise-4.18 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR SD-docs Label for all Service Delivery PRs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants