Skip to content

Add OpenStack-related documentation, incl. Cinder plugins#930

Merged
adellape merged 2 commits intoopenshift:masterfrom
jsafrane:devel/cinder
Oct 9, 2015
Merged

Add OpenStack-related documentation, incl. Cinder plugins#930
adellape merged 2 commits intoopenshift:masterfrom
jsafrane:devel/cinder

Conversation

@jsafrane
Copy link
Contributor

The storage part is inspired by PR #924.

Cinder support is on it's way to Kubernetes, see kubernetes/kubernetes#13367.
Do not merge until the code is in OpenShift! Code has been merged to openshift/origin in commit 2009660eb84e1a56df68db8e1077e2b0bd136d3f.

@adellape adellape changed the title Add OpenStack-related documentation, incl. Cinder plugins [do not merge] Add OpenStack-related documentation, incl. Cinder plugins Sep 1, 2015
@adellape
Copy link
Contributor

adellape commented Sep 2, 2015

@jsafrane Is there an origin PR to follow yet? I didn't find one in my search, but just checking. Thanks for this!

@jsafrane
Copy link
Contributor Author

jsafrane commented Sep 2, 2015

There is a Kubernetes PR kubernetes/kubernetes#13367 (just merged yesterday), I think it will end up in OpenShift in the usual merge. I guess you know better than me when/how do you pull stuff from Kubernetes master.

@jsafrane jsafrane changed the title [do not merge] Add OpenStack-related documentation, incl. Cinder plugins Add OpenStack-related documentation, incl. Cinder plugins Oct 1, 2015
@jsafrane
Copy link
Contributor Author

jsafrane commented Oct 1, 2015

Rebased, added Fibre Channel guide by @rootfs.

@jsafrane
Copy link
Contributor Author

jsafrane commented Oct 1, 2015

And looking at Kubernetes in current origin/master, I can see it already has Cinder volume plugin.

@adellape adellape added this to the OSE 3.1 milestone Oct 2, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/create/create a/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@adellape
Copy link
Contributor

adellape commented Oct 6, 2015

@jsafrane Some comments inline. Thanks!

@adellape
Copy link
Contributor

adellape commented Oct 6, 2015

Rebased, added Fibre Channel guide by @rootfs.

@jsafrane Oh, also, what did the above comment refer to?

@jsafrane
Copy link
Contributor Author

jsafrane commented Oct 7, 2015

I fixed most of the review remarks.

Rebased, added Fibre Channel guide by @rootfs.

@jsafrane Oh, also, what did the above comment refer to?

Sorry, that belongs to different PR. Too many open pull requests...

@jsafrane
Copy link
Contributor Author

jsafrane commented Oct 7, 2015

And thanks for the review!

@adellape
Copy link
Contributor

adellape commented Oct 8, 2015

@jsafrane Thanks, LGTM. Looks like it needs a rebase now, but it's probably just cuz of #924 which I merged yesterday (introduces the persistent_storage subdir and Gluster topic). So it's likely just a matter of fixing the _build_cfg.yaml to make sure it includes all three (NFS, Gluster, Cinder).

@jsafrane
Copy link
Contributor Author

jsafrane commented Oct 9, 2015

Rebased and squashed.

@adellape
Copy link
Contributor

adellape commented Oct 9, 2015

🎉

adellape added a commit that referenced this pull request Oct 9, 2015
Add OpenStack-related documentation, incl. Cinder plugins
@adellape adellape merged commit 2f96dac into openshift:master Oct 9, 2015
@jsafrane
Copy link
Contributor Author

jsafrane commented Oct 9, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants