Make service dependency ordering more strict #44
Conversation
sdodson
force-pushed
the
service-dependencies
branch
from
5b7320b to
b633626
Compare
This also removes the Requires on openshift-master. This is replaced by a RequiredBy=openshift-sdn-master.service in openshift-master.service
sdodson
force-pushed
the
service-dependencies
branch
from
b633626 to
5023840
Compare
|
Based on the number of folks having trouble with docker failing to start without lbr0 I've amended this to include ensuring openshift-sdn-node is started before docker. |
|
@mrunalp @rajatchopra Do you mind reviewing this? We have a good number of people running into problems with beta2 and I'd like to get this in before beta3. |
There was a problem hiding this comment.
Why does the node-service want a master service?
There was a problem hiding this comment.
It's not necessary as it would be chained openshift-sdn-node wants openshift-sdn-master wants openshift-master. I was just trying to make each service describe it's entire chain. I'm happy to stick to immediate dependencies if you'd prefer.
There was a problem hiding this comment.
It confuses me at least, so just the immediate dependencies that solve the ordering problem would be nice.
@mrunalp your opinion?
There was a problem hiding this comment.
Actually on second thoughts, its harmless.
|
LGTM |
1 similar comment
|
LGTM |
Make service dependency ordering more strict
3 participants
This formalizes service startup ordering.
Before/After only affect ordering.
Wants/Requires affects dependencies, wants being a weaker form of Requires that will trigger the dependency to start but will carry on if the dependency fails.
My only concern is that I wonder if we should add Before=docker.service because if we don't and we've run openshift-sdn previously it will have configured docker to use lbr0 which will not exist after a reboot before openshift-sdn has created it.