OCPBUGS-7310: Do not consider deleted instance as error#84
Conversation
The `OpenStack platform on instance creation should report all openstack instance addresses on the corresponding Machine object` test list all machines in the openshift cluster then fetches information from OpenStack for each one of them. Because the test doesn't run in isolation, it's affected by other tests that run at the same time and it makes it flaky. We had a check that looked for errors getting info for a machine that did not take into account deleted machines. Move this check at the right place.
openshift-ci-robot
added
jira/valid-reference
|
@mandre: This pull request references Jira Issue OCPBUGS-7310, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @mdbooth |
|
/cherry-pick release-4.12 |
|
@mandre: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
If we get false negatives, we might consider serialising the test instead. However, I agree that there is a cost to it. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@mandre: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@mandre: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-7310 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mandre: new pull request created: #86 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OCPBUGS-7310: Do not consider deleted instance as error
OCPBUGS-7310: Do not consider deleted instance as error
6 participants
The
OpenStack platform on instance creation should report all openstack instance addresses on the corresponding Machine objecttest list all machines in the openshift cluster then fetches information from OpenStack for each one of them. Because the test doesn't run in isolation, it's affected by other tests that run at the same time and it makes it flaky.We had a check that looked for errors getting info for a machine that did not take into account deleted machines. Move this check at the right place.