Skip to content

[release-4.12] OCPBUGS-7320: Do not consider deleted instance as error #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Feb 16, 2023
Merged

[release-4.12] OCPBUGS-7320: Do not consider deleted instance as error #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/extended/openstack/servers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,10 @@ var _ = g.Describe("[sig-installer][Suite:openshift/openstack] The OpenStack pla

g.By(fmt.Sprintf("Gather Openstack attributes for machine %q", machineName))
instance, err := servers.Get(computeClient, machine.Get("metadata.annotations.openstack-resourceId").String()).Extract()
o.Expect(err).NotTo(o.HaveOccurred(), "Error gathering Openstack info for machine %v", machineName)

var gerr gophercloud.ErrDefault404
if !errors.As(err, &gerr) {
o.Expect(err).NotTo(o.HaveOccurred(), "Error gathering Openstack info for machine %v", machineName)
instanceAddresses, err := parseInstanceAddresses(instance.Addresses)
o.Expect(err).NotTo(o.HaveOccurred(), "Error parsing addresses for instance %q", instance.Name)
openstackIPs[machineName] = instanceAddresses
Expand Down