Skip to content

OCPQE-29415: UPSTREAM: <carry>: add OTE into olmv0#1105

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
kuiwang02:addote
Sep 15, 2025
Merged

OCPQE-29415: UPSTREAM: <carry>: add OTE into olmv0#1105
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
kuiwang02:addote

Conversation

@kuiwang02
Copy link
Copy Markdown
Contributor

⏺ # Add OTE (OpenShift Tests Extension) into olmv0 (Follow the olmv1 approach and reference code)

Summary

This PR introduces OTE (OpenShift Tests Extension) into olmv0, adding a comprehensive testing framework for operator lifecycle management v0 testing.

Key Changes

New Testing Extension

  • Added staging/tests-extension/ directory with complete test framework infrastructure
  • Main test runner (cmd/main.go) for executing test suites
  • Extended test framework (test/extended/) with OLMv0 specific test specs
  • Binary data generation for test resources using go-bindata

Build System Updates

  • Updated .bingo/ configuration to include new development tools:
    • go-bindata v3.1.2+incompatible for embedding binary data
    • golangci-lint v2.1.6 for enhanced code linting
  • Added Makefile for test extension build and execution
  • Updated Dockerfile to support the new testing framework

Configuration

  • OWNERS file for proper code review assignments
  • Git ignore rules for test artifacts
  • OpenShift payload configuration for test execution

Files Added/Modified

Core Files

  • staging/tests-extension/cmd/main.go - Main test runner
  • staging/tests-extension/test/extended/specs/olmv0.go - OLMv0 test specifications
  • staging/tests-extension/Makefile - Build configuration
  • staging/tests-extension/OWNERS - Code ownership

Build Configuration

  • .bingo/Variables.mk - Updated build variables
  • .bingo/go-bindata.mod - Go-bindata module configuration
  • .bingo/golangci-lint.mod - Linting tool configuration
  • operator-lifecycle-manager.Dockerfile - Updated Docker build

Test Result

./bin/olmv0-tests-ext run-test "[sig-operator][Jira:OLM] OLMv0 should pass a trivial sanity check"
  Running Suite:  - /Users/kuiwang/GoProject/go-origin/src/github.com/openshift/operator-framework-olm/staging/tests-extension
  ============================================================================================================================
  Random Seed: 1757646230 - will randomize all specs

  Will run 1 of 1 specs
  ------------------------------
  [sig-operator][Jira:OLM] OLMv0 should pass a trivial sanity check
  /Users/kuiwang/GoProject/go-origin/src/github.com/openshift/operator-framework-olm/staging/tests-extension/test/extended/specs/olmv0.go:11
  • [0.000 seconds]
  ------------------------------

  Ran 1 of 1 Specs in 0.000 seconds
  SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[
  {
    "name": "[sig-operator][Jira:OLM] OLMv0 should pass a trivial sanity check",
    "lifecycle": "blocking",
    "duration": 0,
    "startTime": "2025-09-12 03:03:50.875399 UTC",
    "endTime": "2025-09-12 03:03:50.876175 UTC",
    "result": "passed",
    "output": ""
  }
]

Assisted-by: Claude Code

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 12, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 12, 2025

@kuiwang02: This pull request references OCPQE-29415 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

⏺ # Add OTE (OpenShift Tests Extension) into olmv0 (Follow the olmv1 approach and reference code)

Summary

This PR introduces OTE (OpenShift Tests Extension) into olmv0, adding a comprehensive testing framework for operator lifecycle management v0 testing.

Key Changes

New Testing Extension

  • Added staging/tests-extension/ directory with complete test framework infrastructure
  • Main test runner (cmd/main.go) for executing test suites
  • Extended test framework (test/extended/) with OLMv0 specific test specs
  • Binary data generation for test resources using go-bindata

Build System Updates

  • Updated .bingo/ configuration to include new development tools:
    • go-bindata v3.1.2+incompatible for embedding binary data
    • golangci-lint v2.1.6 for enhanced code linting
  • Added Makefile for test extension build and execution
  • Updated Dockerfile to support the new testing framework

Configuration

  • OWNERS file for proper code review assignments
  • Git ignore rules for test artifacts
  • OpenShift payload configuration for test execution

Files Added/Modified

Core Files

  • staging/tests-extension/cmd/main.go - Main test runner
  • staging/tests-extension/test/extended/specs/olmv0.go - OLMv0 test specifications
  • staging/tests-extension/Makefile - Build configuration
  • staging/tests-extension/OWNERS - Code ownership

Build Configuration

  • .bingo/Variables.mk - Updated build variables
  • .bingo/go-bindata.mod - Go-bindata module configuration
  • .bingo/golangci-lint.mod - Linting tool configuration
  • operator-lifecycle-manager.Dockerfile - Updated Docker build

Test Result

./bin/olmv0-tests-ext run-test "[sig-operator][Jira:OLM] OLMv0 should pass a trivial sanity check"
 Running Suite:  - /Users/kuiwang/GoProject/go-origin/src/github.com/openshift/operator-framework-olm/staging/tests-extension
 ============================================================================================================================
 Random Seed: 1757646230 - will randomize all specs

 Will run 1 of 1 specs
 ------------------------------
 [sig-operator][Jira:OLM] OLMv0 should pass a trivial sanity check
 /Users/kuiwang/GoProject/go-origin/src/github.com/openshift/operator-framework-olm/staging/tests-extension/test/extended/specs/olmv0.go:11
 • [0.000 seconds]
 ------------------------------

 Ran 1 of 1 Specs in 0.000 seconds
 SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
[
 {
   "name": "[sig-operator][Jira:OLM] OLMv0 should pass a trivial sanity check",
   "lifecycle": "blocking",
   "duration": 0,
   "startTime": "2025-09-12 03:03:50.875399 UTC",
   "endTime": "2025-09-12 03:03:50.876175 UTC",
   "result": "passed",
   "output": ""
 }
]

Assisted-by: Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@perdasilva
Copy link
Copy Markdown
Contributor

/retest

@kuiwang02
Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-olm-flaky

@perdasilva
Copy link
Copy Markdown
Contributor

/approve

@perdasilva
Copy link
Copy Markdown
Contributor

do we need to run aggregate jobs to see if the tests are working?

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kuiwang02, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2025
@kuiwang02
Copy link
Copy Markdown
Contributor Author

do we need to run aggregate jobs to see if the tests are working?

@perdasilva thanks. I do not think so because it just add one trivial sanity check case.

@jianzhangbjz
Copy link
Copy Markdown
Contributor

/verified by pass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 15, 2025
@openshift-ci-robot
Copy link
Copy Markdown

@jianzhangbjz: This PR has been marked as verified by pass.

Details

In response to this:

/verified by pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianzhangbjz
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 15, 2025

@kuiwang02: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit ba16586 into openshift:main Sep 15, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants