Skip to content

OCPQE-29415:move golangci-lint and go-bindata to new location to fix sync#1114

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
kuiwang02:mvlintbindata
Sep 18, 2025
Merged

OCPQE-29415:move golangci-lint and go-bindata to new location to fix sync#1114
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
kuiwang02:mvlintbindata

Conversation

@kuiwang02
Copy link
Copy Markdown
Contributor

@kuiwang02 kuiwang02 commented Sep 18, 2025

I am sorry after #1108 is merged, the golangci-lint cause auto-sync broken.

I think this PR can fix it with moving the new added tool to new location.

Thanks

kuiwang@kuiwang-mac tests-extension % pwd
/Users/kuiwang/GoProject/go-origin/src/github.com/openshift/operator-framework-olm/tests-extension
kuiwang@kuiwang-mac tests-extension % make verify
go mod tidy
go fmt ./...
go vet ./...
(re)installing /Users/kuiwang/GoProject/go-origin/bin/golangci-lint-v2.1.6
/Users/kuiwang/GoProject/go-origin/bin/golangci-lint-v2.1.6 run
0 issues.
kuiwang@kuiwang-mac tests-extension % make bindata
(re)installing /Users/kuiwang/GoProject/go-origin/bin/go-bindata-v3.1.2+incompatible
mkdir -p pkg/bindata/qe
/Users/kuiwang/GoProject/go-origin/bin/go-bindata-v3.1.2+incompatible -nocompress -nometadata \
		-pkg testdata -o pkg/bindata/qe/bindata.go -prefix "testextended" test/qe/testdata/...
gofmt -s -w pkg/bindata/qe/bindata.go
kuiwang@kuiwang-mac tests-extension % bingo get 
kuiwang@kuiwang-mac tests-extension % cd ../
kuiwang@kuiwang-mac operator-framework-olm % bingo get
kuiwang@kuiwang-mac operator-framework-olm %

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 18, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 18, 2025 •
edited by openshift-ci Bot
Loading

@kuiwang02: This pull request references OCPQE-29415 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

I am sorry after #1108 is merged, the golangci-lint cause auto-sync broken.

I think this PR can fix it with moving the new added tool to new location.

Thanks

kuiwang@kuiwang-mac tests-extension % pwd
/Users/kuiwang/GoProject/go-origin/src/github.com/openshift/operator-framework-olm/tests-extension
kuiwang@kuiwang-mac tests-extension % make verify
go mod tidy
go fmt ./...
go vet ./...
(re)installing /Users/kuiwang/GoProject/go-origin/bin/golangci-lint-v2.1.6
/Users/kuiwang/GoProject/go-origin/bin/golangci-lint-v2.1.6 run
0 issues.
kuiwang@kuiwang-mac tests-extension % make bindata
(re)installing /Users/kuiwang/GoProject/go-origin/bin/go-bindata-v3.1.2+incompatible
mkdir -p pkg/bindata/qe
/Users/kuiwang/GoProject/go-origin/bin/go-bindata-v3.1.2+incompatible -nocompress -nometadata \
  	-pkg testdata -o pkg/bindata/qe/bindata.go -prefix "testextended" test/qe/testdata/...
gofmt -s -w pkg/bindata/qe/bindata.go
kuiwang@kuiwang-mac tests-extension % bingo get 
kuiwang@kuiwang-mac tests-extension % cd ../
kuiwang@kuiwang-mac operator-framework-olm % bingo get
kuiwang@kuiwang-mac operator-framework-olm %

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kuiwang02
Copy link
Copy Markdown
Contributor Author

kuiwang02 commented Sep 18, 2025

cc @tmshort @perdasilva @jianzhangbjz

@jianzhangbjz
Copy link
Copy Markdown
Contributor

jianzhangbjz commented Sep 18, 2025

/approve
/lgtm
/verified by pass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 18, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 18, 2025

@jianzhangbjz: This PR has been marked as verified by pass.

Details

In response to this:

/approve
/lgtm
/verified by pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianzhangbjz, kuiwang02

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2025
@kuiwang02 kuiwang02 mentioned this pull request Sep 18, 2025
Merged
@jianzhangbjz
Copy link
Copy Markdown
Contributor

jianzhangbjz commented Sep 18, 2025

/retest-required

@jianzhangbjz
Copy link
Copy Markdown
Contributor

jianzhangbjz commented Sep 18, 2025

/override e2e-gcp-olm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 18, 2025

@jianzhangbjz: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-gcp-olm

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-gcp-console-olm
  • ci/prow/e2e-gcp-olm
  • ci/prow/e2e-gcp-olm-flaky
  • ci/prow/e2e-gcp-ovn
  • ci/prow/e2e-upgrade
  • ci/prow/images
  • ci/prow/okd-scos-e2e-aws-ovn
  • ci/prow/okd-scos-images
  • ci/prow/periodics-images
  • ci/prow/unit-api
  • ci/prow/unit-olm
  • ci/prow/unit-psm
  • ci/prow/unit-registry
  • ci/prow/verify
  • ci/prow/verify-deps
  • pull-ci-openshift-operator-framework-olm-main-e2e-gcp-console-olm
  • pull-ci-openshift-operator-framework-olm-main-e2e-gcp-olm
  • pull-ci-openshift-operator-framework-olm-main-e2e-gcp-olm-flaky
  • pull-ci-openshift-operator-framework-olm-main-e2e-gcp-ovn
  • pull-ci-openshift-operator-framework-olm-main-e2e-upgrade
  • pull-ci-openshift-operator-framework-olm-main-images
  • pull-ci-openshift-operator-framework-olm-main-okd-scos-e2e-aws-ovn
  • pull-ci-openshift-operator-framework-olm-main-okd-scos-images
  • pull-ci-openshift-operator-framework-olm-main-periodics-images
  • pull-ci-openshift-operator-framework-olm-main-unit-api
  • pull-ci-openshift-operator-framework-olm-main-unit-olm
  • pull-ci-openshift-operator-framework-olm-main-unit-psm
  • pull-ci-openshift-operator-framework-olm-main-unit-registry
  • pull-ci-openshift-operator-framework-olm-main-verify
  • pull-ci-openshift-operator-framework-olm-main-verify-deps
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override e2e-gcp-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jianzhangbjz
Copy link
Copy Markdown
Contributor

jianzhangbjz commented Sep 18, 2025

/override ci/prow/e2e-gcp-olm

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 18, 2025

/retest-required

Remaining retests: 0 against base HEAD 56f9906 and 2 for PR HEAD fd5119f in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 18, 2025

@jianzhangbjz: Overrode contexts on behalf of jianzhangbjz: ci/prow/e2e-gcp-olm

Details

In response to this:

/override ci/prow/e2e-gcp-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit 44c9931 into openshift:main Sep 18, 2025
15 of 16 checks passed
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 18, 2025

@kuiwang02: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn fd5119f link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@grokspawn grokspawn Awaiting requested review from grokspawn

Assignees

@jianzhangbjz jianzhangbjz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kuiwang02 @openshift-ci-robot @jianzhangbjz