: NO-ISSUE: Migrate away from deprecated ioutil

[sebrandon1]

ioutil has been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutil

Tracking issue: redhat-best-practices-for-k8s/telco-bot#52

Migration from ioutil to os for file and directory operations:

• Replaced ioutil.ReadFile with os.ReadFile and ioutil.ReadDir with os.ReadDir in core configuration and bundle loading logic, such as in pkg/profiling/config/config.go and staging/api/pkg/manifests/bundleloader.go. [1] [2] [3] [4]

• Updated validation and testing files to use os.ReadFile instead of ioutil.ReadFile, including files like staging/api/pkg/validation/internal/community.go, crd_test.go, csv_test.go, object_test.go, and operatorgroup_test.go. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

• Updated additional internal and registry logic to use os.ReadFile, os.WriteFile, and os.MkdirTemp in place of their ioutil counterparts, such as in operatorhub.go, buildahregistry/_options.go, and provisioner_kind.go. [1] [2] [3] [4] [5] [6]

[perdasilva]

@sebrandon1 thanks so much for this!

Unfortunately, the changes done under the staging directory need to happen upstream first and then get downstreamed.
I've created two PRs:

• Migrate away from ioutil operator-framework/api#463
• Migrate away from ioutil operator-framework/operator-registry#1865

that bring your proposed changes to the upstream components.

Could you please revert the changes under staging and just check in the pkg/profiling/config changes?

[tmshort]

@sebrandon1 please consider rebasing this change to fix issues in the pkg directory.

[tmshort]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sebrandon1, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tmshort]

/lgtm

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 93a07f36-9c0b-4b6e-8d64-6f19b40259fb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tmshort]

/retitle: NO-ISSUE: Migrate away from deprecated ioutil

[openshift-ci-robot]

@sebrandon1: This pull request explicitly references no jira issue.

Details

In response to this:

ioutil has been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutil

Tracking issue: redhat-best-practices-for-k8s/telco-bot#52

Migration from ioutil to os for file and directory operations:

• Replaced ioutil.ReadFile with os.ReadFile and ioutil.ReadDir with os.ReadDir in core configuration and bundle loading logic, such as in pkg/profiling/config/config.go and staging/api/pkg/manifests/bundleloader.go. [1] [2] [3] [4]

• Updated validation and testing files to use os.ReadFile instead of ioutil.ReadFile, including files like staging/api/pkg/validation/internal/community.go, crd_test.go, csv_test.go, object_test.go, and operatorgroup_test.go. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

• Updated additional internal and registry logic to use os.ReadFile, os.WriteFile, and os.MkdirTemp in place of their ioutil counterparts, such as in operatorhub.go, buildahregistry/_options.go, and provisioner_kind.go. [1] [2] [3] [4] [5] [6]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bandrade]

/label qe-approved
/verified by @bandrade

[openshift-ci-robot]

@bandrade: This PR has been marked as verified by @bandrade.

Details

In response to this:

/label qe-approved
/verified by @bandrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 528f824 and 2 for PR HEAD dd3ff27 in total

[openshift-ci]

@sebrandon1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.