Skip to content

Update the layout and content within the root scripts directory#121

Closed
timflannagan wants to merge 3 commits intoopenshift:masterfrom
timflannagan:update-scripts-directory
Closed

Update the layout and content within the root scripts directory#121
timflannagan wants to merge 3 commits intoopenshift:masterfrom
timflannagan:update-scripts-directory

Conversation

@timflannagan
Copy link
Copy Markdown
Contributor

Update the README.md and remove the outdated downstream port guide command(s). Instead, reference the google doc that outlines the current process as we iterate on a more concrete process that will eventually live downstream. This is mainly a stop gap to avoid the OCP release cadence where we can't update something like the scripts/README.md during periods inside of feature/code freeze without a valid bug.

Remove the unused bash scripts. This mainly includes the helper scripts that attempted to automate the deliverance of upstream commits to the staging repositories as the presence of these scripts were generating confusion on the process. Remove the nested scripts/olm directory as those also appear to be unused.

Update the scripts/*.patch.yaml YQ patch files that are used to update the rendered staging OLM helm charts to make the requisite downstream-specific modifications to their own directory. Those patch files now live in scripts/patches and the manifest generation script has been updated to point to that new location.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from awgreene and benluddy July 14, 2021 23:31
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2021
@timflannagan timflannagan changed the title Update the script directory Update the layout and content within the root scripts directory Jul 14, 2021
@timflannagan
Copy link
Copy Markdown
Contributor Author

cc @kevinrizza - IIRC, we had talked about removing the pull/push remote scripts that were causing confusion during the last team retro and updating the README.md to simply point to the google doc that's currently housing the downstream guide.

@timflannagan
Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@timflannagan
Copy link
Copy Markdown
Contributor Author

/retest

@timflannagan timflannagan force-pushed the update-scripts-directory branch from 4a9f2e1 to a613c2b Compare July 19, 2021 16:18
@timflannagan
Copy link
Copy Markdown
Contributor Author

/test unit-olm

kevinrizza added a commit to kevinrizza/operator-framework-olm that referenced this pull request Jul 21, 2021
Upstream-repository: api
Upstream-commit: 41d37db9141f27da70d0066f2acf2dd070f8e092
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2021
Remove any unused scripts:

- Remove any of the scripts that were previous attempts at automating
  the downstream port process.
- Remove the nested olm script directory.
@timflannagan timflannagan force-pushed the update-scripts-directory branch from a613c2b to 952911a Compare July 27, 2021 16:09
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 27, 2021

@timflannagan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm 952911a link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 26, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 26, 2021

@timflannagan: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan timflannagan deleted the update-scripts-directory branch November 18, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants