Skip to content

OCPBUGS-31547: Remove the collect-profiles job#1215

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
tmshort:OCPBUGS-31547
Feb 5, 2026
Merged

OCPBUGS-31547: Remove the collect-profiles job#1215
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
tmshort:OCPBUGS-31547

Conversation

@tmshort
Copy link
Copy Markdown
Contributor

@tmshort tmshort commented Feb 2, 2026

Delete the collect-profiles job from Microshift and mark for deleed in OCP.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@tmshort: This pull request references Jira Issue OCPBUGS-31537, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target the "4.22.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Delete the collect-profiles job from Microshift and mark for deleed in OCP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2026
@tmshort tmshort changed the title OCPBUGS-31537: Remove the collect-profiles job OCPBUGS-31547: Remove the collect-profiles job Feb 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@tmshort: This pull request references Jira Issue OCPBUGS-31547, which is invalid:

  • expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.16.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Delete the collect-profiles job from Microshift and mark for deleed in OCP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Feb 2, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@tmshort: This pull request references Jira Issue OCPBUGS-31547, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Delete the collect-profiles job from Microshift and mark for deleed in OCP.
Includes all relevant resources.

Signed-off-by: Todd Short <todd.short@me.com>
@dtfranz
Copy link
Copy Markdown
Contributor

dtfranz commented Feb 3, 2026

/retest-required

1 similar comment
@rashmigottipati
Copy link
Copy Markdown
Member

/retest-required

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Feb 3, 2026

@kuiwang02 although you merged #1216 and I re-based, the two CIs are still failing due to NP issues

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Feb 3, 2026

/retest

@kuiwang02
Copy link
Copy Markdown
Contributor

@kuiwang02 although you merged #1216 and I re-based, the two CIs are still failing due to NP issues

@tmshort

I guess the reason is that the job is using the OTE binary from payload, and because the payload which include the PR is not ready (it has nothing with the PR), so the job seems take OTE binary which does not include the PR.

Besides that we have to wait to get green payload with PR (https://amd64.ocp.releases.ci.openshift.org/#4.22.0-0.nightly), we could take workaround to try it:
please change tests-extension/test/qe/specs/olmv0_networkpolicy.go in this PR from

e2e.Logf("specs: %v", specs)

to

e2e.Logf("specs:%v", specs)

to reduce the one space to make it built in this PR.

and if it pass, could merge it to keep changed code.

@kuiwang02
Copy link
Copy Markdown
Contributor

  • ci/prow/e2e-aws-olmv0-ext

@tmshort NO. it is not reason. the binary already include the the PR. per Log, it fails at

fail [/build/tests-extension/test/qe/specs/olmv0_networkpolicy.go:238]: Unexpected error:
    <*util.ExitError | 0xc00003df20>: 
    exit status 1
    {
        Cmd: "oc --kubeconfig=/tmp/kubeconfig-2514072020 get networkpolicy collect-profiles -n openshift-operator-lifecycle-manager -o=jsonpath={.spec}",
        StdErr: "Error from server (NotFound): networkpolicies.networking.k8s.io \"collect-profiles\" not found",
        ExitError: {
            ProcessState: {
                pid: 1808,
                status: 256,
                rusage: {
                    Utime: {Sec: 0, Usec: 136710},
                    Stime: {Sec: 0, Usec: 54634},
                    Maxrss: 95232,
                    Ixrss: 0,
                    Idrss: 0,
                    Isrss: 0,
                    Minflt: 8091,
                    Majflt: 0,
                    Nswap: 0,
                    Inblock: 0,
                    Oublock: 0,
                    Msgsnd: 0,
                    Msgrcv: 0,
                    Nsignals: 0,
                    Nvcsw: 654,
                    Nivcsw: 41,
                },
            },
            Stderr: nil,
        },
    }
occurred

it is line 238.

if there is no such PR, it is line 231.

I think the reason is that this PR cause Pod exists, but related networkpoilicay does not exist.
better to be:
if pod exists, networkpolicy exist, and pod does not exist, networkpolicy does not exist.

@kuiwang02
Copy link
Copy Markdown
Contributor

@tmshort
it is case's issue.
please do the following code change in tests-extension/test/qe/specs/olmv0_networkpolicy.go for case 83105 and 83583.

		if _, err := oc.AsAdmin().WithoutNamespace().
			Run("get").
			Args("pods", "-n", "openshift-operator-lifecycle-manager", "-l", "app=olm-collect-profiles").
			Output(); err == nil {

to

		if output, err := oc.AsAdmin().WithoutNamespace().
			Run("get").
			Args("pods", "-n", "openshift-operator-lifecycle-manager", "-l", "app=olm-collect-profiles", "-o", "name").
			Output(); err == nil && strings.Contains(output, "collect-profiles") {

or wait #1218 to rebase the code.

@jianzhangbjz
Copy link
Copy Markdown
Contributor

Test passed.

1. Build an OCP cluster with this PR
launch 4.22,openshift/operator-framework-olm#1215 aws
jiazha-mac:~ jiazha$ oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.22.0-0-2026-02-04-070310-test-ci-ln-flj7yft-latest   True        False         20m     Cluster version is 4.22.0-0-2026-02-04-070310-test-ci-ln-flj7yft-latest

2. Check if the collect-profiles job is removed. LGTM.
jiazha-mac:~ jiazha$ oc get cronjob
No resources found in openshift-operator-lifecycle-manager namespace.
jiazha-mac:~ jiazha$ oc get job
No resources found in openshift-operator-lifecycle-manager namespace.
jiazha-mac:~ jiazha$ oc get pods
NAME                                      READY   STATUS    RESTARTS   AGE
catalog-operator-5447c475c6-5tmxn         1/1     Running   0          48m
olm-operator-5cd754c997-m7qqk             1/1     Running   0          48m
package-server-manager-74599d644b-cvkbl   1/1     Running   0          48m
packageserver-789fc96b7d-45zsn            1/1     Running   0          45m
packageserver-789fc96b7d-925qq            1/1     Running   0          45m

jiazha-mac:~ jiazha$ oc get networkpolicy
NAME                       POD-SELECTOR                 AGE
catalog-operator           app=catalog-operator         49m
default-deny-all-traffic   <none>                       49m
olm-operator               app=olm-operator             49m
package-server-manager     app=package-server-manager   49m
packageserver              app=packageserver            49m

/verified by @jianzhangbjz

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@jianzhangbjz: This PR has been marked as verified by @jianzhangbjz.

Details

In response to this:

Test passed.

1. Build an OCP cluster with this PR
launch 4.22,openshift/operator-framework-olm#1215 aws
jiazha-mac:~ jiazha$ oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.22.0-0-2026-02-04-070310-test-ci-ln-flj7yft-latest   True        False         20m     Cluster version is 4.22.0-0-2026-02-04-070310-test-ci-ln-flj7yft-latest

2. Check if the collect-profiles job is removed. LGTM.
jiazha-mac:~ jiazha$ oc get cronjob
No resources found in openshift-operator-lifecycle-manager namespace.
jiazha-mac:~ jiazha$ oc get job
No resources found in openshift-operator-lifecycle-manager namespace.
jiazha-mac:~ jiazha$ oc get pods
NAME                                      READY   STATUS    RESTARTS   AGE
catalog-operator-5447c475c6-5tmxn         1/1     Running   0          48m
olm-operator-5cd754c997-m7qqk             1/1     Running   0          48m
package-server-manager-74599d644b-cvkbl   1/1     Running   0          48m
packageserver-789fc96b7d-45zsn            1/1     Running   0          45m
packageserver-789fc96b7d-925qq            1/1     Running   0          45m

jiazha-mac:~ jiazha$ oc get networkpolicy
NAME                       POD-SELECTOR                 AGE
catalog-operator           app=catalog-operator         49m
default-deny-all-traffic   <none>                       49m
olm-operator               app=olm-operator             49m
package-server-manager     app=package-server-manager   49m
packageserver              app=packageserver            49m

/verified by @jianzhangbjz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

@tmshort: This pull request references Jira Issue OCPBUGS-31547. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Delete the collect-profiles job from Microshift and mark for deleed in OCP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Feb 4, 2026

/reopen

@openshift-ci openshift-ci Bot reopened this Feb 4, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 4, 2026

@tmshort: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Copy Markdown

@tmshort: This pull request references Jira Issue OCPBUGS-31547, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Delete the collect-profiles job from Microshift and mark for deleed in OCP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Feb 4, 2026

/retest

Copy link
Copy Markdown

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2026
Copy link
Copy Markdown
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 0702302 and 2 for PR HEAD 0085e3c in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 5, 2026

@tmshort: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak, rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit fae41b2 into openshift:main Feb 5, 2026
15 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

@tmshort: Jira Issue OCPBUGS-31547: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31547 has been moved to the MODIFIED state.

Details

In response to this:

Delete the collect-profiles job from Microshift and mark for deleed in OCP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Feb 5, 2026

/cherry-pick release-4.21

@openshift-cherrypick-robot
Copy link
Copy Markdown

@tmshort: new pull request created: #1219

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants