OCPBUGS-31547: Remove the collect-profiles job#1215
OCPBUGS-31547: Remove the collect-profiles job#1215openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
|
@tmshort: This pull request references Jira Issue OCPBUGS-31537, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tmshort: This pull request references Jira Issue OCPBUGS-31547, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@tmshort: This pull request references Jira Issue OCPBUGS-31547, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
21cc573 to
8795092
Compare
Delete the collect-profiles job from Microshift and mark for deleed in OCP. Includes all relevant resources. Signed-off-by: Todd Short <todd.short@me.com>
a6f2a61 to
0085e3c
Compare
|
/retest-required |
1 similar comment
|
/retest-required |
|
@kuiwang02 although you merged #1216 and I re-based, the two CIs are still failing due to NP issues |
|
/retest |
I guess the reason is that the job is using the OTE binary from payload, and because the payload which include the PR is not ready (it has nothing with the PR), so the job seems take OTE binary which does not include the PR. Besides that we have to wait to get green payload with PR (https://amd64.ocp.releases.ci.openshift.org/#4.22.0-0.nightly), we could take workaround to try it: e2e.Logf("specs: %v", specs)to e2e.Logf("specs:%v", specs)to reduce the one space to make it built in this PR. and if it pass, could merge it to keep changed code. |
@tmshort NO. it is not reason. the binary already include the the PR. per Log, it fails at fail [/build/tests-extension/test/qe/specs/olmv0_networkpolicy.go:238]: Unexpected error:
<*util.ExitError | 0xc00003df20>:
exit status 1
{
Cmd: "oc --kubeconfig=/tmp/kubeconfig-2514072020 get networkpolicy collect-profiles -n openshift-operator-lifecycle-manager -o=jsonpath={.spec}",
StdErr: "Error from server (NotFound): networkpolicies.networking.k8s.io \"collect-profiles\" not found",
ExitError: {
ProcessState: {
pid: 1808,
status: 256,
rusage: {
Utime: {Sec: 0, Usec: 136710},
Stime: {Sec: 0, Usec: 54634},
Maxrss: 95232,
Ixrss: 0,
Idrss: 0,
Isrss: 0,
Minflt: 8091,
Majflt: 0,
Nswap: 0,
Inblock: 0,
Oublock: 0,
Msgsnd: 0,
Msgrcv: 0,
Nsignals: 0,
Nvcsw: 654,
Nivcsw: 41,
},
},
Stderr: nil,
},
}
occurredit is line 238. if there is no such PR, it is line 231. I think the reason is that this PR cause Pod exists, but related networkpoilicay does not exist. |
|
@tmshort if _, err := oc.AsAdmin().WithoutNamespace().
Run("get").
Args("pods", "-n", "openshift-operator-lifecycle-manager", "-l", "app=olm-collect-profiles").
Output(); err == nil {to if output, err := oc.AsAdmin().WithoutNamespace().
Run("get").
Args("pods", "-n", "openshift-operator-lifecycle-manager", "-l", "app=olm-collect-profiles", "-o", "name").
Output(); err == nil && strings.Contains(output, "collect-profiles") {or wait #1218 to rebase the code. |
|
Test passed. 1. Build an OCP cluster with this PR
launch 4.22,openshift/operator-framework-olm#1215 aws
jiazha-mac:~ jiazha$ oc get clusterversion
NAME VERSION AVAILABLE PROGRESSING SINCE STATUS
version 4.22.0-0-2026-02-04-070310-test-ci-ln-flj7yft-latest True False 20m Cluster version is 4.22.0-0-2026-02-04-070310-test-ci-ln-flj7yft-latest
2. Check if the collect-profiles job is removed. LGTM.
jiazha-mac:~ jiazha$ oc get cronjob
No resources found in openshift-operator-lifecycle-manager namespace.
jiazha-mac:~ jiazha$ oc get job
No resources found in openshift-operator-lifecycle-manager namespace.
jiazha-mac:~ jiazha$ oc get pods
NAME READY STATUS RESTARTS AGE
catalog-operator-5447c475c6-5tmxn 1/1 Running 0 48m
olm-operator-5cd754c997-m7qqk 1/1 Running 0 48m
package-server-manager-74599d644b-cvkbl 1/1 Running 0 48m
packageserver-789fc96b7d-45zsn 1/1 Running 0 45m
packageserver-789fc96b7d-925qq 1/1 Running 0 45m
jiazha-mac:~ jiazha$ oc get networkpolicy
NAME POD-SELECTOR AGE
catalog-operator app=catalog-operator 49m
default-deny-all-traffic <none> 49m
olm-operator app=olm-operator 49m
package-server-manager app=package-server-manager 49m
packageserver app=packageserver 49m/verified by @jianzhangbjz |
|
@jianzhangbjz: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tmshort: This pull request references Jira Issue OCPBUGS-31547. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/reopen |
|
@tmshort: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@tmshort: This pull request references Jira Issue OCPBUGS-31547, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
@tmshort: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pedjak, rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@tmshort: Jira Issue OCPBUGS-31547: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-31547 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.21 |
|
@tmshort: new pull request created: #1219 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Delete the collect-profiles job from Microshift and mark for deleed in OCP.