OCPQE-31752: enhance qe test cases#1254
OCPQE-31752: enhance qe test cases#1254openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@Xia-Zhao-rh: This pull request references OCPQE-31752 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThis PR updates OLMv0 non-all-namespaces tests to use a new CatalogSource image (catsrc-40529), reorders test steps to create OperatorGroup and CatalogSource before Subscription, and updates operator versions, channels, and CSV references consistently across multiple test cases. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@Xia-Zhao-rh: This pull request references OCPQE-31752 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests-extension/test/qe/specs/olmv0_nonallns.go (1)
4826-4841:⚠️ Potential issue | 🟠 MajorDon't treat
Installingas a passing end state in these constraint tests.These polls now return success while the expected CSVs are still
Installing. That can turn stalled or failed installs into false greens and weakens what these cases are validating. Keep polling until the required CSVs reachSucceeded, or split “created” vs “installed” into separate assertions.Also applies to: 4880-4894, 5023-5039, 5091-5107, 5159-5177, 5254-5270
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests-extension/test/qe/specs/olmv0_nonallns.go` around lines 4826 - 4841, The poll currently treats "Installing" as a passing end state causing false positives; update the lambda(s) that call olmv0util.GetResource (variables status1/status2) for the CSVs "etcdoperator.v0.9.2" and "ditto-operator.v0.1.1" so they only consider "Succeeded" as success (remove the checks against "Installing"), and fail/continue polling otherwise; apply the same change to the other identical checks in this file (the other occurrences referenced) so assertions that call exutil.AssertWaitPollNoErr wait until CSV status == "Succeeded" only.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests-extension/test/qe/specs/olmv0_nonallns.go`:
- Around line 4152-4160: The test races because CatalogSourceDescription.Create
(catsrc.Create) only applies the CatalogSource but doesn't wait for the catalog
pod/index to be READY before creating the Subscription; replace the unsafe
sub.Create(oc, itName, dr) call with the blocking variant
sub.CreateWithCheck(oc, itName, dr) (or otherwise wait for the CatalogSource to
be READY) so the subscription creation waits for the catalog to be usable and
won't miss the initial install plan; keep the existing defers (catsrc.Delete,
sub.Delete, sub.DeleteCSV, sub.Update) unchanged.
---
Outside diff comments:
In `@tests-extension/test/qe/specs/olmv0_nonallns.go`:
- Around line 4826-4841: The poll currently treats "Installing" as a passing end
state causing false positives; update the lambda(s) that call
olmv0util.GetResource (variables status1/status2) for the CSVs
"etcdoperator.v0.9.2" and "ditto-operator.v0.1.1" so they only consider
"Succeeded" as success (remove the checks against "Installing"), and
fail/continue polling otherwise; apply the same change to the other identical
checks in this file (the other occurrences referenced) so assertions that call
exutil.AssertWaitPollNoErr wait until CSV status == "Succeeded" only.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 056a2314-30e8-4b6e-b499-7d5c17f1e4e4
📒 Files selected for processing (1)
tests-extension/test/qe/specs/olmv0_nonallns.go
|
@Xia-Zhao-rh: This pull request references OCPQE-31752 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-operator-framework-olm-release-4.21-periodics-e2e-aws-ovn-extended-f1 |
|
@Xia-Zhao-rh: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1f306db0-1c8d-11f1-8ae6-ee7b1d978cc0-0 |
|
@Xia-Zhao-rh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/payload-job periodic-ci-openshift-operator-framework-olm-release-4.21-periodics-e2e-aws-ovn-extended-f1 |
|
@Xia-Zhao-rh: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b594e320-1ce8-11f1-9800-7543fe8a665e-0 |
|
/payload-job periodic-ci-openshift-operator-framework-olm-release-4.21-periodics-e2e-aws-ovn-extended-f1 |
|
@Xia-Zhao-rh: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/70c61e20-1d2a-11f1-9c31-03c5818acfbc-0 |
|
Hi, @kuiwang02 @jianzhangbjz PTAL, thanks |
|
/verified by @Xia-Zhao-rh |
openshift-ci-robot
added
the
verified
|
@Xia-Zhao-rh: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jianzhangbjz, Xia-Zhao-rh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
4 participants
Uh oh!
There was an error while loading. Please reload this page.