Skip to content

Bug 1989723: Improve ensure methods#152

Closed
awgreene wants to merge 2 commits intoopenshift:release-4.8from
awgreene:improve-ensure-methods
Closed

Bug 1989723: Improve ensure methods#152
awgreene wants to merge 2 commits intoopenshift:release-4.8from
awgreene:improve-ensure-methods

Conversation

@awgreene
Copy link
Copy Markdown
Contributor

@awgreene awgreene commented Aug 3, 2021

Problem: When calling a registry's ensure methods, if the resource is
deleted between the get and delete calls the ensure method fails due
to a 404 error.

Solution: When deleting an object, ignore 404 errors.
Signed-off-by: Alexander Greene greene.al1991@gmail.com

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 1b5afdceabb7a130f3f3d923b9784c007f9f4f2e

@awgreene
Registry ensure methods error out if resource is not found
a6919e6 
Problem: When calling a registry's ensure methods, if the resource is
deleted between the get and delete calls the ensure method fails due
to a 404 error.

Solution: When deleting an object, ignore 404 errors.
Signed-off-by: Alexander Greene <greene.al1991@gmail.com>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 1b5afdceabb7a130f3f3d923b9784c007f9f4f2e
@openshift-ci openshift-ci Bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 3, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 3, 2021

@awgreene: This pull request references Bugzilla bug 1989723, which is invalid:

  • expected dependent Bugzilla bug 1967621 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1989723: Improve ensure methods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2021
@timflannagan
Copy link
Copy Markdown
Contributor

timflannagan commented Aug 3, 2021

It looks like you need to run make vendor locally and commit the results.

@dinhxuanvu
Copy link
Copy Markdown
Contributor

dinhxuanvu commented Aug 4, 2021

You need to run make vendor and add those changes.

@awgreene
Copy link
Copy Markdown
Contributor Author

awgreene commented Aug 4, 2021

Committed the vendor changes @dinhxuanvu and @timflannagan

@timflannagan
Copy link
Copy Markdown
Contributor

timflannagan commented Aug 5, 2021

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 5, 2021

@awgreene: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-upgrade a7d4531 link /test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@awgreene
Copy link
Copy Markdown
Contributor Author

awgreene commented Aug 10, 2021

/bugzilla-refresh
/retest

@awgreene
Copy link
Copy Markdown
Contributor Author

awgreene commented Aug 10, 2021

The team has decided that this bug is not sever enough to warrant backporting, closing this PR.

@awgreene awgreene closed this Aug 10, 2021
ankitathomas pushed a commit to ankitathomas/operator-framework-olm that referenced this pull request Sep 8, 2021
@josefkarasek @ankitathomas
Add validation for Kind and APIVersion (openshift#152)
60088c8 
* Add validation for Kind and APIVersion

Signed-off-by: Josef Karasek <jkarasek@redhat.com>

* Update pkg/validation/internal/csv.go

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>
Upstream-repository: api
Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
ankitathomas pushed a commit to ankitathomas/operator-framework-olm that referenced this pull request Sep 9, 2021
@josefkarasek @ankitathomas
Add validation for Kind and APIVersion (openshift#152)
a4c39af 
* Add validation for Kind and APIVersion

Signed-off-by: Josef Karasek <jkarasek@redhat.com>

* Update pkg/validation/internal/csv.go

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>
Upstream-repository: api
Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Sep 28, 2021
@josefkarasek @timflannagan
Add validation for Kind and APIVersion (openshift#152)
6074098 
* Add validation for Kind and APIVersion

Signed-off-by: Josef Karasek <jkarasek@redhat.com>

* Update pkg/validation/internal/csv.go

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>
Upstream-repository: api
Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Sep 28, 2021
@josefkarasek @timflannagan
Add validation for Kind and APIVersion (openshift#152)
daa6165 
* Add validation for Kind and APIVersion

Signed-off-by: Josef Karasek <jkarasek@redhat.com>

* Update pkg/validation/internal/csv.go

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>
Upstream-repository: api
Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Sep 29, 2021
@josefkarasek @timflannagan
Add validation for Kind and APIVersion (openshift#152)
a7a3d58 
* Add validation for Kind and APIVersion

Signed-off-by: Josef Karasek <jkarasek@redhat.com>

* Update pkg/validation/internal/csv.go

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>
Upstream-repository: api
Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Sep 29, 2021
@josefkarasek @timflannagan
Add validation for Kind and APIVersion (openshift#152)
8c8329a 
* Add validation for Kind and APIVersion

Signed-off-by: Josef Karasek <jkarasek@redhat.com>

* Update pkg/validation/internal/csv.go

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>
Upstream-repository: api
Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Oct 13, 2021
@josefkarasek @timflannagan
Add validation for Kind and APIVersion (openshift#152)
c46c575 
* Add validation for Kind and APIVersion

Signed-off-by: Josef Karasek <jkarasek@redhat.com>

* Update pkg/validation/internal/csv.go

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>
Upstream-repository: api
Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
njhale pushed a commit to njhale/operator-framework-olm that referenced this pull request Oct 18, 2021
@josefkarasek @njhale
Add validation for Kind and APIVersion (openshift#152)
c8c8339 
* Add validation for Kind and APIVersion

Signed-off-by: Josef Karasek <jkarasek@redhat.com>

* Update pkg/validation/internal/csv.go

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>
Upstream-repository: api
Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
njhale pushed a commit to njhale/operator-framework-olm that referenced this pull request Oct 18, 2021
@josefkarasek @njhale
Add validation for Kind and APIVersion (openshift#152)
63b8415 
* Add validation for Kind and APIVersion

Signed-off-by: Josef Karasek <jkarasek@redhat.com>

* Update pkg/validation/internal/csv.go

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>
Upstream-repository: api
Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
timflannagan pushed a commit to njhale/operator-framework-olm that referenced this pull request Nov 15, 2021
@josefkarasek @timflannagan
Add validation for Kind and APIVersion (openshift#152)
a18ef53 
* Add validation for Kind and APIVersion

Signed-off-by: Josef Karasek <jkarasek@redhat.com>

* Update pkg/validation/internal/csv.go

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>
Upstream-repository: api
Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@josefkarasek @perdasilva
Add validation for Kind and APIVersion (openshift#152)
3efe442 
* Add validation for Kind and APIVersion

Signed-off-by: Josef Karasek <jkarasek@redhat.com>

* Update pkg/validation/internal/csv.go

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>
Upstream-repository: api
Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@josefkarasek @perdasilva
Add validation for Kind and APIVersion (openshift#152)
1805fc2 
* Add validation for Kind and APIVersion

Signed-off-by: Josef Karasek <jkarasek@redhat.com>

* Update pkg/validation/internal/csv.go

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>

Co-authored-by: Eric Stroczynski <ericstroczynski@gmail.com>
Upstream-repository: api
Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@timflannagan timflannagan Awaiting requested review from timflannagan

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@awgreene @timflannagan @dinhxuanvu