Skip to content

Bug 1989398: Avoid processing the .indexignore file when walking the root fs#153

Closed
timflannagan wants to merge 1 commit intoopenshift:masterfrom
timflannagan:bz-1989398
Closed

Bug 1989398: Avoid processing the .indexignore file when walking the root fs#153
timflannagan wants to merge 1 commit intoopenshift:masterfrom
timflannagan:bz-1989398

Conversation

@timflannagan
Copy link
Copy Markdown
Contributor

@timflannagan timflannagan commented Aug 3, 2021

Update internal/declcfg/load.go and avoid processing any files that are
named .indexignore when walking the declarative config index root
filesystem. When validating declarative config directories, the
.indexignore file was being processed and validated.

Signed-off-by: timflannagan timflannagan@gmail.com

Upstream-repository: operator-registry
Upstream-commit: 78f27b39dc098c2e56681d9a3d8e786aae95d4fe

@timflannagan
internal/declcfg: Avoid processing the .indexignore file when walking…
d37a8d8 
… the root fs (openshift#733)

Update internal/declcfg/load.go and avoid processing any files that are
named `.indexignore` when walking the declarative config index root
filesystem. When validating declarative config directories, the
.indexignore file was being processed and validated.

Signed-off-by: timflannagan <timflannagan@gmail.com>

Upstream-repository: operator-registry
Upstream-commit: 78f27b39dc098c2e56681d9a3d8e786aae95d4fe
@openshift-ci openshift-ci Bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Aug 3, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 3, 2021

@timflannagan: This pull request references Bugzilla bug 1989398, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (kuiwang@redhat.com), skipping review request.

Details

In response to this:

Bug 1989398: Avoid processing the .indexignore file when walking the root fs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 3, 2021
@openshift-ci openshift-ci Bot requested review from estroz and exdx August 3, 2021 20:51
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2021
@timflannagan
Copy link
Copy Markdown
Contributor Author

timflannagan commented Aug 4, 2021

/retest

5 similar comments
@timflannagan
Copy link
Copy Markdown
Contributor Author

timflannagan commented Aug 4, 2021

/retest

@timflannagan
Copy link
Copy Markdown
Contributor Author

timflannagan commented Aug 5, 2021

/retest

@timflannagan
Copy link
Copy Markdown
Contributor Author

timflannagan commented Aug 5, 2021

/retest

@kuiwang02
Copy link
Copy Markdown
Contributor

kuiwang02 commented Aug 12, 2021

/retest

@timflannagan
Copy link
Copy Markdown
Contributor Author

timflannagan commented Aug 12, 2021

/retest

njhale
njhale reviewed Aug 12, 2021
View reviewed changes
Comment thread staging/operator-registry/internal/declcfg/load.go
if info.IsDir() || matcher.Match(path, false) {
// avoid validating a directory, an .indexignore file, or any file that matches
// an ignore pattern outlined in a .indexignore file.
if info.IsDir() || info.Name() == indexIgnoreFilename || matcher.Match(path, false) {
Copy link
Copy Markdown
Contributor

@njhale njhale Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there no tests for this?

njhale
njhale approved these changes Aug 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, all behavioral changes should be accompanied by a test, but since this has already merged upstream, I don't think we should introduce a downstream-diff for it.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [njhale,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@timflannagan
Copy link
Copy Markdown
Contributor Author

timflannagan commented Aug 12, 2021

Decided against porting this downstream.

@timflannagan timflannagan deleted the bz-1989398 branch August 12, 2021 14:29
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 12, 2021

@timflannagan: This pull request references Bugzilla bug 1989398. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Bug 1989398: Avoid processing the .indexignore file when walking the root fs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Nov 30, 2021
@timflannagan
Add Service Account Config to Scorecard (openshift#153)
6af63ed 
* add SA field to config

Signed-off-by: Ish Shah <ishah@redhat.com>

* Update pkg/apis/scorecard/v1alpha3/configuration_types.go

Co-authored-by: Joe Lanford <joe.lanford@gmail.com>

Upstream-repository: api
Upstream-commit: 179663555651895b714e51a56dc0461fbc197235
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@perdasilva
Add Service Account Config to Scorecard (openshift#153)
4e67c67 
* add SA field to config

Signed-off-by: Ish Shah <ishah@redhat.com>

* Update pkg/apis/scorecard/v1alpha3/configuration_types.go

Co-authored-by: Joe Lanford <joe.lanford@gmail.com>

Upstream-repository: api
Upstream-commit: 179663555651895b714e51a56dc0461fbc197235
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@perdasilva
Add Service Account Config to Scorecard (openshift#153)
77bb025 
* add SA field to config

Signed-off-by: Ish Shah <ishah@redhat.com>

* Update pkg/apis/scorecard/v1alpha3/configuration_types.go

Co-authored-by: Joe Lanford <joe.lanford@gmail.com>

Upstream-repository: api
Upstream-commit: 179663555651895b714e51a56dc0461fbc197235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estroz estroz Awaiting requested review from estroz

@exdx exdx Awaiting requested review from exdx

1 more reviewer

@njhale njhale njhale approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@njhale njhale

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timflannagan @kuiwang02 @njhale