Bug 1989431: fix(opm): clarify that bundle declcfgs are not valid refs alone by estroz · Pull Request #164 · openshift/operator-framework-olm

estroz · 2021-08-11T19:45:36Z

fix(opm): clarify that bundle declcfgs are not valid refs alone

Signed-off-by: Eric Stroczynski ericstroczynski@gmail.com

internal/action: changed ErrNotAllowed to variable for correct errors.Is() comparison

Signed-off-by: Eric Stroczynski ericstroczynski@gmail.com

Upstream-repository: operator-registry
Upstream-commit: 88d4d7633b93a73a2da2bd39348a8ba40b75db24

openshift-ci · 2021-08-11T19:45:41Z

@estroz: This pull request references Bugzilla bug 1989431, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1989431: fix(opm): clarify that bundle declcfgs are not valid refs alone

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

estroz · 2021-08-11T20:31:58Z

/bugzilla refresh

openshift-ci · 2021-08-11T20:40:13Z

@estroz: An error was encountered querying GitHub for users with public email (kuiwang@redhat.com) for bug 1989431 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n  \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

estroz · 2021-08-11T20:47:10Z

/bugzilla refresh

openshift-ci · 2021-08-11T20:53:22Z

@estroz: An error was encountered querying GitHub for users with public email (kuiwang@redhat.com) for bug 1989431 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n  \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

estroz · 2021-08-11T20:53:36Z

/bugzilla refresh

openshift-ci · 2021-08-11T20:56:43Z

@estroz: An error was encountered querying GitHub for users with public email (kuiwang@redhat.com) for bug 1989431 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n  \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

estroz · 2021-08-11T21:25:15Z

/bugzilla refresh

openshift-ci · 2021-08-11T21:26:22Z

@estroz: An error was encountered querying GitHub for users with public email (kuiwang@redhat.com) for bug 1989431 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n  \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

estroz · 2021-08-11T21:50:18Z

/bugzilla refresh

openshift-ci · 2021-08-11T21:50:24Z

@estroz: This pull request references Bugzilla bug 1989431, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (kuiwang@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

njhale · 2021-08-12T13:21:27Z

/retest

njhale · 2021-08-12T13:21:52Z

/lgtm

estroz · 2021-08-12T15:49:30Z

/test e2e-gcp

estroz · 2021-08-12T16:04:02Z

/test e2e-upgrade

estroz · 2021-08-12T16:17:47Z

/test e2e-aws-olm

estroz · 2021-08-12T19:34:06Z

/retest

estroz · 2021-08-12T22:57:15Z

/retest

estroz · 2021-08-13T06:41:36Z

/test e2e-upgrade

estroz · 2021-08-13T06:43:01Z

/cc @joelanford

estroz · 2021-08-13T15:41:09Z

/retest

* fix(opm): clarify that bundle declcfgs are not valid refs alone Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com> * internal/action: changed ErrNotAllowed to variable for correct errors.Is() comparison Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com> Upstream-repository: operator-registry Upstream-commit: 88d4d7633b93a73a2da2bd39348a8ba40b75db24

estroz · 2021-08-17T17:29:37Z

/retest

estroz · 2021-08-17T20:24:17Z

/retest

dinhxuanvu

/lgtm

dinhxuanvu · 2021-08-17T22:50:01Z

/retest

openshift-ci · 2021-08-17T22:50:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dinhxuanvu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-08-18T03:57:54Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-18T04:09:54Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-18T07:44:39Z

@estroz: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#164

Bugzilla bug 1989431 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1989431: fix(opm): clarify that bundle declcfgs are not valid refs alone

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Upstream-repository: api Upstream-commit: 37561c93045eee6044ae4748d3aea29fae5b09f8

openshift-ci Bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Aug 11, 2021

openshift-ci Bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 11, 2021

openshift-ci Bot requested review from awgreene and benluddy August 11, 2021 19:46

openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 11, 2021

openshift-ci Bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 11, 2021

openshift-ci Bot assigned njhale Aug 12, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2021

openshift-ci Bot requested a review from joelanford August 13, 2021 06:43

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2021

openshift-ci Bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 16, 2021

dinhxuanvu approved these changes Aug 17, 2021

View reviewed changes

openshift-ci Bot assigned dinhxuanvu Aug 17, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2021

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2021

openshift-ci Bot merged commit fc5e9b5 into openshift:master Aug 18, 2021

estroz deleted the bz/1989431 branch August 18, 2021 15:25

timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Nov 30, 2021

fix: add missing allowed category (openshift#164)

8ef6901

Upstream-repository: api Upstream-commit: 37561c93045eee6044ae4748d3aea29fae5b09f8

timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Nov 30, 2021

fix: add missing allowed category (openshift#164)

8a250a5

Upstream-repository: api Upstream-commit: 37561c93045eee6044ae4748d3aea29fae5b09f8

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022

fix: add missing allowed category (openshift#164)

a7e95d7

Upstream-repository: api Upstream-commit: 37561c93045eee6044ae4748d3aea29fae5b09f8

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022

fix: add missing allowed category (openshift#164)

b58a566

Upstream-repository: api Upstream-commit: 37561c93045eee6044ae4748d3aea29fae5b09f8

Conversation

estroz commented Aug 11, 2021

Uh oh!

openshift-ci Bot commented Aug 11, 2021

Uh oh!

estroz commented Aug 11, 2021

Uh oh!

openshift-ci Bot commented Aug 11, 2021

Uh oh!

estroz commented Aug 11, 2021

Uh oh!

openshift-ci Bot commented Aug 11, 2021

Uh oh!

estroz commented Aug 11, 2021

Uh oh!

openshift-ci Bot commented Aug 11, 2021

Uh oh!

estroz commented Aug 11, 2021

Uh oh!

openshift-ci Bot commented Aug 11, 2021

Uh oh!

estroz commented Aug 11, 2021

Uh oh!

openshift-ci Bot commented Aug 11, 2021

Uh oh!

njhale commented Aug 12, 2021

Uh oh!

njhale commented Aug 12, 2021

Uh oh!

estroz commented Aug 12, 2021

Uh oh!

estroz commented Aug 12, 2021

Uh oh!

estroz commented Aug 12, 2021

Uh oh!

estroz commented Aug 12, 2021

Uh oh!

estroz commented Aug 12, 2021

Uh oh!

estroz commented Aug 13, 2021

Uh oh!

estroz commented Aug 13, 2021

Uh oh!

estroz commented Aug 13, 2021

Uh oh!

estroz commented Aug 17, 2021

Uh oh!

estroz commented Aug 17, 2021

Uh oh!

dinhxuanvu left a comment

Choose a reason for hiding this comment

Uh oh!

dinhxuanvu commented Aug 17, 2021

Uh oh!

openshift-ci Bot commented Aug 17, 2021

Uh oh!

openshift-bot commented Aug 18, 2021

Uh oh!

openshift-bot commented Aug 18, 2021

Uh oh!

openshift-ci Bot commented Aug 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants