Skip to content

Bug 1996139: chore(verify-commits): initialize variable#171

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
njhale:fix/verify-commits
Aug 20, 2021
Merged

Bug 1996139: chore(verify-commits): initialize variable#171
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
njhale:fix/verify-commits

Conversation

@njhale
Copy link
Copy Markdown
Contributor

@njhale njhale commented Aug 19, 2021

Set a default value for a variable causing undefined errors at runtime.

This was causing the verify make target to fail erroneously.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021
ankitathomas
ankitathomas approved these changes Aug 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2021
@ankitathomas
Copy link
Copy Markdown
Contributor

ankitathomas commented Aug 19, 2021

/lgtm cancel

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2021
dinhxuanvu
dinhxuanvu approved these changes Aug 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2021
ankitathomas
ankitathomas suggested changes Aug 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outside_staging="$(git show --name-only "${downstream_commit}" -- ":!${staging_dir}" ':!vendor :!manifests')"

Looks like the vendor/manifests directories need to be quoted individually, or they fail

outside_staging="$(git show --name-only "${downstream_commit}" -- ":!${staging_dir}" ':!vendor' ':!manifests')"

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2021
@dinhxuanvu
Copy link
Copy Markdown
Contributor

dinhxuanvu commented Aug 19, 2021

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2021
@njhale njhale force-pushed the fix/verify-commits branch from 4bdfc77 to 6917112 Compare August 19, 2021 18:25
ankitathomas
ankitathomas approved these changes Aug 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ankitathomas
Copy link
Copy Markdown
Contributor

ankitathomas commented Aug 19, 2021

/hold cancel

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 19, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, dinhxuanvu, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ankitathomas,dinhxuanvu,njhale]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 19, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 19, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 19, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 19, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 20, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@kevinrizza kevinrizza mentioned this pull request Aug 20, 2021
Merged
@njhale njhale changed the title chore(verify-commits): initialize variable Bug 1996139 chore(verify-commits): initialize variable Aug 20, 2021
@njhale
Copy link
Copy Markdown
Contributor Author

njhale commented Aug 20, 2021

/bugzilla refresh

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 20, 2021

@njhale: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@njhale njhale changed the title Bug 1996139 chore(verify-commits): initialize variable Bug 1996139: chore(verify-commits): initialize variable Aug 20, 2021
@openshift-ci openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 20, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 20, 2021

@njhale: This pull request references Bugzilla bug 1996139, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

Bug 1996139: chore(verify-commits): initialize variable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from jianzhangbjz August 20, 2021 16:13
@njhale
Copy link
Copy Markdown
Contributor Author

njhale commented Aug 20, 2021

/bugzilla refresh

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 20, 2021

@njhale: This pull request references Bugzilla bug 1996139, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Copy Markdown
Contributor

timflannagan commented Aug 20, 2021

/override ci/prow/e2e-gcp
/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-upgrade

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 20, 2021

@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/e2e-aws-olm, ci/prow/e2e-gcp, ci/prow/e2e-upgrade

Details

In response to this:

/override ci/prow/e2e-gcp
/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit b5600cf into openshift:master Aug 20, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 20, 2021

@njhale: All pull requests linked via external trackers have merged:

Bugzilla bug 1996139 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1996139: chore(verify-commits): initialize variable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

anik120 pushed a commit to anik120/operator-framework-olm that referenced this pull request Dec 10, 2021
@camilamacedo86 @anik120
doc: fix layout of the doc (openshift#171)
d61ec93 
upstream-repository: api
upstream-commit: 940ea901d140df5559af22c4ea094fe790a5258b
anik120 pushed a commit to anik120/operator-framework-olm that referenced this pull request Dec 10, 2021
@camilamacedo86 @anik120
doc: fix layout of the doc (openshift#171)
d073e45 
Upstream-repository: api
Upstream-commit: 940ea901d140df5559af22c4ea094fe790a5258b
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@camilamacedo86 @perdasilva
doc: fix layout of the doc (openshift#171)
c2b34e7 
Upstream-repository: api
Upstream-commit: 940ea901d140df5559af22c4ea094fe790a5258b
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@camilamacedo86 @perdasilva
doc: fix layout of the doc (openshift#171)
6ce6876 
Upstream-repository: api
Upstream-commit: 940ea901d140df5559af22c4ea094fe790a5258b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

2 more reviewers

@ankitathomas ankitathomas ankitathomas approved these changes

@dinhxuanvu dinhxuanvu dinhxuanvu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ankitathomas ankitathomas

@dinhxuanvu dinhxuanvu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@njhale @ankitathomas @dinhxuanvu @openshift-bot @timflannagan @openshift-merge-robot