Skip to content

[release-4.8] Bug 1994038: clarify maxOpenShiftVersion upgrade error message#173

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.8from
timflannagan:release-4.8-bz-1992677-parent-manual-cp
Aug 23, 2021
Merged

[release-4.8] Bug 1994038: clarify maxOpenShiftVersion upgrade error message#173
openshift-merge-robot merged 1 commit intoopenshift:release-4.8from
timflannagan:release-4.8-bz-1992677-parent-manual-cp

Conversation

@timflannagan
Copy link
Copy Markdown
Contributor

@timflannagan timflannagan commented Aug 23, 2021

Signed-off-by: Ankita Thomas ankithom@redhat.com

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 7c2f004129b037333c4fe29ec5ac94b5e1247564

@ankitathomas @timflannagan
clarify maxOpenShiftVersion upgrade error message (#2326)
99e57be 
Signed-off-by: Ankita Thomas <ankithom@redhat.com>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 7c2f004129b037333c4fe29ec5ac94b5e1247564
@openshift-ci openshift-ci Bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Aug 23, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 23, 2021

@timflannagan: This pull request references Bugzilla bug 1994038, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1992677 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1992677 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

Bug 1994038: clarify maxOpenShiftVersion upgrade error message (#2326)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 23, 2021
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2021
@timflannagan
Copy link
Copy Markdown
Contributor Author

timflannagan commented Aug 23, 2021

Manual cherrypick of #169 as pulling down the api repository commits produced a merge conflict as relevant changes made to the community packages were introduced after the 4.8 release. Dropping those commits entirely and just cherrypicking the updated message.

@timflannagan timflannagan changed the title Bug 1994038: clarify maxOpenShiftVersion upgrade error message (#2326) [release-4.8] Bug 1994038: clarify maxOpenShiftVersion upgrade error message (#2326) Aug 23, 2021
@timflannagan timflannagan changed the title [release-4.8] Bug 1994038: clarify maxOpenShiftVersion upgrade error message (#2326) [release-4.8] Bug 1994038: clarify maxOpenShiftVersion upgrade error message Aug 23, 2021
@sdodson
Copy link
Copy Markdown
Member

sdodson commented Aug 23, 2021

Infra flakes on yum repos?
/retest-required

@openshift-ci openshift-ci Bot mentioned this pull request Aug 23, 2021
Merged
@timflannagan
Copy link
Copy Markdown
Contributor Author

timflannagan commented Aug 23, 2021

/retest

dinhxuanvu
dinhxuanvu approved these changes Aug 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 23, 2021
@sdodson
Copy link
Copy Markdown
Member

sdodson commented Aug 23, 2021

Setting cherry-pick-approved to get this in as a late fix.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dinhxuanvu,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Copy Markdown
Member

sdodson commented Aug 23, 2021

/test e2e-gcp

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Copy Markdown
Member

sdodson commented Aug 23, 2021

/override ci/prow/e2e-upgrade
This does not affect node availability.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 23, 2021

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-upgrade

Details

In response to this:

/override ci/prow/e2e-upgrade
This does not affect node availability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit dca2c2c into openshift:release-4.8 Aug 23, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 23, 2021

@timflannagan: All pull requests linked via external trackers have merged:

Bugzilla bug 1994038 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.8] Bug 1994038: clarify maxOpenShiftVersion upgrade error message

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan timflannagan deleted the release-4.8-bz-1992677-parent-manual-cp branch September 29, 2021 19:33
anik120 pushed a commit to anik120/operator-framework-olm that referenced this pull request Dec 10, 2021
@perdasilva @anik120
Add grpcPodConfig attribute to spec (openshift#173)
effb5ef 
Signed-off-by: Per G. da Silva <perdasilva@redhat.com>

upstream-repository: api
upstream-commit: 822c9fe93cc0befb1c98da043662ecace5597f08
anik120 pushed a commit to anik120/operator-framework-olm that referenced this pull request Dec 10, 2021
@perdasilva @anik120
Add grpcPodConfig attribute to spec (openshift#173)
33fa110 
Signed-off-by: Per G. da Silva <perdasilva@redhat.com>

Upstream-repository: api
Upstream-commit: 822c9fe93cc0befb1c98da043662ecace5597f08
perdasilva added a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@perdasilva
Add grpcPodConfig attribute to spec (openshift#173)
ee0efc5 
Signed-off-by: Per G. da Silva <perdasilva@redhat.com>

Upstream-repository: api
Upstream-commit: 822c9fe93cc0befb1c98da043662ecace5597f08
perdasilva added a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@perdasilva
Add grpcPodConfig attribute to spec (openshift#173)
bd6fe92 
Signed-off-by: Per G. da Silva <perdasilva@redhat.com>

Upstream-repository: api
Upstream-commit: 822c9fe93cc0befb1c98da043662ecace5597f08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@hasbro17 hasbro17 Awaiting requested review from hasbro17

1 more reviewer

@dinhxuanvu dinhxuanvu dinhxuanvu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dinhxuanvu dinhxuanvu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@timflannagan @sdodson @openshift-bot @dinhxuanvu @openshift-merge-robot @ankitathomas