Skip to content

Prevent incompatible operators from being resolved (hardcode variant)#194

Closed
njhale wants to merge 2 commits intoopenshift:masterfrom
njhale:maxocpver-constraint-patch
Closed

Prevent incompatible operators from being resolved (hardcode variant)#194
njhale wants to merge 2 commits intoopenshift:masterfrom
njhale:maxocpver-constraint-patch

Conversation

@njhale
Copy link
Copy Markdown
Contributor

@njhale njhale commented Sep 18, 2021 •
edited
Loading

The other way to implement downstream-only constraints (see #193 for the alternative).

Hardcode a constraint that prevents operators from being resolved on versions of OpenShift clusters they don't support.

Implementation Pros:

  • doesn't depend on upstream refactoring
  • we don't need to expose public Go APIs for an constraint injection upstream (yet)

Cons:

  • need to carry a downstream-only patch to /staging
  • the first downstream-only patch to /staging to date

Note: We expect verify to (correctly) fail since we're patching /staging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 18, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2021
@njhale
Copy link
Copy Markdown
Contributor Author

njhale commented Sep 18, 2021

/test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from exdx and kevinrizza September 18, 2021 00:46
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 18, 2021

@njhale: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 71bf023 link true /test verify
ci/prow/unit-olm 71bf023 link true /test unit-olm
ci/prow/e2e-aws-olm 71bf023 link true /test e2e-aws-olm
ci/prow/e2e-gcp 71bf023 link true /test e2e-gcp
ci/prow/e2e-aws-console-olm 71bf023 link true /test e2e-aws-console-olm
ci/prow/e2e-upgrade 71bf023 link true /test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@njhale
feat(catalog): prohibit incompatible operators
200c472 
Hardcode a constraint that prevents operators from being
resolved on versions of OpenShift clusters they don't support.

This commit is carried in downstream only and should not be ported
upstream.
@njhale njhale force-pushed the maxocpver-constraint-patch branch from 71bf023 to 200c472 Compare September 22, 2021 13:47
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 17, 2021

@njhale: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@njhale
Copy link
Copy Markdown
Contributor Author

njhale commented Dec 1, 2021

stale

@njhale njhale closed this Dec 1, 2021
@perdasilva perdasilva mentioned this pull request Dec 3, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@exdx exdx Awaiting requested review from exdx

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@njhale