Staged upstream repositories by ankitathomas · Pull Request #2 · openshift/operator-framework-olm

ankitathomas · 2021-02-24T20:53:50Z

No description provided.

timflannagan · 2021-02-25T17:22:26Z

/test all

timflannagan · 2021-02-25T17:45:50Z

/test all
/verify-owners

timflannagan · 2021-02-25T17:47:57Z

/lgtm

timflannagan · 2021-02-25T17:48:13Z

/approve

timflannagan · 2021-02-25T17:48:33Z

/lgtm cancel

timflannagan · 2021-02-25T17:49:34Z

Oh weird it's probably reading from the OWNERS file that attached to the commit and not this repository's current OWNERS file.

openshift-ci-robot · 2021-02-25T17:54:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ankitathomas,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

timflannagan · 2021-02-25T18:13:07Z

/verify-owners
/lgtm

openshift-ci-robot · 2021-02-25T18:43:24Z

New changes are detected. LGTM label has been removed.

ankitathomas · 2021-02-25T18:43:42Z

/verify-owners

openshift-ci-robot · 2021-02-25T18:55:53Z

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing /verify-owners in a comment.

Bowenislandsong
- User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

timflannagan · 2021-02-25T19:01:05Z

+# approval == this is a good idea /approve
+approvers:
+  - ecordell
+  - njhale
+  - dinhxuanvu
+  - kevinrizza
+  - benluddy
+# review == this code is good /lgtm
+reviewers:
+  - ecordell
+  - njhale
+  - dinhxuanvu
+  - kevinrizza
+  - gallettilance
+  - anik120
+  - exdx
+  - awgreene
+  - Bowenislandsong
+  - benluddy
+  - ankitathomas


Let's remove this file

timflannagan · 2021-02-25T19:02:28Z

+
+# approval == this is a good idea /approve
+approvers:
+  - ecordell
+  - njhale
+  - kevinrizza
+  - benluddy
+  - awgreene
+# review == this code is good /lgtm
+reviewers:
+  - ecordell
+  - njhale
+  - kevinrizza
+  - benluddy
+  - dinhxuanvu
+  - gallettilance
+  - anik120
+  - exdx
+  - awgreene
+  - hasbro17
+  - ankitathomas
+  - joelanford
+  - timflannagan
+# Bugzilla component
+component: "OLM"


timflannagan · 2021-02-25T20:17:45Z

Superseded by #5

/close

openshift-ci-robot · 2021-02-25T20:17:58Z

@timflannagan: Closed this PR.

Details

In response to this:

Superseded by #5

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Package cleanup (upstream operator-registry commit: 06f1c06ac03372aa94253fdf6f8fdbb59dfa3a5c)

This is the 1st commit message: wip This is the commit message openshift#2:

* refactor to move more processing to the template Signed-off-by: Jordan Keister <jordan@nimblewidget.com> * better diagnostics on custom exec error Signed-off-by: Jordan Keister <jordan@nimblewidget.com> * Remove obsolete fields Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com> Signed-off-by: Jordan Keister <jordan@nimblewidget.com> * caching wip Signed-off-by: Jordan Keister <jordan@nimblewidget.com> * refactor a bit and update unit tests (openshift#2) * refactor a bit and update unit tests Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * add more utests and minor tweaks Signed-off-by: Bryce Palmer <bpalmer@redhat.com> --------- Signed-off-by: Bryce Palmer <bpalmer@redhat.com> Signed-off-by: Jordan Keister <jordan@nimblewidget.com> * whitespace sanity hell Signed-off-by: Jordan Keister <jordan@nimblewidget.com> * drop STDERR for nominal case Signed-off-by: Jordan Keister <jordan@nimblewidget.com> --------- Signed-off-by: Jordan Keister <jordan@nimblewidget.com> Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com> Signed-off-by: Bryce Palmer <bpalmer@redhat.com> Co-authored-by: Catherine Chan-Tse <cchantse@redhat.com> Co-authored-by: Bryce Palmer <everettraven@gmail.com> Upstream-repository: operator-registry Upstream-commit: 00a4cce4847d75f71bbcb574e0e7ac364fd9f546

… to a file-based catalog (openshift#1127) * Documentation on how to add a plain bundle to a file-based catalog Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> * Address review feedback Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> * Clarify regular bundle to be of registry+v1 format Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> * Address review feedback openshift#1 Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> * Address review feedback openshift#2 Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> * Address review feedback openshift#3 Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> * Add an example for the desired channel name and link to OLM best practices for channel naming conventions Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> --------- Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>

… to a file-based catalog (openshift#1127) * Documentation on how to add a plain bundle to a file-based catalog Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> * Address review feedback Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> * Clarify regular bundle to be of registry+v1 format Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> * Address review feedback openshift#1 Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> * Address review feedback openshift#2 Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> * Address review feedback openshift#3 Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> * Add an example for the desired channel name and link to OLM best practices for channel naming conventions Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> --------- Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> Upstream-repository: operator-registry Upstream-commit: bca2bfb89bc4db7bd9ebd08031be3d59bfdc65e8

openshift-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 24, 2021

openshift-ci-robot assigned timflannagan Feb 25, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2021

ankitathomas force-pushed the master branch from 8e33599 to f66ef3a Compare February 25, 2021 18:05

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021

ankitathomas force-pushed the master branch from f66ef3a to a65e877 Compare February 25, 2021 18:43

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021

timflannagan reviewed Feb 25, 2021

View reviewed changes

Initial commit

06ba2ea

ankitathomas force-pushed the master branch from a65e877 to 06ba2ea Compare February 25, 2021 20:12

ankitathomas closed this Feb 25, 2021

ankitathomas pushed a commit to ankitathomas/operator-framework-olm that referenced this pull request Apr 6, 2021

Merge pull request openshift#2 from ecordell/basic-registry

256f322

Package cleanup (upstream operator-registry commit: 06f1c06ac03372aa94253fdf6f8fdbb59dfa3a5c)

awgreene added a commit to awgreene/operator-framework-olm that referenced this pull request Jul 1, 2021

This is a combination of 2 commits.

db5f690

This is the 1st commit message: wip This is the commit message openshift#2:

awgreene added a commit to awgreene/operator-framework-olm that referenced this pull request Jul 1, 2021

This is a combination of 2 commits.

b218a31

This is the 1st commit message: wip This is the commit message openshift#2:

awgreene added a commit to awgreene/operator-framework-olm that referenced this pull request Jul 1, 2021

This is a combination of 2 commits.

d69028b

This is the 1st commit message: wip This is the commit message openshift#2:

awgreene added a commit to awgreene/operator-framework-olm that referenced this pull request Jul 1, 2021

This is a combination of 2 commits.

c5b9aa6

This is the 1st commit message: wip This is the commit message openshift#2:

awgreene added a commit to awgreene/operator-framework-olm that referenced this pull request Jul 1, 2021

This is a combination of 2 commits.

84f6049

This is the 1st commit message: wip This is the commit message openshift#2:

awgreene added a commit to awgreene/operator-framework-olm that referenced this pull request Jul 1, 2021

This is a combination of 2 commits.

ca46527

This is the 1st commit message: wip This is the commit message openshift#2:

awgreene added a commit to awgreene/operator-framework-olm that referenced this pull request Jul 1, 2021

This is a combination of 2 commits.

300960a

This is the 1st commit message: wip This is the commit message openshift#2:

Conversation

ankitathomas commented Feb 24, 2021

Uh oh!

timflannagan commented Feb 25, 2021

Uh oh!

timflannagan commented Feb 25, 2021

Uh oh!

timflannagan commented Feb 25, 2021

Uh oh!

timflannagan commented Feb 25, 2021

Uh oh!

timflannagan commented Feb 25, 2021

Uh oh!

timflannagan commented Feb 25, 2021

Uh oh!

openshift-ci-robot commented Feb 25, 2021

Uh oh!

timflannagan commented Feb 25, 2021

Uh oh!

openshift-ci-robot commented Feb 25, 2021

Uh oh!

ankitathomas commented Feb 25, 2021

Uh oh!

openshift-ci-robot commented Feb 25, 2021

Uh oh!

timflannagan Feb 25, 2021

Choose a reason for hiding this comment

Uh oh!

timflannagan Feb 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

timflannagan commented Feb 25, 2021

Uh oh!

openshift-ci-robot commented Feb 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

timflannagan Feb 25, 2021 •

edited

Loading