Skip to content

Bug 2008027: validate olm.bundle.object properties on channel heads#210

Closed
ankitathomas wants to merge 1 commit intoopenshift:masterfrom
ankitathomas:bz2008027
Closed

Bug 2008027: validate olm.bundle.object properties on channel heads#210
ankitathomas wants to merge 1 commit intoopenshift:masterfrom
ankitathomas:bz2008027

Conversation

@ankitathomas
Copy link
Copy Markdown
Contributor

@ankitathomas ankitathomas commented Oct 25, 2021

ensure at a valid csv on olm.bundle.properties to ensure channel is discoverable in packagemanifests and the web console

Signed-off-by: Ankita Thomas ankithom@redhat.com

@ankitathomas
validate olm.bundle.object properties for channel heads
9abdc1f 
ensure at a valid csv on olm.bundle.properties to ensure channel is discoverable in packagemanifests and the web console

Signed-off-by: Ankita Thomas <ankithom@redhat.com>
@openshift-ci openshift-ci Bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Oct 25, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 25, 2021

@ankitathomas: This pull request references Bugzilla bug 2008027, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2008027: validate olm.bundle.object properties on channel heads

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 25, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2021
@joelanford
Copy link
Copy Markdown
Member

joelanford commented Oct 25, 2021

I'm not convinced this is a bug, even considering downstream-only. To me, this is more of a feature request to allow non-required aspects of the index to be included in validation.

We have precedent in openshift/api for optional validators, so perhaps we should hold off on this change, which seems fairly intrusive and hard to maintain if we decide to change anything about the CLI of opm validate.

IMO, we mostly solved this problem already by updating opm render to always include olm.bundle.object properties, so folks would have to go out of their way to remove them.

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2021
@ankitathomas
Copy link
Copy Markdown
Contributor Author

ankitathomas commented Nov 24, 2021

/bugzilla refresh

@openshift-ci openshift-ci Bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 24, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 24, 2021

@ankitathomas: This pull request references Bugzilla bug 2008027, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (xzha@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ankitathomas
Copy link
Copy Markdown
Contributor Author

ankitathomas commented Nov 24, 2021

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 24, 2021

@ankitathomas: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-olm 9abdc1f link true /test e2e-aws-olm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 6, 2021

@ankitathomas: This pull request references Bugzilla bug 2008027. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Bug 2008027: validate olm.bundle.object properties on channel heads

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene pushed a commit to awgreene/operator-framework-olm that referenced this pull request Feb 22, 2022
@camilamacedo86 @awgreene
add bundle size validator check (openshift#210)
61b406c 
* add bundle size validator check

Co-authored-by: Brett Tofel btofel@redhat.com

* applying suggetions - review

* add operator-registry as dep and use gzip method to check bundle size

* go mod vendor

* go fmt

* add enconding to the api

* refac name

Upstream-repository: api
Upstream-commit: e8208e3dcf33173266b49767d774970077f406be
awgreene pushed a commit to awgreene/operator-framework-olm that referenced this pull request Feb 22, 2022
@camilamacedo86 @awgreene
add bundle size validator check (openshift#210)
07785e8 
* add bundle size validator check

Co-authored-by: Brett Tofel btofel@redhat.com

* applying suggetions - review

* add operator-registry as dep and use gzip method to check bundle size

* go mod vendor

* go fmt

* add enconding to the api

* refac name

Upstream-repository: api
Upstream-commit: e8208e3dcf33173266b49767d774970077f406be
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 1, 2022
@camilamacedo86 @perdasilva
add bundle size validator check (openshift#210)
78d72a0 
* add bundle size validator check

Co-authored-by: Brett Tofel btofel@redhat.com

* applying suggetions - review

* add operator-registry as dep and use gzip method to check bundle size

* go mod vendor

* go fmt

* add enconding to the api

* refac name

Upstream-repository: api
Upstream-commit: e8208e3dcf33173266b49767d774970077f406be
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 2, 2022
@camilamacedo86 @perdasilva
add bundle size validator check (openshift#210)
94bdc83 
* add bundle size validator check

Co-authored-by: Brett Tofel btofel@redhat.com

* applying suggetions - review

* add operator-registry as dep and use gzip method to check bundle size

* go mod vendor

* go fmt

* add enconding to the api

* refac name

Upstream-repository: api
Upstream-commit: e8208e3dcf33173266b49767d774970077f406be
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 2, 2022
@camilamacedo86 @perdasilva
add bundle size validator check (openshift#210)
47cf80f 
* add bundle size validator check

Co-authored-by: Brett Tofel btofel@redhat.com

* applying suggetions - review

* add operator-registry as dep and use gzip method to check bundle size

* go mod vendor

* go fmt

* add enconding to the api

* refac name

Upstream-repository: api
Upstream-commit: e8208e3dcf33173266b49767d774970077f406be
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 2, 2022
@camilamacedo86 @perdasilva
add bundle size validator check (openshift#210)
a69e914 
* add bundle size validator check

Co-authored-by: Brett Tofel btofel@redhat.com

* applying suggetions - review

* add operator-registry as dep and use gzip method to check bundle size

* go mod vendor

* go fmt

* add enconding to the api

* refac name

Upstream-repository: api
Upstream-commit: e8208e3dcf33173266b49767d774970077f406be
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@camilamacedo86 @perdasilva
add bundle size validator check (openshift#210)
e176a81 
* add bundle size validator check

Co-authored-by: Brett Tofel btofel@redhat.com

* applying suggetions - review

* add operator-registry as dep and use gzip method to check bundle size

* go mod vendor

* go fmt

* add enconding to the api

* refac name

Upstream-repository: api
Upstream-commit: e8208e3dcf33173266b49767d774970077f406be
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@camilamacedo86 @perdasilva
add bundle size validator check (openshift#210)
75c1c66 
* add bundle size validator check

Co-authored-by: Brett Tofel btofel@redhat.com

* applying suggetions - review

* add operator-registry as dep and use gzip method to check bundle size

* go mod vendor

* go fmt

* add enconding to the api

* refac name

Upstream-repository: api
Upstream-commit: e8208e3dcf33173266b49767d774970077f406be
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@camilamacedo86 @perdasilva
add bundle size validator check (openshift#210)
9376f83 
* add bundle size validator check

Co-authored-by: Brett Tofel btofel@redhat.com

* applying suggetions - review

* add operator-registry as dep and use gzip method to check bundle size

* go mod vendor

* go fmt

* add enconding to the api

* refac name

Upstream-repository: api
Upstream-commit: e8208e3dcf33173266b49767d774970077f406be
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@camilamacedo86 @perdasilva
add bundle size validator check (openshift#210)
93ff1db 
* add bundle size validator check

Co-authored-by: Brett Tofel btofel@redhat.com

* applying suggetions - review

* add operator-registry as dep and use gzip method to check bundle size

* go mod vendor

* go fmt

* add enconding to the api

* refac name

Upstream-repository: api
Upstream-commit: e8208e3dcf33173266b49767d774970077f406be
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@camilamacedo86 @perdasilva
add bundle size validator check (openshift#210)
114ef10 
* add bundle size validator check

Co-authored-by: Brett Tofel btofel@redhat.com

* applying suggetions - review

* add operator-registry as dep and use gzip method to check bundle size

* go mod vendor

* go fmt

* add enconding to the api

* refac name

Upstream-repository: api
Upstream-commit: e8208e3dcf33173266b49767d774970077f406be
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 7, 2022
@camilamacedo86 @perdasilva
add bundle size validator check (openshift#210)
822f0af 
* add bundle size validator check

Co-authored-by: Brett Tofel btofel@redhat.com

* applying suggetions - review

* add operator-registry as dep and use gzip method to check bundle size

* go mod vendor

* go fmt

* add enconding to the api

* refac name

Upstream-repository: api
Upstream-commit: e8208e3dcf33173266b49767d774970077f406be
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 7, 2022
@camilamacedo86 @perdasilva
add bundle size validator check (openshift#210)
770f2ed 
* add bundle size validator check

Co-authored-by: Brett Tofel btofel@redhat.com

* applying suggetions - review

* add operator-registry as dep and use gzip method to check bundle size

* go mod vendor

* go fmt

* add enconding to the api

* refac name

Upstream-repository: api
Upstream-commit: e8208e3dcf33173266b49767d774970077f406be
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 8, 2022
@camilamacedo86 @perdasilva
add bundle size validator check (openshift#210)
c6863b1 
* add bundle size validator check

Co-authored-by: Brett Tofel btofel@redhat.com

* applying suggetions - review

* add operator-registry as dep and use gzip method to check bundle size

* go mod vendor

* go fmt

* add enconding to the api

* refac name

Upstream-repository: api
Upstream-commit: e8208e3dcf33173266b49767d774970077f406be
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 9, 2022
@camilamacedo86 @perdasilva
add bundle size validator check (openshift#210)
8a642dd 
* add bundle size validator check

Co-authored-by: Brett Tofel btofel@redhat.com

* applying suggetions - review

* add operator-registry as dep and use gzip method to check bundle size

* go mod vendor

* go fmt

* add enconding to the api

* refac name

Upstream-repository: api
Upstream-commit: e8208e3dcf33173266b49767d774970077f406be
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 10, 2022
@camilamacedo86 @perdasilva
add bundle size validator check (openshift#210)
fec336a 
* add bundle size validator check

Co-authored-by: Brett Tofel btofel@redhat.com

* applying suggetions - review

* add operator-registry as dep and use gzip method to check bundle size

* go mod vendor

* go fmt

* add enconding to the api

* refac name

Upstream-repository: api
Upstream-commit: e8208e3dcf33173266b49767d774970077f406be
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 10, 2022
@camilamacedo86 @perdasilva
add bundle size validator check (openshift#210)
a16b045 
* add bundle size validator check

Co-authored-by: Brett Tofel btofel@redhat.com

* applying suggetions - review

* add operator-registry as dep and use gzip method to check bundle size

* go mod vendor

* go fmt

* add enconding to the api

* refac name

Upstream-repository: api
Upstream-commit: e8208e3dcf33173266b49767d774970077f406be
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 12, 2022
@camilamacedo86 @perdasilva
add bundle size validator check (openshift#210)
3d6f702 
* add bundle size validator check

Co-authored-by: Brett Tofel btofel@redhat.com

* applying suggetions - review

* add operator-registry as dep and use gzip method to check bundle size

* go mod vendor

* go fmt

* add enconding to the api

* refac name

Upstream-repository: api
Upstream-commit: e8208e3dcf33173266b49767d774970077f406be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gallettilance gallettilance Awaiting requested review from gallettilance

@timflannagan timflannagan Awaiting requested review from timflannagan

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ankitathomas @joelanford