Bug 2024048: Remove outdated subscription update logic to improve resolution delay by dinhxuanvu · Pull Request #215 · openshift/operator-framework-olm

dinhxuanvu · 2021-11-17T06:03:15Z

Currently, olm logic checks for upgrade in subscription via another
obsolete API that is no longer in use for dependency solution. As a
result, sometimes, subscriptions display UpgradeAvailable status but
there will be no upgrades as the upgrade is not valid in the resolver.
Also, the UpgradeAvailable status is used to trigger the new resolution
even though that status is no longer a valid indicator of having a pending
upgrade. This leads to unwanted upgrade delay when the obsolete API works
properly.

This commit will remove the code that is using this obsolete API and
allow the resolution to happen when there is a subscription change.

Signed-off-by: Vu Dinh vudinh@outlook.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 81e7a60bc7a62da4a469041ce89e3867e9f47fde

Currently, olm logic checks for upgrade in subscription via another obsolete API that is no longer in use for dependency solution. As a result, sometimes, subscriptions display `UpgradeAvailable` status but there will be no upgrades as the upgrade is not valid in the resolver. Also, the `UpgradeAvailable` status is used to trigger the new resolution even though that status is no longer a valid indicator of having a pending upgrade. This leads to unwanted upgrade delay when the obsolete API works properly. This commit will remove the code that is using this obsolete API and allow the resolution to happen when there is a subscription change. Signed-off-by: Vu Dinh <vudinh@outlook.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 81e7a60bc7a62da4a469041ce89e3867e9f47fde

openshift-ci · 2021-11-17T06:03:22Z

@dinhxuanvu: This pull request references Bugzilla bug 2024048, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2002276 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2002276 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

Bug 2024048: Remove outdated subscription update logic to improve resolution delay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-11-17T06:03:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dinhxuanvu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kevinrizza · 2021-11-17T15:50:36Z

/lgtm
/label backport-risk-assessed

kevinrizza · 2021-11-17T15:51:17Z

/retest

openshift-bot · 2021-11-17T15:54:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

dinhxuanvu · 2021-11-17T18:33:18Z

/retest

dinhxuanvu · 2021-11-29T16:10:47Z

@jianzhangbjz PTAL

Currently, when resolution happens, every subscription will get updated regardless if there are any changes applied or not. This resolves into unnecessary API update calls. This commit will filter out subscriptions that don't get changed and only changed ones get updated. Note: Remove an additional update API call from one of subscription sync methods as well. Signed-off-by: Vu Dinh <vudinh@outlook.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: e6cc305d49e865020b0d3481b621bf7412fb871a

timflannagan · 2021-12-01T15:59:50Z

/lgtm

openshift-bot · 2021-12-01T19:06:30Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-01T22:06:35Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-02T02:52:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-02T06:31:14Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-12-02T09:07:04Z

@jianzhangbjz: The label(s) /label cherry-pick-approoved cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, backport-risk-assessed, cherry-pick-approved

Details

In response to this:

/label cherry-pick-approoved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-12-02T09:07:15Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

jianzhangbjz · 2021-12-02T09:07:35Z

/label cherry-pick-approved

jianzhangbjz · 2021-12-02T09:08:16Z

Sorry for the late.
/lgtm

openshift-bot · 2021-12-02T12:09:20Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-02T12:35:17Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-02T14:29:32Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-02T15:06:17Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-02T18:16:15Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

dinhxuanvu · 2021-12-02T18:17:53Z

/test e2e-upgrade

openshift-bot · 2021-12-02T18:43:19Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-02T20:39:14Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-12-02T22:38:53Z

@dinhxuanvu: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#215

Bugzilla bug 2024048 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2024048: Remove outdated subscription update logic to improve resolution delay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…mpty (openshift#215) * fix: alm-example parse check should not fail when the annotation if empty * applying review Upstream-repository: api Upstream-commit: 77b398430e0168ac9339d3a1620715d26ab876d2

openshift-ci Bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Nov 17, 2021

openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 17, 2021

openshift-ci Bot requested a review from jianzhangbjz November 17, 2021 06:03

openshift-ci Bot requested review from anik120 and joelanford November 17, 2021 06:03

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2021

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 17, 2021

openshift-ci Bot assigned kevinrizza Nov 17, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2021

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2021

openshift-ci Bot assigned timflannagan Dec 1, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2021

openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 2, 2021

openshift-ci Bot assigned jianzhangbjz Dec 2, 2021

openshift-merge-robot merged commit 5fc4c78 into openshift:release-4.9 Dec 2, 2021

Conversation

dinhxuanvu commented Nov 17, 2021

Uh oh!

openshift-ci Bot commented Nov 17, 2021

Uh oh!

openshift-ci Bot commented Nov 17, 2021

Uh oh!

kevinrizza commented Nov 17, 2021

Uh oh!

kevinrizza commented Nov 17, 2021

Uh oh!

openshift-bot commented Nov 17, 2021

Uh oh!

dinhxuanvu commented Nov 17, 2021

Uh oh!

dinhxuanvu commented Nov 29, 2021

Uh oh!

timflannagan commented Dec 1, 2021

Uh oh!

openshift-bot commented Dec 1, 2021

Uh oh!

openshift-bot commented Dec 1, 2021

Uh oh!

openshift-bot commented Dec 2, 2021

Uh oh!

openshift-bot commented Dec 2, 2021

Uh oh!

openshift-ci Bot commented Dec 2, 2021

Uh oh!

openshift-bot commented Dec 2, 2021

Uh oh!

jianzhangbjz commented Dec 2, 2021

Uh oh!

jianzhangbjz commented Dec 2, 2021

Uh oh!

openshift-bot commented Dec 2, 2021

Uh oh!

openshift-bot commented Dec 2, 2021

Uh oh!

openshift-bot commented Dec 2, 2021

Uh oh!

openshift-bot commented Dec 2, 2021

Uh oh!

openshift-bot commented Dec 2, 2021

Uh oh!

dinhxuanvu commented Dec 2, 2021

Uh oh!

openshift-bot commented Dec 2, 2021

Uh oh!

openshift-bot commented Dec 2, 2021

Uh oh!

openshift-ci Bot commented Dec 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants