Skip to content

[release 4.8] Bug 1998571: Fix channel head identification#221

Closed
ankitathomas wants to merge 2 commits intoopenshift:release-4.8from
ankitathomas:release-4.8-bz1998571
Closed

[release 4.8] Bug 1998571: Fix channel head identification#221
ankitathomas wants to merge 2 commits intoopenshift:release-4.8from
ankitathomas:release-4.8-bz1998571

Conversation

@ankitathomas
Copy link
Copy Markdown
Contributor

@ankitathomas ankitathomas commented Dec 6, 2021

No description provided.

@benluddy @ankitathomas
Explain unique replaces chain requirement in channel sort errors.
17d73d9 
The "multiple channel head" error that can be returned from channel
sorting has been a source of confusion for users. The error message
now explains that a unique replacement chain is required in order to
define the relative order between channel entries, and it also
provides an abbreviated list of all replacement chains identified, in
the form "head...tail" or "singleton".

Signed-off-by: Ben Luddy <bluddy@redhat.com>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 639102545cb6faabe9a1f30970dffca93bfb058a
@benluddy @ankitathomas
Correctly omit skipped channel entries during resolution.
0aee6e1 
A behavior was added with the intention of preventing the installation
of channel entries that are skipped by other entries, but in practice
it was omitting entries that were replaced by skipped entries.

This is fixed. There are now unit test cases and one higher-level test
for this behavior.

Signed-off-by: Ben Luddy <bluddy@redhat.com>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 0bb8c1ea9741071830711e3517f39e264f561154
@openshift-ci openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 6, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 6, 2021

@ankitathomas: This pull request references Bugzilla bug 1998571, which is invalid:

  • expected the bug to target the "4.8.z" release, but it targets "---" instead
  • expected Bugzilla bug 1998571 to depend on a bug targeting a release in 4.9.0, 4.9.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release 4.8] Bug 1998571: Fix channel head identification

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2021
@ankitathomas
Copy link
Copy Markdown
Contributor Author

ankitathomas commented Dec 6, 2021

/bugzilla refresh

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 6, 2021

@ankitathomas: This pull request references Bugzilla bug 1998571, which is invalid:

  • expected Bugzilla bug 1998571 to depend on a bug targeting a release in 4.9.0, 4.9.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 6, 2021

@ankitathomas: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade 0aee6e1 link true /test e2e-upgrade
ci/prow/e2e-aws-console-olm 0aee6e1 link true /test e2e-aws-console-olm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 16, 2021

@ankitathomas: This pull request references Bugzilla bug 1998571. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

[release 4.8] Bug 1998571: Fix channel head identification

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tylerslaton added a commit to tylerslaton/operator-framework-olm that referenced this pull request Jan 27, 2022
@tylerslaton
refactor(constraint): update none compound constraint to be not (open…
0e6e339 
…shift#221)

Signed-off-by: Tyler Slaton <tyslaton@redhat.com>

Upstream-repository: api
Upstream-commit: 96da8f9eb8f5d77bfcc41d05e26753c40b0fa33a
tylerslaton added a commit to tylerslaton/operator-framework-olm that referenced this pull request Jan 27, 2022
@tylerslaton
refactor(constraint): update none compound constraint to be not (open…
7e28ec4 
…shift#221)

Signed-off-by: Tyler Slaton <tyslaton@redhat.com>

Upstream-repository: api
Upstream-commit: 96da8f9eb8f5d77bfcc41d05e26753c40b0fa33a
tylerslaton added a commit to tylerslaton/operator-framework-olm that referenced this pull request Jan 27, 2022
@tylerslaton
refactor(constraint): update none compound constraint to be not (open…
ca684bb 
…shift#221)

Signed-off-by: Tyler Slaton <tyslaton@redhat.com>

Upstream-repository: api
Upstream-commit: 96da8f9eb8f5d77bfcc41d05e26753c40b0fa33a
tylerslaton added a commit to tylerslaton/operator-framework-olm that referenced this pull request Jan 27, 2022
@tylerslaton
refactor(constraint): update none compound constraint to be not (open…
6a95e25 
…shift#221)

Signed-off-by: Tyler Slaton <tyslaton@redhat.com>

Upstream-repository: api
Upstream-commit: 96da8f9eb8f5d77bfcc41d05e26753c40b0fa33a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@tylerslaton @perdasilva
refactor(constraint): update none compound constraint to be not (open…
57a4e64 
…shift#221)

Signed-off-by: Tyler Slaton <tyslaton@redhat.com>

Upstream-repository: api
Upstream-commit: 96da8f9eb8f5d77bfcc41d05e26753c40b0fa33a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@tylerslaton @perdasilva
refactor(constraint): update none compound constraint to be not (open…
fe1b6e0 
…shift#221)

Signed-off-by: Tyler Slaton <tyslaton@redhat.com>

Upstream-repository: api
Upstream-commit: 96da8f9eb8f5d77bfcc41d05e26753c40b0fa33a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@timflannagan timflannagan Awaiting requested review from timflannagan

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ankitathomas @benluddy