Skip to content

Bug 2030489: Remove oudated subscription update logic to improve resolution delay#222

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.8from
dinhxuanvu:upgrade-delay-4.8
Jan 13, 2022
Merged

Bug 2030489: Remove oudated subscription update logic to improve resolution delay#222
openshift-merge-robot merged 1 commit intoopenshift:release-4.8from
dinhxuanvu:upgrade-delay-4.8

Conversation

@dinhxuanvu
Copy link
Copy Markdown
Contributor

@dinhxuanvu dinhxuanvu commented Dec 8, 2021

Currently, olm logic checks for upgrade in subscription via another
obsolete API that is no longer in use for dependency solution. As a
result, sometimes, subscriptions display UpgradeAvailable status but
there will be no upgrades as the upgrade is not valid in the resolver.
Also, the UpgradeAvailable status is used to trigger the new resolution
even though that status is no longer a valid indicator of having a pending
upgrade. This leads to unwanted upgrade delay when the obsolete API works
properly.

This commit will remove the code that is using this obsolete API and
allow the resolution to happen when there is a subscription change.

Signed-off-by: Vu Dinh vudinh@outlook.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 81e7a60bc7a62da4a469041ce89e3867e9f47fde

@dinhxuanvu
Remove oudated subscription update logic to improve resolution delay
a99e947 
Currently, olm logic checks for upgrade in subscription via another
obsolete API that is no longer in use for dependency solution. As a
result, sometimes, subscriptions display `UpgradeAvailable` status but
there will be no upgrades as the upgrade is not valid in the resolver.
Also, the `UpgradeAvailable` status is used to trigger the new resolution
even though that status is no longer a valid indicator of having a pending
upgrade. This leads to unwanted upgrade delay when the obsolete API works
properly.

This commit will remove the code that is using this obsolete API and
allow the resolution to happen when there is a subscription change.

Signed-off-by: Vu Dinh <vudinh@outlook.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 81e7a60bc7a62da4a469041ce89e3867e9f47fde
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 8, 2021

@dinhxuanvu: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Remove oudated subscription update logic to improve resolution delay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2021
@dinhxuanvu dinhxuanvu changed the title Remove oudated subscription update logic to improve resolution delay Bug 2030489: Remove oudated subscription update logic to improve resolution delay Dec 8, 2021
@openshift-ci openshift-ci Bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Dec 8, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 8, 2021

@dinhxuanvu: This pull request references Bugzilla bug 2030489, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2024048 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2024048 targets the "4.9.z" release, which is one of the valid target releases: 4.9.0, 4.9.z
  • bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

Bug 2030489: Remove oudated subscription update logic to improve resolution delay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 8, 2021
@openshift-ci openshift-ci Bot requested a review from jianzhangbjz December 8, 2021 22:56
timflannagan
timflannagan reviewed Dec 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@timflannagan timflannagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to also pull in 093e248, or is that not an issue with the 4.8 release?

@dinhxuanvu
Copy link
Copy Markdown
Contributor Author

dinhxuanvu commented Dec 10, 2021

/retest

@dinhxuanvu
Copy link
Copy Markdown
Contributor Author

dinhxuanvu commented Dec 10, 2021

@timflannagan I didn't include that commit because that issue is not in 4.8.

@timflannagan
Copy link
Copy Markdown
Contributor

timflannagan commented Dec 10, 2021

/retest
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2021
@jianzhangbjz
Copy link
Copy Markdown
Contributor

jianzhangbjz commented Jan 13, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 13, 2022
@kevinrizza
Copy link
Copy Markdown
Member

kevinrizza commented Jan 13, 2022

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 13, 2022
@openshift-merge-robot openshift-merge-robot merged commit b3aabf2 into openshift:release-4.8 Jan 13, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 13, 2022

@dinhxuanvu: All pull requests linked via external trackers have merged:

Bugzilla bug 2030489 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2030489: Remove oudated subscription update logic to improve resolution delay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene pushed a commit to awgreene/operator-framework-olm that referenced this pull request Feb 22, 2022
@camilamacedo86 @awgreene
add some extra clarifications (openshift#222)
8a57a84 
Upstream-repository: api
Upstream-commit: 2e47b5a3bedaab35db362dff3ecb56133af16af7
awgreene pushed a commit to awgreene/operator-framework-olm that referenced this pull request Feb 22, 2022
@camilamacedo86 @awgreene
add some extra clarifications (openshift#222)
0095888 
Upstream-repository: api
Upstream-commit: 2e47b5a3bedaab35db362dff3ecb56133af16af7
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 1, 2022
@camilamacedo86 @perdasilva
add some extra clarifications (openshift#222)
8ac3ebe 
Upstream-repository: api
Upstream-commit: 2e47b5a3bedaab35db362dff3ecb56133af16af7
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 2, 2022
@camilamacedo86 @perdasilva
add some extra clarifications (openshift#222)
f5107e4 
Upstream-repository: api
Upstream-commit: 2e47b5a3bedaab35db362dff3ecb56133af16af7
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 2, 2022
@camilamacedo86 @perdasilva
add some extra clarifications (openshift#222)
c3d20f1 
Upstream-repository: api
Upstream-commit: 2e47b5a3bedaab35db362dff3ecb56133af16af7
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 2, 2022
@camilamacedo86 @perdasilva
add some extra clarifications (openshift#222)
f3511b5 
Upstream-repository: api
Upstream-commit: 2e47b5a3bedaab35db362dff3ecb56133af16af7
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@camilamacedo86 @perdasilva
add some extra clarifications (openshift#222)
81429f6 
Upstream-repository: api
Upstream-commit: 2e47b5a3bedaab35db362dff3ecb56133af16af7
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@camilamacedo86 @perdasilva
add some extra clarifications (openshift#222)
7fcb5b1 
Upstream-repository: api
Upstream-commit: 2e47b5a3bedaab35db362dff3ecb56133af16af7
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@camilamacedo86 @perdasilva
add some extra clarifications (openshift#222)
5efa7c9 
Upstream-repository: api
Upstream-commit: 2e47b5a3bedaab35db362dff3ecb56133af16af7
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@camilamacedo86 @perdasilva
add some extra clarifications (openshift#222)
4068060 
Upstream-repository: api
Upstream-commit: 2e47b5a3bedaab35db362dff3ecb56133af16af7
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@camilamacedo86 @perdasilva
add some extra clarifications (openshift#222)
009b9e1 
Upstream-repository: api
Upstream-commit: 2e47b5a3bedaab35db362dff3ecb56133af16af7
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 7, 2022
@camilamacedo86 @perdasilva
add some extra clarifications (openshift#222)
41f3cc5 
Upstream-repository: api
Upstream-commit: 2e47b5a3bedaab35db362dff3ecb56133af16af7
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 7, 2022
@camilamacedo86 @perdasilva
add some extra clarifications (openshift#222)
75eb462 
Upstream-repository: api
Upstream-commit: 2e47b5a3bedaab35db362dff3ecb56133af16af7
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 8, 2022
@camilamacedo86 @perdasilva
add some extra clarifications (openshift#222)
5b629f7 
Upstream-repository: api
Upstream-commit: 2e47b5a3bedaab35db362dff3ecb56133af16af7
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 9, 2022
@camilamacedo86 @perdasilva
add some extra clarifications (openshift#222)
093fe14 
Upstream-repository: api
Upstream-commit: 2e47b5a3bedaab35db362dff3ecb56133af16af7
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 10, 2022
@camilamacedo86 @perdasilva
add some extra clarifications (openshift#222)
5bd1c61 
Upstream-repository: api
Upstream-commit: 2e47b5a3bedaab35db362dff3ecb56133af16af7
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 10, 2022
@camilamacedo86 @perdasilva
add some extra clarifications (openshift#222)
1dce27c 
Upstream-repository: api
Upstream-commit: 2e47b5a3bedaab35db362dff3ecb56133af16af7
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 12, 2022
@camilamacedo86 @perdasilva
add some extra clarifications (openshift#222)
8c30523 
Upstream-repository: api
Upstream-commit: 2e47b5a3bedaab35db362dff3ecb56133af16af7
@sferich888
Copy link
Copy Markdown

sferich888 commented Aug 24, 2022

/cherry-pick release-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 24, 2022
Closed
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Aug 24, 2022

@sferich888: new pull request created: #373

Details

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

1 more reviewer

@timflannagan timflannagan timflannagan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@timflannagan timflannagan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dinhxuanvu @timflannagan @jianzhangbjz @kevinrizza @sferich888 @openshift-cherrypick-robot @openshift-merge-robot