Fix install_kubebuilder.sh script by perdasilva · Pull Request #258 · openshift/operator-framework-olm

perdasilva · 2022-03-02T11:20:31Z

Signed-off-by: perdasilva perdasilva@redhat.com

The install_kubebuilder.sh script no longer seems to be working:

 % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    67  100    67    0     0    151      0 --:--:-- --:--:-- --:--:--   151
100 21145  100 21145    0     0  42496      0 --:--:-- --:--:-- --:--:-- 42496

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now
Kubebuilder installation complete!
Run the following locally to ensure kubebuilder is added to $PATH
export PATH=/home/perdasilva/sdk/go1.17.7/bin:/home/perdasilva/sdk/go1.16.14/bin:/home/perdasilva/go/bin:/home/perdasilva/bin:/home/perdasilva/miniconda3/bin:/home/perdasilva/.crc/bin/oc:/home/perdasilva/go/go1.17.6/bin:/usr/local/go/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin:/var/lib/snapd/snap/bin:/usr/local/kubebuilder/bin

It seems https://go.kubebuilder.io/releases/2.3.1/linux/amd64 no longer points to the 2.3.1 release, or is down.

This PR updates the script to download the release directly from github.

After fix:

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   675  100   675    0     0   2454      0 --:--:-- --:--:-- --:--:--  2454
100 54.8M  100 54.8M    0     0  1769k      0  0:00:31  0:00:31 --:--:-- 1731k
mv: cannot create directory '/usr/local/kubebuilder': Permission denied  # <- Expected download and untaring works ^^

$ find /tmp/kubebuilder_2.3.1_linux_amd64/                                                                                              Wed 02 Mar 2022 12:24:50
/tmp/kubebuilder_2.3.1_linux_amd64/
/tmp/kubebuilder_2.3.1_linux_amd64/bin
/tmp/kubebuilder_2.3.1_linux_amd64/bin/kubebuilder
/tmp/kubebuilder_2.3.1_linux_amd64/bin/kubectl
/tmp/kubebuilder_2.3.1_linux_amd64/bin/kube-apiserver
/tmp/kubebuilder_2.3.1_linux_amd64/bin/etcd

perdasilva · 2022-03-02T11:22:58Z

This is breaking the release CI
PR: openshift/release#26675
Logs: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/26675/rehearse-26675-pull-ci-openshift-operator-framework-olm-master-unit-olm/1498970716974878720****

fgiloux · 2022-03-02T12:10:15Z

https://go.kubebuilder.io/dl seems to be redirected to https://github.com/kubernetes-sigs/kubebuilder/releases
https://go.kubebuilder.io/dl/latest/linux/amd64 seems to be a valid link but not https://go.kubebuilder.io/dl/2.3.1/linux/amd64 or https://go.kubebuilder.io/dl/v2.3.1/linux/amd64
cc @camilamacedo86 as she should know.

perdasilva · 2022-03-02T12:27:57Z

overriding things to get this merged asap to unblock the downstream sync. We can revert this later should the link start working again.

perdasilva · 2022-03-02T12:29:15Z

/override ci/prow/e2e-aws-console-olm
/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-gcp
/override ci/prow/e2e-upgrade

~~Edit: lol, I guess I cannot....~~
Edit: I guess I can

openshift-ci · 2022-03-02T12:31:19Z

@perdasilva: Overrode contexts on behalf of perdasilva: ci/prow/e2e-aws-console-olm, ci/prow/e2e-aws-olm, ci/prow/e2e-gcp, ci/prow/e2e-upgrade

Details

In response to this:

/override ci/prow/e2e-upgrade
/override ci/prow/e2e-aws-console-olm
/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-03-02T12:32:28Z

/label lgtm

openshift-ci · 2022-03-02T12:32:30Z

@perdasilva: The label(s) /label lgtm cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, backport-risk-assessed, cherry-pick-approved

Details

In response to this:

/label lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-03-02T12:33:03Z

/lgtm

openshift-ci · 2022-03-02T12:33:03Z

@perdasilva: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2022-03-02T12:33:20Z

@perdasilva: you cannot LGTM your own PR.

Damn you, robot!!!

Signed-off-by: perdasilva <perdasilva@redhat.com>

camilamacedo86 · 2022-03-02T13:17:39Z

@fgiloux @perdasilva

https://go.kubebuilder.io/dl seems to be redirected to https://github.com/kubernetes-sigs/kubebuilder/releases
https://go.kubebuilder.io/dl/latest/linux/amd64 seems to be a valid link but not https://go.kubebuilder.io/dl/2.3.1/linux/amd64 or https://go.kubebuilder.io/dl/v2.3.1/linux/amd64
cc @camilamacedo86 as she should know.

Why would we need to install KB releases < v3.0.0 such as 2.3.1? If we need the scaffold used before < v3.0.0 then we can. use go/v2 plugin instead of go/v3.

I do not see any reason for we use any version < v3.0.0 so if the changes work from v3.0.0 that shows fine for me.

perdasilva · 2022-03-02T13:22:24Z

@camilamacedo86 At the moment this is just blocking a CI job. I could update to > 3.0.0 as a separate issue. Could we get this one through to unblock me, then I'll put up another one testing out > 3.0.0?

gallettilance · 2022-03-02T13:24:32Z

@@ -8,13 +8,18 @@ KUBEBUILDER_BIN=${KUBEBUILDER_BIN:=/usr/local/kubebuilder}
 OS=$(go env GOOS)
 ARCH=$(go env GOARCH)
 KUBEBUILDER_RELEASE=2.3.1


this URL change is only valid for 3.0.0+ so this line would need to change. https://github.com/kubernetes-sigs/kubebuilder/releases/download/v3.3.0/kubebuilder_linux_amd64 works but for 2.3.1 it's https://github.com/kubernetes-sigs/kubebuilder/releases/download/v2.3.1/kubebuilder_2.3.1_linux_amd64.tar.gz (an extra version in the name + the tar.gz

Yeah, that's basically the change I've made. I've put a note to say that from 3.0.0+ the url wouldn't work. This is to unblock CI. Once this is through I can look at upping the version to 3.0.0 as a different issue. wdyt?

The URL @perdasilva is using seems to work as it is, the new format for 3.0.0+ versions is commented out.

gallettilance

/lgtm

openshift-ci · 2022-03-02T13:32:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gallettilance, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [gallettilance,perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

perdasilva · 2022-03-02T13:54:30Z

/override ci/prow/e2e-aws-console-olm
/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-gcp
/override ci/prow/e2e-upgrade

openshift-ci · 2022-03-02T13:59:07Z

@perdasilva: Overrode contexts on behalf of perdasilva: ci/prow/e2e-aws-console-olm, ci/prow/e2e-aws-olm, ci/prow/e2e-gcp, ci/prow/e2e-upgrade

Details

In response to this:

/override ci/prow/e2e-aws-console-olm
/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-gcp
/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-03-02T14:02:20Z

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: Jordan <jordan@nimblewidget.com> Signed-off-by: Jordan <jordan@nimblewidget.com> Upstream-repository: api Upstream-commit: 7339a22050af53df7b6f97a652b8e2d73698765a

openshift-ci Bot requested review from benluddy and joelanford March 2, 2022 11:21

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022

perdasilva force-pushed the fix_kubebuilder_install branch from 0b03f20 to 3b0cc11 Compare March 2, 2022 11:29

Fix install_kubebuilder.sh script

59947b9

Signed-off-by: perdasilva <perdasilva@redhat.com>

perdasilva force-pushed the fix_kubebuilder_install branch from 3b0cc11 to 59947b9 Compare March 2, 2022 12:53

gallettilance reviewed Mar 2, 2022

View reviewed changes

gallettilance approved these changes Mar 2, 2022

View reviewed changes

openshift-ci Bot assigned gallettilance Mar 2, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2022

openshift-merge-robot merged commit 198d00f into openshift:master Mar 2, 2022

timflannagan mentioned this pull request Apr 12, 2022

ci-operator: Rebalance OLM's e2e-upgrade 4.11+ jobs to aws openshift/release#27773

Merged

Conversation

perdasilva commented Mar 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

perdasilva commented Mar 2, 2022

Uh oh!

fgiloux commented Mar 2, 2022

Uh oh!

perdasilva commented Mar 2, 2022

Uh oh!

perdasilva commented Mar 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Mar 2, 2022

Uh oh!

perdasilva commented Mar 2, 2022

Uh oh!

openshift-ci Bot commented Mar 2, 2022

Uh oh!

perdasilva commented Mar 2, 2022

Uh oh!

openshift-ci Bot commented Mar 2, 2022

Uh oh!

perdasilva commented Mar 2, 2022

Uh oh!

camilamacedo86 commented Mar 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

perdasilva commented Mar 2, 2022

Uh oh!

gallettilance Mar 2, 2022

Choose a reason for hiding this comment

Uh oh!

perdasilva Mar 2, 2022

Choose a reason for hiding this comment

Uh oh!

awgreene Mar 2, 2022

Choose a reason for hiding this comment

Uh oh!

gallettilance left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Mar 2, 2022

Uh oh!

perdasilva commented Mar 2, 2022

Uh oh!

openshift-ci Bot commented Mar 2, 2022

Uh oh!

openshift-ci Bot commented Mar 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

perdasilva commented Mar 2, 2022 •

edited

Loading

perdasilva commented Mar 2, 2022 •

edited

Loading

camilamacedo86 commented Mar 2, 2022 •

edited

Loading