Skip to content

[release-4.7] Bug 2073964: Fix a bug in deletion of webhook service for replacement#282

Closed
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.7from
openshift-cherrypick-robot:cherry-pick-272-to-release-4.7
Closed

[release-4.7] Bug 2073964: Fix a bug in deletion of webhook service for replacement#282
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.7from
openshift-cherrypick-robot:cherry-pick-272-to-release-4.7

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Apr 11, 2022

This is an automated cherry-pick of #272

/assign perdasilva

@orenc1
Fix a bug in deletion of webhook service for replacement (#2606)
1159c53 
The condition that checks for an error with the webhook service deletion is based on the wrong variable, and the return statement is never reached, which leads to a continuous error when OLM tries to replace the webhook service on certain conditions

Signed-off-by: orenc1 <ocohen@redhat.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: e9aef37a1f293bbbf833206f2037a2f36ffe2673
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 11, 2022
Merged
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 11, 2022

@openshift-cherrypick-robot: Bugzilla bug 2070131 has been cloned as Bugzilla bug 2073964. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 2073964: Fix a bug in deletion of webhook service for replacement

Details

In response to this:

[release-4.7] Bug 2070131: Fix a bug in deletion of webhook service for replacement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot changed the title [release-4.7] Bug 2070131: Fix a bug in deletion of webhook service for replacement [release-4.7] Bug 2073964: Fix a bug in deletion of webhook service for replacement Apr 11, 2022
@openshift-ci openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 11, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 11, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2073964, which is invalid:

  • expected dependent Bugzilla bug 2070131 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead
  • expected dependent Bugzilla bug 2070131 to target a release in 4.8.0, 4.8.z, but it targets "4.10.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.7] Bug 2073964: Fix a bug in deletion of webhook service for replacement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 11, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign kevinrizza after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevinrizza in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Apr 11, 2022

/bugzilla refresh

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 11, 2022

@perdasilva: This pull request references Bugzilla bug 2073964, which is invalid:

  • expected dependent Bugzilla bug 2070131 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 2073966 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
  • expected dependent Bugzilla bug 2073967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
  • expected dependent Bugzilla bug 2070131 to target a release in 4.8.0, 4.8.z, but it targets "4.10.z" instead
  • expected dependent Bugzilla bug 2073966 to target a release in 4.8.0, 4.8.z, but it targets "4.6.z" instead
  • expected dependent Bugzilla bug 2073967 to target a release in 4.8.0, 4.8.z, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Apr 11, 2022

/bugzilla refresh

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 11, 2022

@perdasilva: This pull request references Bugzilla bug 2073964, which is invalid:

  • expected dependent Bugzilla bug 2073966 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is NEW instead
  • expected dependent Bugzilla bug 2073967 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 2070131 to target a release in 4.8.0, 4.8.z, but it targets "4.10.z" instead
  • expected dependent Bugzilla bug 2073966 to target a release in 4.8.0, 4.8.z, but it targets "4.6.z" instead
  • expected dependent Bugzilla bug 2073967 to target a release in 4.8.0, 4.8.z, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Apr 11, 2022

/close

@openshift-ci openshift-ci Bot closed this Apr 11, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 11, 2022

@perdasilva: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 11, 2023
@m1kola @tmshort
New condition types (openshift#282)
35328fa 
* Adds BundleLookupFailed condition type

It was previously defined and used in the operator codebase.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>

* Adds new Subscription condition types

These conditions will be used to indicate unpack status on the subscription level.

Previously unpack status was indicated on the InstallPlan, but since we now
want to prevent InstallPlan from being created in a case of unpack job failure
we need to indicate unpack job failures in Subscription conditions.

---------

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Upstream-repository: api
Upstream-commit: de0138f9c02444413a5878c6dc770cff7a51e19f
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 17, 2023
@m1kola @tmshort
New condition types (openshift#282)
4c6897d 
* Adds BundleLookupFailed condition type

It was previously defined and used in the operator codebase.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>

* Adds new Subscription condition types

These conditions will be used to indicate unpack status on the subscription level.

Previously unpack status was indicated on the InstallPlan, but since we now
want to prevent InstallPlan from being created in a case of unpack job failure
we need to indicate unpack job failures in Subscription conditions.

---------

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Upstream-repository: api
Upstream-commit: de0138f9c02444413a5878c6dc770cff7a51e19f
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 20, 2023
@m1kola @tmshort
New condition types (openshift#282)
d8ce125 
* Adds BundleLookupFailed condition type

It was previously defined and used in the operator codebase.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>

* Adds new Subscription condition types

These conditions will be used to indicate unpack status on the subscription level.

Previously unpack status was indicated on the InstallPlan, but since we now
want to prevent InstallPlan from being created in a case of unpack job failure
we need to indicate unpack job failures in Subscription conditions.

---------

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Upstream-repository: api
Upstream-commit: de0138f9c02444413a5878c6dc770cff7a51e19f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@timflannagan timflannagan Awaiting requested review from timflannagan

Assignees

@perdasilva perdasilva

Labels

bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openshift-cherrypick-robot @perdasilva @orenc1