Identify fail forward in csvSources (#2743)#290
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom Apr 19, 2022
Merged
Identify fail forward in csvSources (#2743)#290openshift-merge-robot merged 2 commits intoopenshift:masterfrom
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
This commit undos changes to the Resolve and ResolveSteps methods and updats the csvSourceProvider to infer whether or not fail forward is enabled in a namespace. Signed-off-by: Alexander Greene <greene.al1991@gmail.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 462ce61fb6b0ac4e5c623d173bd38fed18b6468f
tylerslaton
approved these changes
Apr 18, 2022
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, tylerslaton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
The broken replacement chain unit test occasionally fails because it is possible for either the a.v1 or a.v2 operators to cause the resolver to fail. This commit updates the test to check that the resolver fails because a csv is in the failed state versus checking that a specific csv is in the failed state. Signed-off-by: Alexander Greene <greene.al1991@gmail.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: c36183ef17f757dbf1f96a2619a2a91184afc579
Contributor
Author
|
/retest |
2 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
timflannagan
approved these changes
Apr 18, 2022
Contributor
|
@awgreene: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
/lgtm |
stevekuznetsov
pushed a commit
to stevekuznetsov/operator-framework-olm
that referenced
this pull request
Aug 16, 2023
…t#290) Fixes path join issue Signed-off-by: Todd Short <todd.short@me.com> Upstream-repository: api Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
added a commit
to stevekuznetsov/operator-framework-olm
that referenced
this pull request
Aug 17, 2023
…t#290) Fixes path join issue Signed-off-by: Todd Short <todd.short@me.com> Signed-off-by: Steve Kuznetsov <skuznets@redhat.com> Upstream-repository: api Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
stevekuznetsov
pushed a commit
to stevekuznetsov/operator-framework-olm
that referenced
this pull request
Aug 17, 2023
…t#290) Fixes path join issue Signed-off-by: Todd Short <todd.short@me.com> Signed-off-by: Steve Kuznetsov <skuznets@redhat.com> Upstream-repository: api Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
stevekuznetsov
pushed a commit
to stevekuznetsov/operator-framework-olm
that referenced
this pull request
Aug 17, 2023
…t#290) Fixes path join issue Signed-off-by: Todd Short <todd.short@me.com> Signed-off-by: Steve Kuznetsov <skuznets@redhat.com> Upstream-repository: api Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
pushed a commit
to stevekuznetsov/operator-framework-olm
that referenced
this pull request
Aug 17, 2023
…t#290) Fixes path join issue Signed-off-by: Todd Short <todd.short@me.com> Signed-off-by: Steve Kuznetsov <skuznets@redhat.com> Upstream-repository: api Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
simonpasquier
pushed a commit
to simonpasquier/operator-framework-olm
that referenced
this pull request
Aug 24, 2023
…t#290) Fixes path join issue Signed-off-by: Todd Short <todd.short@me.com> Upstream-repository: api Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
openshift-bot
pushed a commit
to openshift-bot/operator-framework-olm
that referenced
this pull request
Sep 9, 2023
…t#290) Fixes path join issue Signed-off-by: Todd Short <todd.short@me.com> Upstream-repository: api Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
openshift-bot
pushed a commit
to openshift-bot/operator-framework-olm
that referenced
this pull request
Sep 14, 2023
…t#290) Fixes path join issue Signed-off-by: Todd Short <todd.short@me.com> Upstream-repository: api Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
openshift-bot
pushed a commit
to openshift-bot/operator-framework-olm
that referenced
this pull request
Sep 15, 2023
…t#290) Fixes path join issue Signed-off-by: Todd Short <todd.short@me.com> Upstream-repository: api Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
openshift-bot
pushed a commit
to openshift-bot/operator-framework-olm
that referenced
this pull request
Sep 19, 2023
…t#290) Fixes path join issue Signed-off-by: Todd Short <todd.short@me.com> Upstream-repository: api Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
stevekuznetsov
pushed a commit
to stevekuznetsov/operator-framework-olm
that referenced
this pull request
Sep 22, 2023
…t#290) Fixes path join issue Signed-off-by: Todd Short <todd.short@me.com> Upstream-repository: api Upstream-commit: 775e6c6534b89dde01826627ceb570c16ab6768f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit undos changes to the Resolve and ResolveSteps methods and
updats the csvSourceProvider to infer whether or not fail forward is
enabled in a namespace.
Signed-off-by: Alexander Greene greene.al1991@gmail.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 462ce61fb6b0ac4e5c623d173bd38fed18b6468f