Bug 2074612: Fix GRPC CheckRegistryServer function (#2756) by awgreene · Pull Request #294 · openshift/operator-framework-olm

awgreene · 2022-04-29T14:17:48Z

Problem: The CheckRegistryServer function used by grpc catalogSources
does not confirm that the serviceAccount associated with the
catalogSource exists.

Solution: Update the GRPC CheckRegistryServer function to check if the
serviceAccount exists.

Signed-off-by: Alexander Greene greene.al1991@gmail.com

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 7e8e9f77d08d1bf451ce61b7bb2610473e793ded

Problem: The CheckRegistryServer function used by grpc catalogSources does not confirm that the serviceAccount associated with the catalogSource exists. Solution: Update the GRPC CheckRegistryServer function to check if the serviceAccount exists. Signed-off-by: Alexander Greene <greene.al1991@gmail.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 7e8e9f77d08d1bf451ce61b7bb2610473e793ded

openshift-ci · 2022-04-29T14:18:05Z

@awgreene: This pull request references Bugzilla bug 2074612, which is invalid:

expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2074612: Fix GRPC CheckRegistryServer function (#2756)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2022-04-29T14:19:56Z

/bugzilla refresh

openshift-ci · 2022-04-29T14:20:04Z

@awgreene: This pull request references Bugzilla bug 2074612, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-04-29T14:26:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [awgreene,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

awgreene · 2022-04-29T14:26:29Z

/cherry-pick 4.10

openshift-cherrypick-robot · 2022-04-29T14:26:30Z

@awgreene: once the present PR merges, I will cherry-pick it on top of 4.10 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2022-04-29T16:20:24Z

/retest

awgreene · 2022-04-29T18:06:50Z

/retest

awgreene · 2022-04-29T19:52:00Z

/retest

openshift-bot · 2022-04-29T22:23:16Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-30T02:59:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-30T03:47:14Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-30T11:13:16Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-04-30T11:25:15Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-04-30T12:52:16Z

@awgreene: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-04-30T12:54:12Z

@awgreene: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#294

Bugzilla bug 2074612 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2074612: Fix GRPC CheckRegistryServer function (#2756)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-04-30T12:54:54Z

@awgreene: cannot checkout 4.10: error checking out 4.10: exit status 1. output: error: pathspec '4.10' did not match any file(s) known to git

Details

In response to this:

/cherry-pick 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2022-04-30T13:06:06Z

/cherry-pick release-4.10

openshift-cherrypick-robot · 2022-04-30T13:06:44Z

@awgreene: new pull request created: #296

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

timflannagan · 2022-05-02T13:48:19Z

+	serviceAccountName := source.ServiceAccount().GetName()
+	serviceAccount, err := c.Lister.CoreV1().ServiceAccountLister().ServiceAccounts(source.GetNamespace()).Get(serviceAccountName)
+	if err != nil {
+		logrus.WithField("service", serviceAccount).Debug("couldn't find service in cache")


Do we need to pull in the #297 commit as well here?

Disregard - wrong PR (:laughing:)

Addressed in #298

awgreene · 2022-05-02T14:12:16Z

/cherry-pick release-4.10

openshift-cherrypick-robot · 2022-05-02T14:13:00Z

@awgreene: new pull request could not be created: failed to create pull request against openshift/operator-framework-olm#release-4.10 from head openshift-cherrypick-robot:cherry-pick-294-to-release-4.10: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-294-to-release-4.10."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com> Upstream-repository: api Upstream-commit: bb012a3b9b2573023a6cee00c0ea2badb413022e

openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 29, 2022

openshift-ci Bot requested review from ankitathomas and joelanford April 29, 2022 14:18

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2022

openshift-ci Bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 29, 2022

openshift-ci Bot requested a review from jianzhangbjz April 29, 2022 14:20

timflannagan approved these changes Apr 29, 2022

View reviewed changes

openshift-ci Bot assigned timflannagan Apr 29, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2022

openshift-merge-robot merged commit 367e399 into openshift:master Apr 30, 2022

openshift-cherrypick-robot mentioned this pull request Apr 30, 2022

[release-4.10] Bug 2080609: Fix GRPC CheckRegistryServer function (#2756) #296

Closed

timflannagan reviewed May 2, 2022

View reviewed changes

openshift-bot mentioned this pull request Sep 9, 2023

Synchronize From Upstream Repositories #562

Closed

Conversation

awgreene commented Apr 29, 2022

Uh oh!

openshift-ci Bot commented Apr 29, 2022

Uh oh!

awgreene commented Apr 29, 2022

Uh oh!

openshift-ci Bot commented Apr 29, 2022

Uh oh!

openshift-ci Bot commented Apr 29, 2022

Uh oh!

awgreene commented Apr 29, 2022

Uh oh!

openshift-cherrypick-robot commented Apr 29, 2022

Uh oh!

awgreene commented Apr 29, 2022

Uh oh!

awgreene commented Apr 29, 2022

Uh oh!

awgreene commented Apr 29, 2022

Uh oh!

openshift-bot commented Apr 29, 2022

Uh oh!

openshift-bot commented Apr 30, 2022

Uh oh!

openshift-bot commented Apr 30, 2022

Uh oh!

openshift-bot commented Apr 30, 2022

Uh oh!

openshift-bot commented Apr 30, 2022

Uh oh!

openshift-ci Bot commented Apr 30, 2022

Uh oh!

openshift-ci Bot commented Apr 30, 2022

Uh oh!

openshift-cherrypick-robot commented Apr 30, 2022

Uh oh!

awgreene commented Apr 30, 2022

Uh oh!

openshift-cherrypick-robot commented Apr 30, 2022

Uh oh!

timflannagan May 2, 2022

Choose a reason for hiding this comment

Uh oh!

timflannagan May 2, 2022

Choose a reason for hiding this comment

Uh oh!

awgreene May 2, 2022

Choose a reason for hiding this comment

Uh oh!

awgreene commented May 2, 2022

Uh oh!

openshift-cherrypick-robot commented May 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants