Conversation
Problem: The getMetricsFromPod function assumes that metrics are exposed on port 8080. This function fails to retrieve metrics from the olm or catalog operator when the port is changed. Solution: Name the port in each of the deployments and update the getMetricsFromPod function to infer the port number from the deployments. Signed-off-by: Alexander Greene <greene.al1991@gmail.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 08a1d4b2f06fda1a6d6b4cadf779e1ce2259af3e
Signed-off-by: Josef Karasek <jkarasek@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: de4bebe06ba076f804d28c594d7dc52dfd95ef20
Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 33b081aca79dcfc33895a5c114976c4f284f027f
|
@anik120: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
timflannagan
left a comment
timflannagan
left a comment
There was a problem hiding this comment.
Do we need to backport this to 4.7? IIRC the upstream repository is still responsible for building the 4.6 and 4.7 release branches?
Oh whoops: I just saw your slack message so it sounds like you already know this 😆 |
|
Yes apologies totally slipped my mind that 4.7 is being built from the upstream repository. I've opened the backport PR here. Closing this one. |
4 participants
4.7 Backport of #288