Bug 2115874: fix(grpc): Add startupProbe to check for grpc health readiness (#2791)#348
Conversation
|
@dinhxuanvu: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
dinhxuanvu
changed the title
|
/bugzilla refresh |
openshift-ci
Bot
added
bugzilla/severity-high
|
@dinhxuanvu: This pull request references Bugzilla bug 2115874, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dinhxuanvu: This pull request references Bugzilla bug 2115874, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Looks like legitimate failues: /hold |
openshift-ci
Bot
added
the
do-not-merge/hold
dinhxuanvu
force-pushed
the
startupprobe-4.10
branch
from
4345584 to
da35673
Compare
Currently, liveness and readiness probes may fail due to grpc is not ready. Adding a startupProbe will ensure grpc is ready before liveness and readiness probes are triggered. Upstream-repository: operator-lifecycle-manager Upstream-commit: 8987522f97ea3726b42ce6fe23ce5aa75efa83ba Signed-off-by: Vu Dinh <vudinh@outlook.com>
dinhxuanvu
force-pushed
the
startupprobe-4.10
branch
from
da35673 to
6d199ac
Compare
|
Looks like the build failures are now passing again. /hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
/retest |
|
LGTM, details: https://bugzilla.redhat.com/show_bug.cgi?id=2115874#c1 |
openshift-ci
Bot
added
qe-approved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/lgtm |
|
/label backport-risk-assessed |
openshift-ci
Bot
added
the
backport-risk-assessed
|
/retest |
6 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
@dinhxuanvu: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@dinhxuanvu: All pull requests linked via external trackers have merged: Bugzilla bug 2115874 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
Currently, liveness and readiness probes may fail due to grpc is not
ready. Adding a startupProbe will ensure grpc is ready before
liveness and readiness probes are triggered.
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 8987522f97ea3726b42ce6fe23ce5aa75efa83ba
Signed-off-by: Vu Dinh vudinh@outlook.com