Skip to content

Add client certificate and key to service monitor#350

Closed
xueqzhan wants to merge 1 commit intoopenshift:masterfrom
xueqzhan:client-cert-service-monitor
Closed

Add client certificate and key to service monitor#350
xueqzhan wants to merge 1 commit intoopenshift:masterfrom
xueqzhan:client-cert-service-monitor

Conversation

@xueqzhan
Copy link
Copy Markdown

@xueqzhan xueqzhan commented Aug 8, 2022

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 8, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xueqzhan
Once this PR has been reviewed and has the lgtm label, please assign hasbro17 for approval by writing /assign @hasbro17 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 8, 2022

@xueqzhan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp 57d13f5 link true /test e2e-gcp
ci/prow/verify 57d13f5 link true /test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@perdasilva
Copy link
Copy Markdown
Contributor

@xueqzhan I've fixed up your PR here: #368 and I'll close this one. Could you please review mine and make sure it's what you wanted?

@perdasilva
Copy link
Copy Markdown
Contributor

/close

@openshift-ci openshift-ci Bot closed this Aug 23, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 23, 2022

@perdasilva: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants