Skip to content

OCPBUGS-2898: [release-4.10] fix(openshift): use env var instead of clusterversion status (#2817)#389

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.10from
timflannagan:release-4.10-maxOCPVersion-bug
Nov 16, 2022
Merged

OCPBUGS-2898: [release-4.10] fix(openshift): use env var instead of clusterversion status (#2817)#389
openshift-merge-robot merged 1 commit intoopenshift:release-4.10from
timflannagan:release-4.10-maxOCPVersion-bug

Conversation

@timflannagan
Copy link
Copy Markdown
Contributor

Get the current OpenShift release version from the RELEASE_VERSION environment variable since the behavior of the original source -- the ClusterVersion desired release status field -- has changed.

Signed-off-by: Tyler Slaton tyslaton@redhat.com
Co-authored-by: Nick Hale njohnhale@gmail.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: ec9903dba891dc5fd4e42bd06b240a7a82f9283c

Get the current OpenShift release version from the RELEASE_VERSION
environment variable since the behavior of the original source --
the ClusterVersion desired release status field -- has changed.

Signed-off-by: Tyler Slaton <tyslaton@redhat.com>
Co-authored-by: Nick Hale <njohnhale@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: ec9903dba891dc5fd4e42bd06b240a7a82f9283c
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 20, 2022

@timflannagan: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.10] fix(openshift): use env var instead of clusterversion status (#2817)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2022
@timflannagan
Copy link
Copy Markdown
Contributor Author

Manually opening a backport to 4.10 after the cherry pick operation in #347 failed. It's unclear whether this will solve https://issues.redhat.com/browse/OCPBUGS-1543 or whether that's a duplicate of the existing 4.11.z that's been verified.

@tylerslaton
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2022
@perdasilva
Copy link
Copy Markdown
Contributor

/retest

2 similar comments
@tylerslaton
Copy link
Copy Markdown
Contributor

/retest

@tylerslaton
Copy link
Copy Markdown
Contributor

/retest

@timflannagan
Copy link
Copy Markdown
Contributor Author

/test all

@oceanc80
Copy link
Copy Markdown
Contributor

/retitle Bug 2097557: [release-4.10] fix(openshift): use env var instead of clusterversion status (#2817)

@openshift-ci openshift-ci Bot changed the title [release-4.10] fix(openshift): use env var instead of clusterversion status (#2817) Bug 2097557: [release-4.10] fix(openshift): use env var instead of clusterversion status (#2817) Oct 26, 2022
@openshift-ci openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 26, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 26, 2022

@timflannagan: This pull request references Bugzilla bug 2097557, which is invalid:

  • expected the bug to target the "4.10.z" release, but it targets "4.12.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead
  • expected Bugzilla bug 2097557 to depend on a bug targeting a release in 4.11.0, 4.11.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2097557: [release-4.10] fix(openshift): use env var instead of clusterversion status (#2817)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oceanc80
Copy link
Copy Markdown
Contributor

/retitle OCPBUGS-2898: [release-4.10] fix(openshift): use env var instead of clusterversion status (#2817)

@openshift-ci openshift-ci Bot changed the title Bug 2097557: [release-4.10] fix(openshift): use env var instead of clusterversion status (#2817) OCPBUGS-2898: [release-4.10] fix(openshift): use env var instead of clusterversion status (#2817) Oct 26, 2022
@openshift-ci openshift-ci Bot removed the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Oct 26, 2022
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 26, 2022
@openshift-ci-robot
Copy link
Copy Markdown

@timflannagan: This pull request references Jira Issue OCPBUGS-2898, which is invalid:

  • expected the bug to target the "4.10.z" version, but no target version was set
  • expected Jira Issue OCPBUGS-2898 to depend on a bug targeting a version in 4.11.0, 4.11.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Get the current OpenShift release version from the RELEASE_VERSION environment variable since the behavior of the original source -- the ClusterVersion desired release status field -- has changed.

Signed-off-by: Tyler Slaton tyslaton@redhat.com
Co-authored-by: Nick Hale njohnhale@gmail.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: ec9903dba891dc5fd4e42bd06b240a7a82f9283c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 26, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 26, 2022

@timflannagan: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-2898: [release-4.10] fix(openshift): use env var instead of clusterversion status (#2817)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oceanc80
Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

@oceanc80: This pull request references Jira Issue OCPBUGS-2898, which is invalid:

  • expected dependent Jira Issue OCPBUGS-2900 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kuiwang02
Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 27, 2022
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 27, 2022
@openshift-ci-robot
Copy link
Copy Markdown

@kuiwang02: This pull request references Jira Issue OCPBUGS-2898, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.10.z) matches configured target version for branch (4.10.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-2900 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-2900 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
  • bug has dependents

Requesting review from QA contact:
/cc @kuiwang02

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from kuiwang02 October 27, 2022 02:24
@kuiwang02
Copy link
Copy Markdown
Contributor

/label qe-approved
/label cherry-pick-approved

@openshift-ci openshift-ci Bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Oct 27, 2022
@awgreene
Copy link
Copy Markdown
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 27, 2022
@oceanc80
Copy link
Copy Markdown
Contributor

/retest-required

1 similar comment
@oceanc80
Copy link
Copy Markdown
Contributor

/retest-required

@perdasilva
Copy link
Copy Markdown
Contributor

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 14, 2022

@timflannagan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-olm 4f8a9c9 link true /test e2e-aws-olm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oceanc80
Copy link
Copy Markdown
Contributor

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 7837ef2 into openshift:release-4.10 Nov 16, 2022
@openshift-ci-robot
Copy link
Copy Markdown

@timflannagan: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-2898 has been moved to the MODIFIED state.

Details

In response to this:

Get the current OpenShift release version from the RELEASE_VERSION environment variable since the behavior of the original source -- the ClusterVersion desired release status field -- has changed.

Signed-off-by: Tyler Slaton tyslaton@redhat.com
Co-authored-by: Nick Hale njohnhale@gmail.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: ec9903dba891dc5fd4e42bd06b240a7a82f9283c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants