OCPBUGS-1428: fix service account token secret reference (#2862) by awgreene · Pull Request #396 · openshift/operator-framework-olm

awgreene · 2022-09-30T14:51:51Z

Problem: The filterSecretsBySAName function attempts to identify all service account token secrets related to a serviceAccount. To do so, the filterSecretsBySAName function uses a range-for loop to iterate over entries in the secrets argument. If a valid service account token secret is found, a pointer to the range-for loop's value variable is added to a map of results. Unfortunately, if a valid entry is found in the middle of the list of secrets, the value returned by the range-for loop is updated, causes the entry in the map to change.

Solution: Add a pointer to the actual secret instead of the range-for loop's value variable.

Signed-off-by: Alexander Greene greene.al1991@gmail.com

Upstream-repository: operator-lifecycle-manager
Upstream-commit: caab6c52ec532dc82c7178eebb0377bd80d1e82a

Problem: The filterSecretsBySAName function attempts to identify all service account token secrets related to a serviceAccount. To do so, the filterSecretsBySAName function uses a range-for loop to iterate over entries in the secrets argument. If a valid service account token secret is found, a pointer to the range-for loop's value variable is added to a map of results. Unfortunately, if a valid entry is found in the middle of the list of secrets, the value returned by the range-for loop is updated, causes the entry in the map to change. Solution: Add a pointer to the actual secret instead of the range-for loop's value variable. Signed-off-by: Alexander Greene <greene.al1991@gmail.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: caab6c52ec532dc82c7178eebb0377bd80d1e82a

openshift-ci-robot · 2022-09-30T14:52:42Z

@awgreene: This pull request references Jira Issue OCPBUGS-1428, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Xia-Zhao-rh · 2022-10-08T03:19:39Z

/label qe-approved

Xia-Zhao-rh · 2022-10-08T03:22:30Z

/retest

awgreene · 2022-10-21T03:01:23Z

/retest

Xia-Zhao-rh · 2022-10-26T01:11:10Z

/retest

Xia-Zhao-rh · 2022-11-01T01:08:13Z

/retest

jianzhangbjz · 2022-11-02T02:52:40Z

/jira refresh

openshift-ci-robot · 2022-11-02T02:52:43Z

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-1428, which is invalid:

expected the bug to target the "4.13.0" version, but it targets "4.12.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianzhangbjz · 2022-11-02T02:53:23Z

/jira refresh

openshift-ci-robot · 2022-11-02T02:53:26Z

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-1428, which is invalid:

expected the bug to target the "4.13.0" version, but it targets "4.12.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianzhangbjz · 2022-11-02T02:53:52Z

/jira refresh

openshift-ci-robot · 2022-11-02T02:53:55Z

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-1428, which is invalid:

expected the bug to target the "4.13.0" version, but it targets "4.12.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianzhangbjz · 2022-11-02T02:54:55Z

/jira refresh

openshift-ci-robot · 2022-11-02T02:54:58Z

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-1428, which is invalid:

expected the bug to target the "4.13.0" version, but it targets "4.12.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianzhangbjz · 2022-11-02T03:13:07Z

/jira refresh

openshift-ci-robot · 2022-11-02T03:13:09Z

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-1428, which is invalid:

expected the bug to target the "4.13.0" version, but it targets "4.12.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianzhangbjz · 2022-11-02T03:14:26Z

/jira refresh

openshift-ci-robot · 2022-11-02T03:14:31Z

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-1428, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Xia-Zhao-rh

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2022-11-04T10:15:52Z

/retest

Xia-Zhao-rh · 2022-11-14T01:12:23Z

/retest

awgreene · 2022-11-16T16:24:17Z

/retest

awgreene · 2022-11-16T21:59:49Z

/jira refresh

openshift-ci-robot · 2022-11-16T21:59:52Z

@awgreene: This pull request references Jira Issue OCPBUGS-1428, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Xia-Zhao-rh

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

oceanc80 · 2022-11-16T22:12:28Z

/lgtm

dinhxuanvu

/lgtm

openshift-ci · 2022-11-16T22:15:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [awgreene,dinhxuanvu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Xia-Zhao-rh · 2022-11-17T01:24:51Z

/retest

openshift-ci · 2022-11-17T03:37:04Z

@awgreene: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2022-11-17T03:41:37Z

@awgreene: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-1428 has been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2022-11-17T16:20:23Z

/cherry-pick release-4.12

openshift-cherrypick-robot · 2022-11-17T16:21:11Z

@awgreene: new pull request created: #412

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

) Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.19.4 to 0.20.0. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.19.4...v0.20.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Upstream-repository: api Upstream-commit: 0879cf09fcb6d753d923363ba032ad70ceabdc1a

openshift-ci Bot requested review from benluddy and perdasilva September 30, 2022 14:52

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022

awgreene changed the title ~~(bug) Fix service account token secret reference (#2862)~~ OCPBUGS-1428: fix service account token secret reference (#2862) Sep 30, 2022

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 30, 2022

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Oct 8, 2022

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 2, 2022

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 2, 2022

openshift-ci Bot requested a review from Xia-Zhao-rh November 2, 2022 03:14

dinhxuanvu approved these changes Nov 16, 2022

View reviewed changes

openshift-ci Bot assigned oceanc80 Nov 16, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022

openshift-ci Bot assigned dinhxuanvu Nov 16, 2022

openshift-merge-robot merged commit 104da7e into openshift:master Nov 17, 2022

awgreene deleted the ocpbugs-1428 branch November 17, 2022 16:20

openshift-cherrypick-robot mentioned this pull request Nov 17, 2022

[release-4.12] OCPBUGS-3837: fix service account token secret reference (#2862) #412

Merged

openshift-bot mentioned this pull request Mar 15, 2025

NO-ISSUE: Synchronize From Upstream Repositories #984

Merged

Conversation

awgreene commented Sep 30, 2022

Uh oh!

openshift-ci-robot commented Sep 30, 2022

Uh oh!

Xia-Zhao-rh commented Oct 8, 2022

Uh oh!

Xia-Zhao-rh commented Oct 8, 2022

Uh oh!

awgreene commented Oct 21, 2022

Uh oh!

Xia-Zhao-rh commented Oct 26, 2022

Uh oh!

Xia-Zhao-rh commented Nov 1, 2022

Uh oh!

jianzhangbjz commented Nov 2, 2022

Uh oh!

openshift-ci-robot commented Nov 2, 2022

Uh oh!

jianzhangbjz commented Nov 2, 2022

Uh oh!

openshift-ci-robot commented Nov 2, 2022

Uh oh!

jianzhangbjz commented Nov 2, 2022

Uh oh!

openshift-ci-robot commented Nov 2, 2022

Uh oh!

jianzhangbjz commented Nov 2, 2022

Uh oh!

openshift-ci-robot commented Nov 2, 2022

Uh oh!

jianzhangbjz commented Nov 2, 2022

Uh oh!

openshift-ci-robot commented Nov 2, 2022

Uh oh!

jianzhangbjz commented Nov 2, 2022

Uh oh!

openshift-ci-robot commented Nov 2, 2022

Uh oh!

awgreene commented Nov 4, 2022

Uh oh!

Xia-Zhao-rh commented Nov 14, 2022

Uh oh!

awgreene commented Nov 16, 2022

Uh oh!

awgreene commented Nov 16, 2022

Uh oh!

openshift-ci-robot commented Nov 16, 2022

Uh oh!

oceanc80 commented Nov 16, 2022

Uh oh!

dinhxuanvu left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Nov 16, 2022

Uh oh!

Xia-Zhao-rh commented Nov 17, 2022

Uh oh!

openshift-ci Bot commented Nov 17, 2022

Uh oh!

openshift-ci-robot commented Nov 17, 2022

Uh oh!

awgreene commented Nov 17, 2022

Uh oh!

openshift-cherrypick-robot commented Nov 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants