OCPBUGS-5294: backport cert rotation fix by perdasilva · Pull Request #428 · openshift/operator-framework-olm

perdasilva · 2023-01-13T11:06:12Z

Problem: There was a bug in fixed in 4.11 where the operator service certificates were not being rotated properly. The current bug asks use to backport those fixed to 4.10

The backported commits are:

openshift-ci · 2023-01-13T11:06:15Z

@perdasilva: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-5294: backport cert rotation fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-01-13T11:06:16Z

@perdasilva: This pull request references Jira Issue OCPBUGS-5294, which is invalid:

expected Jira Issue OCPBUGS-5294 to depend on a bug targeting a version in 4.11.0, 4.11.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Problem: There was a bug in fixed in 4.11 where the operator service certificates were not being rotated properly. The current bug asks use to backport those fixed to 4.10

The backported commits are:

8b6a36b

Bug 2020484: Refactor installer to surface certificate rotation (#2775) #306

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-01-13T11:06:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

perdasilva · 2023-01-13T11:07:57Z

/jira refresh

openshift-ci-robot · 2023-01-13T11:07:59Z

@perdasilva: This pull request references Jira Issue OCPBUGS-5294, which is invalid:

bug is open, matching expected state (open)
bug target version (4.10.z) matches configured target version for branch (4.10.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
bug has dependents
dependent bug OCPBUGSM-36848 is not in the required OCPBUGS project

All dependent bugs must be part of the OCPBUGS project. If you are backporting a fix that was originally tracked in Bugzilla, follow these steps to handle the backport:

Create a new bug in the OCPBUGS Jira project to match the original bugzilla bug. The important fields that should match are the title, description, target version, and status.
Use the Jira UI to clone the Jira bug, then in the clone bug:
a. Set the target version to the release you are cherrypicking to.
b. Add an issue link “is blocked by”, which links to the original jira bug
Use the cherrypick github command to create the cherrypicked PR. Once that new PR is created, retitle the PR and replace the BUG XXX: with OCPBUGS-XXX: to match the new Jira story.

Note that the mirrored bug in OCPBUGSM should not be involved in this process at all.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

perdasilva · 2023-01-13T11:12:49Z

/jira refresh

openshift-ci-robot · 2023-01-13T11:12:56Z

@perdasilva: This pull request references Jira Issue OCPBUGS-5294, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.10.z) matches configured target version for branch (4.10.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-5819 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-5819 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: perdasilva <perdasilva@redhat.com>

…aming (#2715) * Add importas linting configuration to enforce common package import naming Signed-off-by: timflannagan <timflannagan@gmail.com> * cmd,pkg,test: Fix linting violations Signed-off-by: timflannagan <timflannagan@gmail.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 2194336a87354972a9bc7ea93395571f83147cf6 Signed-off-by: perdasilva <perdasilva@redhat.com>

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> Signed-off-by: perdasilva <perdasilva@redhat.com> Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: d87319abbd63a0553bd6d37f9125faba7bd40fd5

Signed-off-by: perdasilva <perdasilva@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 9ced412f3e263b8827680dc0ad3477327cd9a508

perdasilva · 2023-01-14T10:40:58Z

/retest

perdasilva · 2023-01-15T10:35:50Z

/retest

openshift-ci · 2023-01-15T12:56:36Z

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jianzhangbjz · 2023-01-16T02:25:20Z

Passed, details: https://issues.redhat.com/browse/OCPBUGS-5294
/cherry-pick approved
/lgtm

openshift-cherrypick-robot · 2023-01-16T02:25:22Z

@jianzhangbjz: once the present PR merges, I will cherry-pick it on top of approved in a new PR and assign it to you.

Details

In response to this:

Passed, details: https://issues.redhat.com/browse/OCPBUGS-5294
/cherry-pick approved
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianzhangbjz · 2023-01-16T02:25:41Z

/label cherry-pick-approved

perdasilva · 2023-01-16T09:12:53Z

/label backport-risk-assessed

openshift-ci-robot · 2023-01-16T09:16:11Z

@perdasilva: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#428

Jira Issue OCPBUGS-5294 has been moved to the MODIFIED state.

Details

In response to this:

Problem: There was a bug in fixed in 4.11 where the operator service certificates were not being rotated properly. The current bug asks use to backport those fixed to 4.10

The backported commits are:

8b6a36b

Bug 2020484: Refactor installer to surface certificate rotation (#2775) #306

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2023-01-16T09:17:01Z

@jianzhangbjz: cannot checkout approved: error checking out approved: exit status 1. output: error: pathspec 'approved' did not match any file(s) known to git

Details

In response to this:

Passed, details: https://issues.redhat.com/browse/OCPBUGS-5294
/cherry-pick approved
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 13, 2023

openshift-ci Bot requested review from dinhxuanvu and hasbro17 January 13, 2023 11:06

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2023

openshift-ci Bot requested a review from jianzhangbjz January 13, 2023 11:12

perdasilva force-pushed the OCPBUGS-5294-backport-cert-rotation-fix branch from 8c36965 to 7347755 Compare January 13, 2023 13:32

perdasilva and others added 4 commits January 13, 2023 14:50

update vendor

3b709d3

Signed-off-by: perdasilva <perdasilva@redhat.com>

Refactor installer to surface certificate rotation (#2775)

f778e0d

Signed-off-by: perdasilva <perdasilva@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 9ced412f3e263b8827680dc0ad3477327cd9a508

perdasilva force-pushed the OCPBUGS-5294-backport-cert-rotation-fix branch from 7347755 to f778e0d Compare January 13, 2023 13:55

openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 16, 2023

openshift-ci Bot assigned jianzhangbjz Jan 16, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2023

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 16, 2023

openshift-ci Bot assigned bandrade, kuiwang02 and Xia-Zhao-rh Jan 16, 2023

openshift-merge-robot merged commit 8892eeb into openshift:release-4.10 Jan 16, 2023

Conversation

perdasilva commented Jan 13, 2023

Uh oh!

openshift-ci Bot commented Jan 13, 2023

Uh oh!

openshift-ci-robot commented Jan 13, 2023

Uh oh!

openshift-ci Bot commented Jan 13, 2023

Uh oh!

perdasilva commented Jan 13, 2023

Uh oh!

openshift-ci-robot commented Jan 13, 2023

Uh oh!

perdasilva commented Jan 13, 2023

Uh oh!

openshift-ci-robot commented Jan 13, 2023

Uh oh!

perdasilva commented Jan 14, 2023

Uh oh!

perdasilva commented Jan 15, 2023

Uh oh!

openshift-ci Bot commented Jan 15, 2023

Uh oh!

jianzhangbjz commented Jan 16, 2023

Uh oh!

openshift-cherrypick-robot commented Jan 16, 2023

Uh oh!

jianzhangbjz commented Jan 16, 2023

Uh oh!

perdasilva commented Jan 16, 2023

Uh oh!

openshift-ci-robot commented Jan 16, 2023

Uh oh!

openshift-cherrypick-robot commented Jan 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants