Skip to content

OCPBUGS-948: Set openshift.io/scc label to empty#445

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
tmshort:OCPBUGS-948
Feb 20, 2023
Merged

OCPBUGS-948: Set openshift.io/scc label to empty#445
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
tmshort:OCPBUGS-948

Conversation

@tmshort
Copy link
Copy Markdown
Contributor

@tmshort tmshort commented Feb 14, 2023

Label is unused.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 14, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 14, 2023

@tmshort: This pull request references Jira Issue OCPBUGS-948, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Label is unused.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 14, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Feb 15, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 15, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 15, 2023

@tmshort: This pull request references Jira Issue OCPBUGS-948, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tmshort tmshort marked this pull request as ready for review February 15, 2023 18:30
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2023
@tmshort tmshort changed the title OCPBUGS-948: Remov openshift.io/scc label OCPBUGS-948: Set openshift.io/scc label to empty Feb 15, 2023
@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Feb 16, 2023

/retest

2 similar comments
@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Feb 16, 2023

/retest

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Feb 17, 2023

/retest

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Feb 17, 2023

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2023
@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Feb 17, 2023

@jianzhangbjz can I get a QE on this?

@kuiwang02
Copy link
Copy Markdown
Contributor

kuiwang02 commented Feb 20, 2023

/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Feb 20, 2023
@kuiwang02
Copy link
Copy Markdown
Contributor

kuiwang02 commented Feb 20, 2023

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 20, 2023

@kuiwang02: This pull request references Jira Issue OCPBUGS-948, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @kuiwang02

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from kuiwang02 February 20, 2023 01:01
@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Feb 20, 2023

/retest

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Feb 20, 2023

/retest

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Feb 20, 2023

@awgreene are these failures related to the disruption budget?

ankitathomas
ankitathomas approved these changes Feb 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, perdasilva, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ankitathomas,perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 20, 2023

@tmshort: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit bac0505 into openshift:master Feb 20, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 20, 2023

@tmshort: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-948 has been moved to the MODIFIED state.

Details

In response to this:

Label is unused.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Feb 21, 2023

Should this go to 4.12? @awgreene ?

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Feb 21, 2023

/cherry-pick release-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 21, 2023
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 21, 2023

@tmshort: new pull request created: #456

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Feb 22, 2023

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 22, 2023

@tmshort: Jira Issue OCPBUGS-948 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tmshort tmshort deleted the OCPBUGS-948 branch March 14, 2023 14:58
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Oct 10, 2025
@dependabot
Bump github.com/spf13/cobra from 1.9.1 to 1.10.1 (openshift#445)
953d692 
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.9.1 to 1.10.1.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.9.1...v1.10.1)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-version: 1.10.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: 9ba7f1aed6694a018c4567687ce5713cd42d59e0
@openshift-bot openshift-bot mentioned this pull request Oct 10, 2025
Merged
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Oct 11, 2025
@dependabot
Bump github.com/spf13/cobra from 1.9.1 to 1.10.1 (openshift#445)
ae938ee 
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.9.1 to 1.10.1.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.9.1...v1.10.1)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-version: 1.10.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: 9ba7f1aed6694a018c4567687ce5713cd42d59e0
@camilamacedo86 camilamacedo86 mentioned this pull request Oct 14, 2025
Closed
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Oct 15, 2025
@dependabot
Bump github.com/spf13/cobra from 1.9.1 to 1.10.1 (openshift#445)
a99d328 
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.9.1 to 1.10.1.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.9.1...v1.10.1)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-version: 1.10.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: 9ba7f1aed6694a018c4567687ce5713cd42d59e0
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Oct 18, 2025
@dependabot
Bump github.com/spf13/cobra from 1.9.1 to 1.10.1 (openshift#445)
8bee185 
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.9.1 to 1.10.1.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.9.1...v1.10.1)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-version: 1.10.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: 9ba7f1aed6694a018c4567687ce5713cd42d59e0
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Oct 21, 2025
@dependabot
Bump github.com/spf13/cobra from 1.9.1 to 1.10.1 (openshift#445)
54563e8 
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.9.1 to 1.10.1.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.9.1...v1.10.1)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-version: 1.10.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: 9ba7f1aed6694a018c4567687ce5713cd42d59e0
@anik120 anik120 mentioned this pull request Oct 21, 2025
Merged
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Oct 21, 2025
@dependabot
Bump github.com/spf13/cobra from 1.9.1 to 1.10.1 (openshift#445)
eb60f02 
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.9.1 to 1.10.1.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.9.1...v1.10.1)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-version: 1.10.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: 9ba7f1aed6694a018c4567687ce5713cd42d59e0
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Oct 23, 2025
@dependabot
Bump github.com/spf13/cobra from 1.9.1 to 1.10.1 (openshift#445)
2e47330 
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.9.1 to 1.10.1.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.9.1...v1.10.1)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-version: 1.10.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: 9ba7f1aed6694a018c4567687ce5713cd42d59e0
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Oct 24, 2025
@dependabot
Bump github.com/spf13/cobra from 1.9.1 to 1.10.1 (openshift#445)
c63647b 
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.9.1 to 1.10.1.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.9.1...v1.10.1)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-version: 1.10.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: 9ba7f1aed6694a018c4567687ce5713cd42d59e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

@kuiwang02 kuiwang02 Awaiting requested review from kuiwang02

1 more reviewer

@ankitathomas ankitathomas ankitathomas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ankitathomas ankitathomas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tmshort @openshift-ci-robot @perdasilva @kuiwang02 @openshift-cherrypick-robot @ankitathomas @openshift-merge-robot