OCPBUGS-7904: Cleanup conversion webhooks when an operator is uninstalled by awgreene · Pull Request #458 · openshift/operator-framework-olm

awgreene · 2023-02-22T19:14:04Z

Problem: When uninstalling a CSV, OLM has always avoided deleting the associated CRD as all CRs on cluster are subsequently deleted, possibly resulting in user dataloss.

OLM supports defining conversion webhooks within the CSV. On cluster, conversion webhooks are defined with a CRD and point to a service that handles conversion. If the service is unable to fulfill the request, all requests against the CRs associated with the CRD will fail.

When uninstalling a CSV, OLM does not remove the conversion webhook from the CRD, meaning that all requests against the CRs associated with the CRD will fail, resulting in at least two concerns:

OLM is unable to subsequently reinstall the operator. When installing a CSV, if the CRD already exists and instances of CRs exist as well, OLM performs a series of checks which ensure that none of the CRs are invalidated against the new schema. The existing CRD's conversion webhooks points to a non-existant service, causing the check to fail and preventing installs.
Broken conversion webhooks causes kubernete's garbage collection to fail.

Solution: When a CSV is deleted, if no CSV exists that is replacing it, set the CRD's conversion strategy to None.

Signed-off-by: Alexander Greene greene.al1991@gmail.com

Upstream-commit: 94374983d448c56d031f0493b84b6dce37b84741
Upstream-repository: operator-lifecycle-manager

awgreene · 2023-02-22T19:14:31Z

/jira refresh

openshift-ci · 2023-02-22T19:18:43Z

@awgreene: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-7904: Cleanup conversion webhooks when an operator is uninstalled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2023-02-22T19:19:00Z

/jira refresh

openshift-ci-robot · 2023-02-22T19:20:49Z

@awgreene: This pull request references Jira Issue OCPBUGS-7904, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.10.z) matches configured target version for branch (4.10.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-1556 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-1556 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-02-22T19:22:44Z

@awgreene: This pull request references Jira Issue OCPBUGS-7904, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.10.z) matches configured target version for branch (4.10.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-1556 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-1556 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Problem: When uninstalling a CSV, OLM has always avoided deleting the associated CRD as all CRs on cluster are subsequently deleted, possibly resulting in user dataloss.

OLM supports defining conversion webhooks within the CSV. On cluster, conversion webhooks are defined with a CRD and point to a service that handles conversion. If the service is unable to fulfill the request, all requests against the CRs associated with the CRD will fail.

When uninstalling a CSV, OLM does not remove the conversion webhook from the CRD, meaning that all requests against the CRs associated with the CRD will fail, resulting in at least two concerns:

OLM is unable to subsequently reinstall the operator. When installing a CSV, if the CRD already exists and instances of CRs exist as well, OLM performs a series of checks which ensure that none of the CRs are invalidated against the new schema. The existing CRD's conversion webhooks points to a non-existant service, causing the check to fail and preventing installs.

Broken conversion webhooks causes kubernete's garbage collection to fail.

Solution: When a CSV is deleted, if no CSV exists that is replacing it, set the CRD's conversion strategy to None.

Signed-off-by: Alexander Greene greene.al1991@gmail.com

Upstream-commit: 94374983d448c56d031f0493b84b6dce37b84741
Upstream-repository: operator-lifecycle-manager

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-02-22T19:22:53Z

@awgreene: This pull request references Jira Issue OCPBUGS-7904, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.10.z) matches configured target version for branch (4.10.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-1556 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-1556 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-02-22T19:23:22Z

@awgreene: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

Details

In response to this:

[release-4.10] OCPBUGS-7904: Cleanup conversion webhooks when an operator is uninstalled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2023-03-01T12:28:07Z

/jira refresh

openshift-ci-robot · 2023-03-01T12:28:11Z

@awgreene: This pull request references Jira Issue OCPBUGS-7904, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.10.z) matches configured target version for branch (4.10.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-1556 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-1556 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2023-03-01T12:28:24Z

/retest

kuiwang02 · 2023-03-06T01:36:01Z

/jira refresh

kuiwang02 · 2023-03-06T02:45:08Z

/label cherry-pick-approved

kuiwang02 · 2023-03-06T02:45:19Z

/label qe-approved

perdasilva · 2023-03-07T14:38:40Z

/retest

grokspawn · 2023-03-15T15:53:01Z

/retest

awgreene · 2023-03-23T18:07:32Z

/retest

awgreene · 2023-03-28T16:41:18Z

/retest

awgreene · 2023-04-17T16:47:14Z

/retest

ankitathomas · 2023-04-28T22:11:41Z

/test unit-psm

ankitathomas · 2023-06-29T21:57:33Z

/retest

ankitathomas · 2023-06-30T17:17:22Z

/retest

m1kola · 2023-07-03T08:14:48Z

/retest

ankitathomas · 2023-07-10T15:44:22Z

/retest

ankitathomas · 2023-07-14T16:54:38Z

/retest

perdasilva · 2023-07-17T09:37:00Z

/retest

perdasilva · 2023-07-18T12:39:31Z

/retest

awgreene · 2023-07-18T17:20:36Z

/retest

awgreene · 2023-07-20T14:42:12Z

/retest

m1kola

/lgtm

openshift-ci · 2023-07-21T09:31:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, m1kola

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [awgreene]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

perdasilva · 2023-07-25T11:39:43Z

/label backport-risk-assessed

openshift-ci · 2023-07-25T14:10:10Z

@awgreene: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-07-25T14:12:41Z

@awgreene: Jira Issue OCPBUGS-7904: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#458

Jira Issue OCPBUGS-7904 has been moved to the MODIFIED state.

Details

In response to this:

Problem: When uninstalling a CSV, OLM has always avoided deleting the associated CRD as all CRs on cluster are subsequently deleted, possibly resulting in user dataloss.

OLM supports defining conversion webhooks within the CSV. On cluster, conversion webhooks are defined with a CRD and point to a service that handles conversion. If the service is unable to fulfill the request, all requests against the CRs associated with the CRD will fail.

When uninstalling a CSV, OLM does not remove the conversion webhook from the CRD, meaning that all requests against the CRs associated with the CRD will fail, resulting in at least two concerns:

OLM is unable to subsequently reinstall the operator. When installing a CSV, if the CRD already exists and instances of CRs exist as well, OLM performs a series of checks which ensure that none of the CRs are invalidated against the new schema. The existing CRD's conversion webhooks points to a non-existant service, causing the check to fail and preventing installs.

Broken conversion webhooks causes kubernete's garbage collection to fail.

Solution: When a CSV is deleted, if no CSV exists that is replacing it, set the CRD's conversion strategy to None.

Signed-off-by: Alexander Greene greene.al1991@gmail.com

Upstream-commit: 94374983d448c56d031f0493b84b6dce37b84741
Upstream-repository: operator-lifecycle-manager

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bumps the k8s-dependencies group with 4 updates: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver), [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) and [k8s.io/client-go](https://github.com/kubernetes/client-go). Updates `k8s.io/api` from 0.34.1 to 0.34.2 - [Commits](kubernetes/api@v0.34.1...v0.34.2) Updates `k8s.io/apiextensions-apiserver` from 0.34.1 to 0.34.2 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.34.1...v0.34.2) Updates `k8s.io/apimachinery` from 0.34.1 to 0.34.2 - [Commits](kubernetes/apimachinery@v0.34.1...v0.34.2) Updates `k8s.io/client-go` from 0.34.1 to 0.34.2 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.34.1...v0.34.2) --- updated-dependencies: - dependency-name: k8s.io/api dependency-version: 0.34.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/apiextensions-apiserver dependency-version: 0.34.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/apimachinery dependency-version: 0.34.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/client-go dependency-version: 0.34.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Upstream-repository: api Upstream-commit: 500bb71a8304901844ed5cbee46b4c08b1a630b5

awgreene changed the title ~~[release-4.10] OCPBUGS-7904: Cleanup conversion webhooks when an operator is uninstalled~~ OCPBUGS-7904: Cleanup conversion webhooks when an operator is uninstalled Feb 22, 2023

openshift-ci Bot requested review from anik120, gallettilance and jianzhangbjz February 22, 2023 19:24

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2023

openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 6, 2023

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Mar 6, 2023

m1kola approved these changes Jul 21, 2023

View reviewed changes

openshift-ci Bot assigned m1kola Jul 21, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2023

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 25, 2023

openshift-ci Bot assigned bandrade, emmajiafan, jianzhangbjz, KeenonLee, kuiwang02 and Xia-Zhao-rh Jul 25, 2023

openshift-merge-robot merged commit 7e2e799 into openshift:release-4.10 Jul 25, 2023

openshift-bot mentioned this pull request Dec 18, 2025

NO-ISSUE: Synchronize From Upstream Repositories #1168

Merged

Conversation

awgreene commented Feb 22, 2023

Uh oh!

awgreene commented Feb 22, 2023

Uh oh!

openshift-ci Bot commented Feb 22, 2023

Uh oh!

awgreene commented Feb 22, 2023

Uh oh!

openshift-ci-robot commented Feb 22, 2023

Uh oh!

openshift-ci-robot commented Feb 22, 2023

Uh oh!

openshift-ci-robot commented Feb 22, 2023

Uh oh!

openshift-ci Bot commented Feb 22, 2023

Uh oh!

awgreene commented Mar 1, 2023

Uh oh!

openshift-ci-robot commented Mar 1, 2023

Uh oh!

awgreene commented Mar 1, 2023

Uh oh!

kuiwang02 commented Mar 6, 2023

Uh oh!

kuiwang02 commented Mar 6, 2023

Uh oh!

kuiwang02 commented Mar 6, 2023

Uh oh!

perdasilva commented Mar 7, 2023

Uh oh!

grokspawn commented Mar 15, 2023

Uh oh!

awgreene commented Mar 23, 2023

Uh oh!

awgreene commented Mar 28, 2023

Uh oh!

awgreene commented Apr 17, 2023

Uh oh!

ankitathomas commented Apr 28, 2023

Uh oh!

ankitathomas commented Jun 29, 2023

Uh oh!

ankitathomas commented Jun 30, 2023

Uh oh!

m1kola commented Jul 3, 2023

Uh oh!

ankitathomas commented Jul 10, 2023

Uh oh!

ankitathomas commented Jul 14, 2023

Uh oh!

perdasilva commented Jul 17, 2023

Uh oh!

perdasilva commented Jul 18, 2023

Uh oh!

awgreene commented Jul 18, 2023

Uh oh!

awgreene commented Jul 20, 2023

Uh oh!

m1kola left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jul 21, 2023

Uh oh!

perdasilva commented Jul 25, 2023

Uh oh!

openshift-ci Bot commented Jul 25, 2023

Uh oh!

openshift-ci-robot commented Jul 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants