OPECO-2737: Veneer template rename by grokspawn · Pull Request #461 · openshift/operator-framework-olm

grokspawn · 2023-02-27T21:44:47Z

Pulling along several commits in order to make this a simpler cherry-pick.

openshift-ci-robot · 2023-02-27T21:44:51Z

@grokspawn: This pull request references OPECO-2737 which is a valid jira issue.

Details

In response to this:

Pulling along several commits in order to make this a simpler cherry-pick.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-02-27T21:46:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [grokspawn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

perdasilva · 2023-02-28T09:19:58Z

/retest

* initial implementation pass * update implementation * add unit tests and any changes necessary in relation to adding unit tests. * verify schemas and fail if they don't match * add better validations and decrease some code duplication as well as add the necessary additional test cases * remove some TODO comments and hardcode containerTool as 'docker' as per review comments * update the custom veneer builder to work like the other veneer builders by reading a full FBC from STDOUT and writing it to the output destination in the custom veneer config. Also adds additional test cases to cover the new changes. Signed-off-by: Bryce Palmer <bpalmer@redhat.com> Upstream-repository: operator-registry Upstream-commit: 104e0276e46d4aae6d4d8b364c03576893229e71

Upstream-repository: operator-registry Upstream-commit: 979865370ec633e0f6b711be50a93dccf6d4fbe5 Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

…be empty in error scenario (#1032) Upstream-repository: operator-registry Upstream-commit: d888b725a43440428800c3eea06adaafe1110a56 Signed-off-by: Adam D. Cornett <adc@redhat.com>

* update render unmarshal failures * revamp for pretty format, error.As approach Upstream-repository: operator-registry Upstream-commit: 249ae621bb8fa6fc8a8e4a5ae26355577393f127 Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

…st on generated files (#1060) Signed-off-by: Jordan <jordan@nimblewidget.com> Upstream-repository: operator-registry Upstream-commit: 67e6777b5f5f9d337b94da98b8c550c231a8b47c

* rename template to veneer * fixing some utest * adding cobra exit-status consistency through command hierarchy, adding temp skips of failing utests until we get the new release Signed-off-by: Jordan Keister <jordan@nimblewidget.com> Upstream-repository: operator-registry Upstream-commit: 57a959da1177335976c5efcc592cc423ff90e2cd --------- Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

Signed-off-by: Jordan Keister <jordan@nimblewidget.com> Upstream-repository: operator-registry Upstream-commit: 1446d7be762d9eb3c88dddb2828a61debdcd6cd6

Signed-off-by: Jordan Keister <jordan@nimblewidget.com> Upstream-repository: operator-registry Upstream-commit: 0a7ff74f9fc6c92be12a48a0f8e67ecfb6a8e60e

grokspawn · 2023-02-28T15:37:36Z

/hold
This is getting increasingly sticky, both in terms of the number of dependent commits that need to be brought in (looks complete now?) and the nested docker/podman actions which currently fail CI.
I think we need to explore taking up an existing issue to avoid the nesting, which would make this downstream go more smoothly.

* initial update to avoid nested docker execution * unit tests pass Signed-off-by: Jordan Keister <jordan@nimblewidget.com> Upstream-commit: 11491753383c0f8b929d31026e53189610a83574 Upstream-repository: operator-registry

grokspawn · 2023-03-14T19:44:01Z

/hold cancel

Now downstreaming the removal of nested docker execution which should enable e2e.

grokspawn · 2023-03-14T20:36:33Z

/override ci/prow/verify
Blacklisting some upstream OWNER updates to that we don't plan to ever downstream, and verify hates the 'downstream-only' nature of it. :(

openshift-ci · 2023-03-14T20:36:56Z

@grokspawn: Overrode contexts on behalf of grokspawn: ci/prow/verify

Details

In response to this:

/override ci/prow/verify
Adding some upstream OWNER updates that we don't plan to ever downstream, and verify hates the 'downstream-only' nature of it. :(

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

grokspawn · 2023-03-15T14:26:04Z

/retest

grokspawn · 2023-03-15T16:09:13Z

/retest

grokspawn · 2023-03-15T18:34:50Z

/retest

grokspawn · 2023-03-16T13:18:33Z

/retest

grokspawn · 2023-03-20T15:09:33Z

/retest

grokspawn · 2023-03-21T17:35:33Z

/retest

grokspawn · 2023-03-21T20:54:44Z

/retest

grokspawn · 2023-03-22T11:56:14Z

This is a renaming event across all alpha functionality, seeking parity with upstream. Applying labels
/label qe-approved
/label docs-approved
/label px-approved

oceanc80 · 2023-03-22T12:16:08Z

/lgtm

openshift-ci-robot · 2023-03-22T12:47:56Z

/retest-required

Remaining retests: 0 against base HEAD 88f2e1e and 2 for PR HEAD bd18612 in total

grokspawn · 2023-03-22T15:20:05Z

RE-overriding ci/prow/verify due to downstream-only OWNER changes, since this has to be done in both review and pre-commit phases. :(

/override ci/prow/verify
Blacklisting some upstream OWNER updates to that we don't plan to ever downstream, and verify hates the 'downstream-only' nature of it. :(

openshift-ci · 2023-03-22T15:24:32Z

@grokspawn: Overrode contexts on behalf of grokspawn: ci/prow/verify

Details

In response to this:

RE-overriding ci/prow/verify due to downstream-only OWNER changes, since this has to be done in both review and pre-commit phases. :(

/override ci/prow/verify
Blacklisting some upstream OWNER updates to that we don't plan to ever downstream, and verify hates the 'downstream-only' nature of it. :(

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-22T15:24:35Z

@grokspawn: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Bumps the k8s-dependencies group with 4 updates: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver), [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) and [k8s.io/client-go](https://github.com/kubernetes/client-go). Updates `k8s.io/api` from 0.34.2 to 0.34.3 - [Commits](kubernetes/api@v0.34.2...v0.34.3) Updates `k8s.io/apiextensions-apiserver` from 0.34.2 to 0.34.3 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.34.2...v0.34.3) Updates `k8s.io/apimachinery` from 0.34.2 to 0.34.3 - [Commits](kubernetes/apimachinery@v0.34.2...v0.34.3) Updates `k8s.io/client-go` from 0.34.2 to 0.34.3 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.34.2...v0.34.3) --- updated-dependencies: - dependency-name: k8s.io/api dependency-version: 0.34.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/apiextensions-apiserver dependency-version: 0.34.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/apimachinery dependency-version: 0.34.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: k8s.io/client-go dependency-version: 0.34.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Upstream-repository: api Upstream-commit: 78e2ba7d3177a1a37d5dd957b2723eafb30b1f15

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 27, 2023

openshift-ci Bot requested review from dinhxuanvu and hasbro17 February 27, 2023 21:46

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023

everettraven and others added 7 commits February 28, 2023 07:28

update opm dockerfile example to cache (#1033)

d03109b

Upstream-repository: operator-registry Upstream-commit: 979865370ec633e0f6b711be50a93dccf6d4fbe5 Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

change to log image ref value when resolving name, since name will …

1c4b8e8

…be empty in error scenario (#1032) Upstream-repository: operator-registry Upstream-commit: d888b725a43440428800c3eea06adaafe1110a56 Signed-off-by: Adam D. Cornett <adc@redhat.com>

Unmarshall error details (#1040)

44dab56

* update render unmarshal failures * revamp for pretty format, error.As approach Upstream-repository: operator-registry Upstream-commit: 249ae621bb8fa6fc8a8e4a5ae26355577393f127 Signed-off-by: Jordan Keister <jordan@nimblewidget.com>

use mount flag to force consistent selinux labelling between host/gue…

6c219d3

…st on generated files (#1060) Signed-off-by: Jordan <jordan@nimblewidget.com> Upstream-repository: operator-registry Upstream-commit: 67e6777b5f5f9d337b94da98b8c550c231a8b47c

updating image pullspec to rename baseimage (#1068)

75adfce

Signed-off-by: Jordan Keister <jordan@nimblewidget.com> Upstream-repository: operator-registry Upstream-commit: 1446d7be762d9eb3c88dddb2828a61debdcd6cd6

grokspawn force-pushed the veneer-template-rename branch from c834a04 to 4d28ac4 Compare February 28, 2023 13:33

updating template demos (#1071)

70db6c3

Signed-off-by: Jordan Keister <jordan@nimblewidget.com> Upstream-repository: operator-registry Upstream-commit: 0a7ff74f9fc6c92be12a48a0f8e67ecfb6a8e60e

grokspawn force-pushed the veneer-template-rename branch from 4d28ac4 to 70db6c3 Compare February 28, 2023 13:46

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2023

everettraven mentioned this pull request Mar 7, 2023

Sync 0307 #465

Closed

grokspawn force-pushed the veneer-template-rename branch from dc77fcf to 07d6a1f Compare March 14, 2023 18:12

grokspawn force-pushed the veneer-template-rename branch from 07d6a1f to bd18612 Compare March 14, 2023 18:15

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2023

openshift-ci Bot added qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Mar 22, 2023

openshift-ci Bot assigned oceanc80 Mar 22, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2023

openshift-merge-robot merged commit 3a82ea6 into openshift:master Mar 22, 2023

grokspawn deleted the veneer-template-rename branch April 5, 2023 21:13

openshift-bot mentioned this pull request Jan 24, 2026

OPRUN-4415, OPRUN-4195, OPRUN-4275, OPRUN-4276: Synchronize From Upstream Repositories #1202

Merged

Conversation

grokspawn commented Feb 27, 2023

Uh oh!

openshift-ci-robot commented Feb 27, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Feb 27, 2023

Uh oh!

perdasilva commented Feb 28, 2023

Uh oh!

grokspawn commented Feb 28, 2023

Uh oh!

grokspawn commented Mar 14, 2023

Uh oh!

grokspawn commented Mar 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Mar 14, 2023

Uh oh!

grokspawn commented Mar 15, 2023

Uh oh!

grokspawn commented Mar 15, 2023

Uh oh!

grokspawn commented Mar 15, 2023

Uh oh!

grokspawn commented Mar 16, 2023

Uh oh!

grokspawn commented Mar 20, 2023

Uh oh!

grokspawn commented Mar 21, 2023

Uh oh!

grokspawn commented Mar 21, 2023

Uh oh!

grokspawn commented Mar 22, 2023

Uh oh!

oceanc80 commented Mar 22, 2023

Uh oh!

openshift-ci-robot commented Mar 22, 2023

Uh oh!

grokspawn commented Mar 22, 2023

Uh oh!

openshift-ci Bot commented Mar 22, 2023

Uh oh!

openshift-ci Bot commented Mar 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

openshift-ci-robot commented Feb 27, 2023 •

edited by openshift-ci Bot

Loading

grokspawn commented Mar 14, 2023 •

edited

Loading